fix: warnings on logs

Author: Marc-Antoine-Soucy

src/app/ApplicationTemplate.Access/PlatformServices/Email/MockedEmailService.cs

@@ -15,7 +15,10 @@ public MockedEmailService(ILogger<MockedEmailService> logger)
 
 	public Task Compose(CancellationToken ct, Email email)
 	{
-		_logger.LogInformation("Email composed: {Email}", email);
+		if (_logger.IsEnabled(LogLevel.Information))
+		{
+			_logger.LogInformation("Email composed: {Email}", email);
+		}
 		return Task.CompletedTask;
 	}
 }

src/app/ApplicationTemplate.Business/KillSwitch/KillSwitchService.cs

@@ -26,5 +26,11 @@ public KillSwitchService(IKillSwitchDataSource killSwitchDataSource, ILogger<Kil
 
 	/// <inheritdoc/>
 	public IObservable<bool> ObserveKillSwitchActivation() => _killSwitchDataSource.ObserveKillSwitchActivation()
-		.Do(isActive => _logger.LogInformation("Kill switch is now {IsActive}.", isActive));
+		.Do(isActive =>
+		{
+			if (_logger.IsEnabled(LogLevel.Information))
+			{
+				_logger.LogInformation("Kill switch is now {IsActive}.", isActive);
+			}
+		});
 }

src/app/ApplicationTemplate.Presentation/Configuration/ErrorConfiguration.cs

@@ -41,7 +41,11 @@ public static void OnUnhandledException(Exception exception, bool isTerminating,
 		}
 
 		var logger = services.GetRequiredService<ILogger<CoreStartup>>();
-		logger.LogError(exception, "An unhandled exception occurred. StackTrace: {StackTrace}", exception.StackTrace);
+
+		if (logger.IsEnabled(LogLevel.Error))
+		{
+			logger.LogError(exception, "An unhandled exception occurred. StackTrace: {StackTrace}", exception.StackTrace);
+		}
 	}
 
 	private static async Task HandleCommandException(CancellationToken ct, IDynamicCommand command, Exception exception, IServiceProvider services)

src/app/ApplicationTemplate.Presentation/CoreStartup.cs

@@ -229,7 +229,10 @@ private void SuscribeToKillSwitch(IServiceProvider serviceProvider)
 		killSwitchService.ObserveKillSwitchActivation()
 			.SelectManyDisposePrevious(async (activated, ct) =>
 			{
-				Logger.LogTrace("Kill switch activation changed to {Activated}.", activated);
+				if (Logger.IsEnabled(LogLevel.Trace))
+				{
+					Logger.LogTrace("Kill switch activation changed to {Activated}.", activated);
+				}
 
 				if (activated)
 				{

src/app/ApplicationTemplate.Presentation/Framework/DataLoader/LogErrorDataLoaderStrategy.cs

@@ -31,7 +31,10 @@ public override async Task<object> Load(CancellationToken ct, IDataLoaderRequest
 		}
 		catch (Exception error)
 		{
-			_logger.LogError(error, "Failed to load request '{RequestSequenceId}' in DataLoader '{DataLoaderName}'.", request.SequenceId, request.Context.GetDataLoaderName());
+			if (_logger.IsEnabled(LogLevel.Error))
+			{
+				_logger.LogError(error, "Failed to load request '{RequestSequenceId}' in DataLoader '{DataLoaderName}'.", request.SequenceId, request.Context.GetDataLoaderName());
+			}
 
 			throw;
 		}

src/app/ApplicationTemplate.Presentation/Framework/Startup/CoreStartupBase.cs

@@ -150,7 +150,10 @@ public async Task Start()
 
 		var isFirstStart = !State.IsStarted;
 
-		Logger.LogDebug("Starting services (isFirstStart: {IsFirstStart}).", isFirstStart);
+		if (Logger.IsEnabled(LogLevel.Debug))
+		{
+			Logger.LogDebug("Starting services (isFirstStart: {IsFirstStart}).", isFirstStart);
+		}
 
 		await StartServices(ServiceProvider, isFirstStart);
 

src/app/ApplicationTemplate.Presentation/Framework/Startup/StartupBase.cs

@@ -152,7 +152,10 @@ public async Task Start()
 
 		async Task StartViewServicesWithLogs(IServiceProvider services, bool isFirstStart)
 		{
-			Logger.LogDebug("Starting view services (isFirstStart: {IsFirstStart}).", isFirstStart);
+			if (Logger.IsEnabled(LogLevel.Debug))
+			{
+				Logger.LogDebug("Starting view services (isFirstStart: {IsFirstStart}).", isFirstStart);
+			}
 
 			await StartViewServices(services, isFirstStart);
 

src/app/ApplicationTemplate.Presentation/Framework/Startup/WritableJsonConfigurationProvider.cs

@@ -50,8 +50,10 @@ public override void Set(string key, string value)
 			}
 		}
 
-		_logger.LogDebug("Serialized ­­­­{PairCount} key-value-pairs in {ElapsedMilliseconds}ms.", Data.Count, stopwatch.ElapsedMilliseconds);
-
+		if (_logger.IsEnabled(LogLevel.Debug))
+		{
+			_logger.LogDebug("Serialized ­­­­{PairCount} key-value-pairs in {ElapsedMilliseconds}ms.", Data.Count, stopwatch.ElapsedMilliseconds);
+		}
 		OnReload();
 	}
 }

src/app/ApplicationTemplate.Presentation/Framework/ViewModels/IViewModel.Extensions.Options.cs

@@ -126,7 +126,12 @@ string GetValueAsString(TValue value)
 		{
 			if (value is not string && value is not bool)
 			{
-				viewModel.GetService<ILogger<TOptions>>().LogWarning("Serialization of type {TypeName} may be wrong. Consider using the valueToString parameter from the GetFromOptionsMonitor method.", typeof(TValue).Name);
+				var logger = viewModel.GetService<ILogger>();
+
+				if (logger.IsEnabled(LogLevel.Warning))
+				{
+					logger.LogWarning("Serialization of type {TypeName} may be wrong. Consider using the valueToString parameter from the GetFromOptionsMonitor method.", typeof(TValue).Name);
+				}
 			}
 
 			return value.ToString();

src/app/ApplicationTemplate.Presentation/ViewModels/Diagnostics/LoggersDiagnosticsViewModel.cs

@@ -83,7 +83,12 @@ await this.GetService<IMessageDialogService>().ShowMessage(ct, mb => mb
 
 	private async Task OnConsoleLoggingChanged(CancellationToken ct, bool isEnabled)
 	{
-		this.GetService<ILogger<LoggersDiagnosticsViewModel>>().LogInformation("{IsEnabled} console logging.", isEnabled ? "Enabling" : "Disabling");
+		var logger = this.GetService<ILogger<LoggersDiagnosticsViewModel>>();
+
+		if (logger.IsEnabled(LogLevel.Information))
+		{
+			logger.LogInformation("{IsEnabled} console logging.", isEnabled ? "Enabling" : "Disabling");
+		}
 
 		await this.GetService<IMessageDialogService>().ShowMessage(ct, mb => mb
 			.Title("Diagnostics")
@@ -94,7 +99,12 @@ await this.GetService<IMessageDialogService>().ShowMessage(ct, mb => mb
 
 	private async Task OnFileLoggingChanged(CancellationToken ct, bool isEnabled)
 	{
-		this.GetService<ILogger<LoggersDiagnosticsViewModel>>().LogInformation("{IsEnabled} file logging.", isEnabled ? "Enabling" : "Disabling");
+		var logger = this.GetService<ILogger<LoggersDiagnosticsViewModel>>();
+
+		if (logger.IsEnabled(LogLevel.Information))
+		{
+			logger.LogInformation("{IsEnabled} file logging.", isEnabled ? "Enabling" : "Disabling");
+		}
 
 		await this.GetService<IMessageDialogService>().ShowMessage(ct, mb => mb
 			.Title("Diagnostics")