fix: warnings on logs

Marc-Antoine-Soucy · Marc-Antoine-Soucy · commit ff13314e030f · 2026-01-12T10:06:55.000-05:00
diff --git a/src/app/ApplicationTemplate.Access/PlatformServices/Email/MockedEmailService.cs b/src/app/ApplicationTemplate.Access/PlatformServices/Email/MockedEmailService.cs
@@ -15,7 +15,10 @@ public MockedEmailService(ILogger<MockedEmailService> logger)
 
 	public Task Compose(CancellationToken ct, Email email)
 	{
-		_logger.LogInformation("Email composed: {Email}", email);
+		if (_logger.IsEnabled(LogLevel.Information))
+		{
+			_logger.LogInformation("Email composed: {Email}", email);
+		}
 		return Task.CompletedTask;
 	}
 }
diff --git a/src/app/ApplicationTemplate.Business/KillSwitch/KillSwitchService.cs b/src/app/ApplicationTemplate.Business/KillSwitch/KillSwitchService.cs
@@ -26,5 +26,11 @@ public KillSwitchService(IKillSwitchDataSource killSwitchDataSource, ILogger<Kil
 
 	/// <inheritdoc/>
 	public IObservable<bool> ObserveKillSwitchActivation() => _killSwitchDataSource.ObserveKillSwitchActivation()
-		.Do(isActive => _logger.LogInformation("Kill switch is now {IsActive}.", isActive));
+		.Do(isActive =>
+		{
+			if (_logger.IsEnabled(LogLevel.Information))
+			{
+				_logger.LogInformation("Kill switch is now {IsActive}.", isActive);
+			}
+		});
 }
diff --git a/src/app/ApplicationTemplate.Presentation/Configuration/ErrorConfiguration.cs b/src/app/ApplicationTemplate.Presentation/Configuration/ErrorConfiguration.cs
@@ -41,7 +41,11 @@ public static void OnUnhandledException(Exception exception, bool isTerminating,
 		}
 
 		var logger = services.GetRequiredService<ILogger<CoreStartup>>();
-		logger.LogError(exception, "An unhandled exception occurred. StackTrace: {StackTrace}", exception.StackTrace);
+
+		if (logger.IsEnabled(LogLevel.Error))
+		{
+			logger.LogError(exception, "An unhandled exception occurred. StackTrace: {StackTrace}", exception.StackTrace);
+		}
 	}
 
 	private static async Task HandleCommandException(CancellationToken ct, IDynamicCommand command, Exception exception, IServiceProvider services)
diff --git a/src/app/ApplicationTemplate.Presentation/CoreStartup.cs b/src/app/ApplicationTemplate.Presentation/CoreStartup.cs
@@ -229,7 +229,10 @@ private void SuscribeToKillSwitch(IServiceProvider serviceProvider)
 		killSwitchService.ObserveKillSwitchActivation()
 			.SelectManyDisposePrevious(async (activated, ct) =>
 			{
-				Logger.LogTrace("Kill switch activation changed to {Activated}.", activated);
+				if (Logger.IsEnabled(LogLevel.Trace))
+				{
+					Logger.LogTrace("Kill switch activation changed to {Activated}.", activated);
+				}
 
 				if (activated)
 				{
diff --git a/src/app/ApplicationTemplate.Presentation/Framework/DataLoader/LogErrorDataLoaderStrategy.cs b/src/app/ApplicationTemplate.Presentation/Framework/DataLoader/LogErrorDataLoaderStrategy.cs
@@ -31,7 +31,10 @@ public override async Task<object> Load(CancellationToken ct, IDataLoaderRequest
 		}
 		catch (Exception error)
 		{
-			_logger.LogError(error, "Failed to load request '{RequestSequenceId}' in DataLoader '{DataLoaderName}'.", request.SequenceId, request.Context.GetDataLoaderName());
+			if (_logger.IsEnabled(LogLevel.Error))
+			{
+				_logger.LogError(error, "Failed to load request '{RequestSequenceId}' in DataLoader '{DataLoaderName}'.", request.SequenceId, request.Context.GetDataLoaderName());
+			}
 
 			throw;
 		}
diff --git a/src/app/ApplicationTemplate.Presentation/Framework/Startup/CoreStartupBase.cs b/src/app/ApplicationTemplate.Presentation/Framework/Startup/CoreStartupBase.cs
@@ -150,7 +150,10 @@ public async Task Start()
 
 		var isFirstStart = !State.IsStarted;
 
-		Logger.LogDebug("Starting services (isFirstStart: {IsFirstStart}).", isFirstStart);
+		if (Logger.IsEnabled(LogLevel.Debug))
+		{
+			Logger.LogDebug("Starting services (isFirstStart: {IsFirstStart}).", isFirstStart);
+		}
 
 		await StartServices(ServiceProvider, isFirstStart);
 
diff --git a/src/app/ApplicationTemplate.Presentation/Framework/Startup/StartupBase.cs b/src/app/ApplicationTemplate.Presentation/Framework/Startup/StartupBase.cs
@@ -152,7 +152,10 @@ public async Task Start()
 
 		async Task StartViewServicesWithLogs(IServiceProvider services, bool isFirstStart)
 		{
-			Logger.LogDebug("Starting view services (isFirstStart: {IsFirstStart}).", isFirstStart);
+			if (Logger.IsEnabled(LogLevel.Debug))
+			{
+				Logger.LogDebug("Starting view services (isFirstStart: {IsFirstStart}).", isFirstStart);
+			}
 
 			await StartViewServices(services, isFirstStart);
 
diff --git a/src/app/ApplicationTemplate.Presentation/Framework/Startup/WritableJsonConfigurationProvider.cs b/src/app/ApplicationTemplate.Presentation/Framework/Startup/WritableJsonConfigurationProvider.cs
@@ -50,8 +50,10 @@ public override void Set(string key, string value)
 			}
 		}
 
-		_logger.LogDebug("Serialized ­­­­{PairCount} key-value-pairs in {ElapsedMilliseconds}ms.", Data.Count, stopwatch.ElapsedMilliseconds);
-
+		if (_logger.IsEnabled(LogLevel.Debug))
+		{
+			_logger.LogDebug("Serialized ­­­­{PairCount} key-value-pairs in {ElapsedMilliseconds}ms.", Data.Count, stopwatch.ElapsedMilliseconds);
+		}
 		OnReload();
 	}
 }
diff --git a/src/app/ApplicationTemplate.Presentation/Framework/ViewModels/IViewModel.Extensions.Options.cs b/src/app/ApplicationTemplate.Presentation/Framework/ViewModels/IViewModel.Extensions.Options.cs
@@ -126,7 +126,12 @@ string GetValueAsString(TValue value)
 		{
 			if (value is not string && value is not bool)
 			{
-				viewModel.GetService<ILogger<TOptions>>().LogWarning("Serialization of type {TypeName} may be wrong. Consider using the valueToString parameter from the GetFromOptionsMonitor method.", typeof(TValue).Name);
+				var logger = viewModel.GetService<ILogger>();
+
+				if (logger.IsEnabled(LogLevel.Warning))
+				{
+					logger.LogWarning("Serialization of type {TypeName} may be wrong. Consider using the valueToString parameter from the GetFromOptionsMonitor method.", typeof(TValue).Name);
+				}
 			}
 
 			return value.ToString();
diff --git a/src/app/ApplicationTemplate.Presentation/ViewModels/Diagnostics/LoggersDiagnosticsViewModel.cs b/src/app/ApplicationTemplate.Presentation/ViewModels/Diagnostics/LoggersDiagnosticsViewModel.cs
@@ -83,7 +83,12 @@ await this.GetService<IMessageDialogService>().ShowMessage(ct, mb => mb
 
 	private async Task OnConsoleLoggingChanged(CancellationToken ct, bool isEnabled)
 	{
-		this.GetService<ILogger<LoggersDiagnosticsViewModel>>().LogInformation("{IsEnabled} console logging.", isEnabled ? "Enabling" : "Disabling");
+		var logger = this.GetService<ILogger<LoggersDiagnosticsViewModel>>();
+
+		if (logger.IsEnabled(LogLevel.Information))
+		{
+			logger.LogInformation("{IsEnabled} console logging.", isEnabled ? "Enabling" : "Disabling");
+		}
 
 		await this.GetService<IMessageDialogService>().ShowMessage(ct, mb => mb
 			.Title("Diagnostics")
@@ -94,7 +99,12 @@ await this.GetService<IMessageDialogService>().ShowMessage(ct, mb => mb
 
 	private async Task OnFileLoggingChanged(CancellationToken ct, bool isEnabled)
 	{
-		this.GetService<ILogger<LoggersDiagnosticsViewModel>>().LogInformation("{IsEnabled} file logging.", isEnabled ? "Enabling" : "Disabling");
+		var logger = this.GetService<ILogger<LoggersDiagnosticsViewModel>>();
+
+		if (logger.IsEnabled(LogLevel.Information))
+		{
+			logger.LogInformation("{IsEnabled} file logging.", isEnabled ? "Enabling" : "Disabling");
+		}
 
 		await this.GetService<IMessageDialogService>().ShowMessage(ct, mb => mb
 			.Title("Diagnostics")
diff --git a/src/app/ApplicationTemplate.Tests.Functional/ApplicationTemplate.Tests.Functional.csproj b/src/app/ApplicationTemplate.Tests.Functional/ApplicationTemplate.Tests.Functional.csproj
@@ -18,7 +18,7 @@
 		  <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
 		</PackageReference>
 		<PackageReference Include="Serilog.Sinks.XUnit" Version="3.0.19" />
-		<PackageReference Include="FluentAssertions" Version="8.8.0" />
+		<PackageReference Include="FluentAssertions" Version="7.2.0" />
 		<PackageReference Include="xunit" Version="2.9.3" />
 		<PackageReference Include="xunit.runner.visualstudio" Version="3.0.2">
 			<PrivateAssets>all</PrivateAssets>
diff --git a/src/app/ApplicationTemplate.Tests.Unit/ApplicationTemplate.Tests.Unit.csproj b/src/app/ApplicationTemplate.Tests.Unit/ApplicationTemplate.Tests.Unit.csproj
@@ -17,7 +17,7 @@
 		  <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
 		</PackageReference>
 		<PackageReference Include="Serilog.Sinks.XUnit" Version="3.0.19" />
-		<PackageReference Include="FluentAssertions" Version="8.8.0" />
+		<PackageReference Include="FluentAssertions" Version="7.2.0" />
 		<PackageReference Include="xunit" Version="2.9.3" />
 		<PackageReference Include="xunit.runner.visualstudio" Version="3.0.2">
 			<PrivateAssets>all</PrivateAssets>

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,10 @@ public MockedEmailService(ILogger<MockedEmailService> logger)`
`15`	`15`
`16`	`16`	`public Task Compose(CancellationToken ct, Email email)`
`17`	`17`	`{`
`18`		`- _logger.LogInformation("Email composed: {Email}", email);`
	`18`	`+ if (_logger.IsEnabled(LogLevel.Information))`
	`19`	`+ {`
	`20`	`+ _logger.LogInformation("Email composed: {Email}", email);`
	`21`	`+ }`
`19`	`22`	`return Task.CompletedTask;`
`20`	`23`	`}`
`21`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,11 @@ public static void OnUnhandledException(Exception exception, bool isTerminating,`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`var logger = services.GetRequiredService<ILogger<CoreStartup>>();`
`44`		`- logger.LogError(exception, "An unhandled exception occurred. StackTrace: {StackTrace}", exception.StackTrace);`
	`44`	`+`
	`45`	`+ if (logger.IsEnabled(LogLevel.Error))`
	`46`	`+ {`
	`47`	`+ logger.LogError(exception, "An unhandled exception occurred. StackTrace: {StackTrace}", exception.StackTrace);`
	`48`	`+ }`
`45`	`49`	`}`
`46`	`50`
`47`	`51`	`private static async Task HandleCommandException(CancellationToken ct, IDynamicCommand command, Exception exception, IServiceProvider services)`
Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,10 @@ private void SuscribeToKillSwitch(IServiceProvider serviceProvider)`
`229`	`229`	`killSwitchService.ObserveKillSwitchActivation()`
`230`	`230`	`.SelectManyDisposePrevious(async (activated, ct) =>`
`231`	`231`	`{`
`232`		`- Logger.LogTrace("Kill switch activation changed to {Activated}.", activated);`
	`232`	`+ if (Logger.IsEnabled(LogLevel.Trace))`
	`233`	`+ {`
	`234`	`+ Logger.LogTrace("Kill switch activation changed to {Activated}.", activated);`
	`235`	`+ }`
`233`	`236`
`234`	`237`	`if (activated)`
`235`	`238`	`{`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,10 @@ public override async Task<object> Load(CancellationToken ct, IDataLoaderRequest`
`31`	`31`	`}`
`32`	`32`	`catch (Exception error)`
`33`	`33`	`{`
`34`		`- _logger.LogError(error, "Failed to load request '{RequestSequenceId}' in DataLoader '{DataLoaderName}'.", request.SequenceId, request.Context.GetDataLoaderName());`
	`34`	`+ if (_logger.IsEnabled(LogLevel.Error))`
	`35`	`+ {`
	`36`	`+ _logger.LogError(error, "Failed to load request '{RequestSequenceId}' in DataLoader '{DataLoaderName}'.", request.SequenceId, request.Context.GetDataLoaderName());`
	`37`	`+ }`
`35`	`38`
`36`	`39`	`throw;`
`37`	`40`	`}`
Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,10 @@ public async Task Start()`
`152`	`152`
`153`	`153`	`async Task StartViewServicesWithLogs(IServiceProvider services, bool isFirstStart)`
`154`	`154`	`{`
`155`		`- Logger.LogDebug("Starting view services (isFirstStart: {IsFirstStart}).", isFirstStart);`
	`155`	`+ if (Logger.IsEnabled(LogLevel.Debug))`
	`156`	`+ {`
	`157`	`+ Logger.LogDebug("Starting view services (isFirstStart: {IsFirstStart}).", isFirstStart);`
	`158`	`+ }`
`156`	`159`
`157`	`160`	`await StartViewServices(services, isFirstStart);`
`158`	`161`
Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,10 @@ public override void Set(string key, string value)`
`50`	`50`	`}`
`51`	`51`	`}`
`52`	`52`
`53`		`- _logger.LogDebug("Serialized {PairCount} key-value-pairs in {ElapsedMilliseconds}ms.", Data.Count, stopwatch.ElapsedMilliseconds);`
`54`		`-`
	`53`	`+ if (_logger.IsEnabled(LogLevel.Debug))`
	`54`	`+ {`
	`55`	`+ _logger.LogDebug("Serialized {PairCount} key-value-pairs in {ElapsedMilliseconds}ms.", Data.Count, stopwatch.ElapsedMilliseconds);`
	`56`	`+ }`
`55`	`57`	`OnReload();`
`56`	`58`	`}`
`57`	`59`	`}`
Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,12 @@ string GetValueAsString(TValue value)`
`126`	`126`	`{`
`127`	`127`	`if (value is not string && value is not bool)`
`128`	`128`	`{`
`129`		`- viewModel.GetService<ILogger<TOptions>>().LogWarning("Serialization of type {TypeName} may be wrong. Consider using the valueToString parameter from the GetFromOptionsMonitor method.", typeof(TValue).Name);`
	`129`	`+ var logger = viewModel.GetService<ILogger>();`
	`130`	`+`
	`131`	`+ if (logger.IsEnabled(LogLevel.Warning))`
	`132`	`+ {`
	`133`	`+ logger.LogWarning("Serialization of type {TypeName} may be wrong. Consider using the valueToString parameter from the GetFromOptionsMonitor method.", typeof(TValue).Name);`
	`134`	`+ }`
`130`	`135`	`}`
`131`	`136`
`132`	`137`	`return value.ToString();`