WIP

Author: tmillr

lua/plenary/path.lua

@@ -515,30 +515,73 @@ function Path:rmdir()
   uv.fs_rmdir(self:absolute())
 end
 
+---Rename this file or directory to the given target, and return a new Path instance pointing to target. On Unix, if target exists and is a file, it will be replaced silently if the user has permission. On Windows, if target exists, FileExistsError will be raised. target can be either a string or another path object:
+---@generic T: Path
+---@param opts { new_name: Path|string }
+---@return T
 function Path:rename(opts)
+  -- TODO: For reference, Python's `Path.rename()` actually says/does this:
+  --
+  -- > On Unix, if target exists and is a file, it will be replaced silently
+  -- > if the user has permission.
+  -- >
+  -- > On Windows, if target exists, FileExistsError will be raised. target
+  -- > can be either a string or another path object.
+  --
+  -- The behavior here may differ, as an error will be thrown regardless.
+
+  local self_lstat, new_lstat, status, errmsg
   opts = opts or {}
-  if not opts.new_name or opts.new_name == "" then
-    error "Please provide the new name!"
-  end
+  assert(opts.new_name and opts.new_name ~= "", "Please provide the new name!")
+  self_lstat, errmsg = uv.fs_lstat(self.filename)
+
+  -- Cannot rename a non-existing path (lstat is needed here, `Path:exists()`
+  -- uses stat)
+  assert(self_lstat, ("%s: %s"):format(errmsg, self.filename))
 
+  -- BUG
   -- handles `.`, `..`, `./`, and `../`
   if opts.new_name:match "^%.%.?/?\\?.+" then
     opts.new_name = {
       uv.fs_realpath(opts.new_name:sub(1, 3)),
-      opts.new_name:sub(4, #opts.new_name),
+      opts.new_name:sub(4),
     }
   end
 
   local new_path = Path:new(opts.new_name)
-
-  if new_path:exists() then
-    error "File or directory already exists!"
-  end
-
-  local status = uv.fs_rename(self:absolute(), new_path:absolute())
-  self.filename = new_path.filename
-
-  return status
+  new_lstat, errmsg = uv.fs_lstat(new_path.filename)
+
+  -- BUG: exists() uses stat, not lstat. `new_name` could be a bad symlink, and
+  -- then will incorrectly think that it doesn't exist (rename(2) does not
+  -- resolve the final path component if it's a symlink!)
+  -- if new_lstat then
+
+  -- This allows changing only case (e.g. fname -> Fname) on case-insensitive
+  -- file systems, otherwise throwing if `new_name` exists.
+  --
+  -- NOTE: to elaborate, `uv.fs_rename()` wont/shouldn't do anything if old
+  -- and new both exist and are both hard links to the same file (inode),
+  -- however, it appears to still allow you to change the case of a filename
+  -- on case-insensitive file systems (e.g. if `new_name` doesn't _actually_
+  -- exist as a separate file but would otherwise appear to via an lstat call;
+  -- if it does actually exist (in which case the fs must be case-sensitive)
+  -- idk 100% what happens b/c it needs to be tested on a case-sensitive fs,
+  -- but it should then simply be a successful no-op according to rename(2)
+  -- docs, at least on Linux anyway)
+  assert(not new_lstat or (self_lstat.ino == new_lstat.ino), "File or directory already exists!")
+
+  status, errmsg = uv.fs_rename(self:absolute(), new_path:absolute())
+  assert(status, ("%s: Rename failed!"):format(errmsg))
+
+  -- NOTE: `uv.fs_rename()` _can_ return success even if no rename actually
+  -- occurred (see rename(2)), and this is not an error...we're not changing
+  -- `self.filename` if it didn't.
+  if not uv.fs_lstat(self.filename) then
+    self.filename = new_path.filename
+  end
+
+  -- TODO: Python returns a brand new instance here, should we do the same?
+  return self
 end
 
 --- Copy files or folders with defaults akin to GNU's `cp`.