Skip to content

Question: Should I include the window lua files from plenary to fix bugs? #5

@bjdm

Description

@bjdm

I've been troubleshooting some bugs and was going about fixing them so I can make a PR, but I have noticed some of the bugs I've identified actually exist in the underlying implementations in plenary ie. Border.

To work locally, I have copied the files from plenary into popup.nvim and have made the necessary changes to require them and the fixes, but before I open the issues and pull requests, I wanted to ask if I should include the plenary files in the PR (lua/plenary/window/*) or make issues and PRs on plenary. I would usually just make issues on plenary, however, these fixes would likely break other plugins using these in plenary.

edit: I had initially looked into using neovim-ui in place of popup and making the changes there, but as per nvim-lua/neovim-ui#10 I am using popup.nvim

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions