fix(pick): update set_picker_opts to rerun match only if necessary

Related to #2146

Author: echasnovski

lua/mini/pick.lua

@@ -1799,7 +1799,8 @@ MiniPick.set_picker_opts = function(opts)
   picker.opts = vim.tbl_deep_extend('force', picker.opts, opts or {})
   picker.action_keys = H.normalize_mappings(picker.opts.mappings)
   if cur_cwd ~= picker.opts.source.cwd then H.win_set_cwd(picker.windows.main, picker.opts.source.cwd) end
-  H.picker_update(picker, true, true)
+  local do_match = ((opts or {}).source or {}).match ~= nil
+  H.picker_update(picker, do_match, true)
 end
 
 --- Set target window for active picker

tests/screenshots/tests-test_pick.lua---set_picker_opts()---works-003

@@ -12,7 +12,7 @@
 11|~    │                        │         
 12|~    │                        │         
 13|~    │                        │         
-14|~    └ My name ──────── 1|1|3 ┘         
+14|~    └ My other name ── 1|1|3 ┘         
 15|                                        
 
 --|---------|---------|---------|---------|
@@ -29,5 +29,5 @@
 11|1111126666666666666666666666662111111111
 12|1111126666666666666666666666662111111111
 13|1111126666666666666666666666662111111111
-14|1111127777777772222222277777772111111111
+14|1111127777777777777772277777772111111111
 15|0000000000000000000000000000000000000000

tests/test_pick.lua

@@ -4549,7 +4549,12 @@ T['set_picker_opts()']['works'] = function()
   eq(child.fn.getcwd(0), full_path(test_dir))
   eq(child.fn.getcwd(target_win_id), init_cwd)
 
-  -- Should rerun match
+  -- Should rerun match, but only if necessary
+  type_keys('<C-n>')
+  eq(get_picker_matches().current_ind, 2)
+  child.lua([[MiniPick.set_picker_opts({ source = { name = 'My other name' } })]])
+  eq(get_picker_matches().current_ind, 2)
+
   child.lua('MiniPick.set_picker_opts({ source = { match = function() return { 2 } end } })')
   eq(get_picker_matches().all_inds, { 2 })
   child.expect_screenshot()