Commit dd721b6
committed
test: set 'termguicolors' for every child process
Details:
- This seems to make testing more robust. Not in the last because
'mini.hues' defines only `gui{fg,bg,sp}` highlight attributes.
- The driver for this change was PR number 35026 on neovim/neovim.
It adjusted how highlight groups linked to `Normal` are not displayed
over `CursorLine`. This is a good change, but introduced an issue with
`child.fn.screenattr()` output.
It seems to started to ignore not only `linked to Normal` groups,
but at least some others (like `linked to NormalFloat`, which has
different background than `Normal`).
The visible side effect here was that current line in 'mini.files'
explorer (which has cursorline enabled) was shown with a single
highlight from start to finish where two (from `content.highlight` and
`CursorLine`) was expected. Two expected groups have visibly different
background when tried to reproduce interactively.
What seems to be the culprit is that Neovim's C code in this case now
acts differently based on the output of `ui_rgb_attached()`.
Child processes do not have an attached UI that explicitly says that
it supports `rgb`. Nor there is an explicit 'termguicolors'.
Explicitly enabling 'termguicolors' fixes the 'mini.files' test.1 parent 0abb662 commit dd721b6
2 files changed
+9
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
148 | 148 | | |
149 | 149 | | |
150 | 150 | | |
151 | | - | |
152 | | - | |
153 | 151 | | |
154 | 152 | | |
155 | 153 | | |
| |||
160 | 158 | | |
161 | 159 | | |
162 | 160 | | |
163 | | - | |
164 | 161 | | |
165 | 162 | | |
166 | 163 | | |
| |||
0 commit comments