Fix agenda todo only tags view. Closes #349

Author: kristijanhusak

lua/orgmode/agenda/views/tags.lua

@@ -32,20 +32,15 @@ function AgendaTagsView:new(opts)
   return data
 end
 
-function AgendaTagsView:build(opts)
-  opts = opts or {}
-  local tags = opts.tags
-
-  if not tags then
-    tags = vim.fn.OrgmodeInput('Match: ', self.search, Files.autocomplete_tags)
-  end
+function AgendaTagsView:build()
+  local tags = vim.fn.OrgmodeInput('Match: ', self.search, Files.autocomplete_tags)
   if vim.trim(tags) == '' then
     return utils.echo_warning('Invalid tag.')
   end
   local search = Search:new(tags)
   self.items = {}
   for _, orgfile in ipairs(Files.all()) do
-    local headlines_filtered = orgfile:apply_search(search, opts.todo_only)
+    local headlines_filtered = orgfile:apply_search(search, self.todo_only)
     for _, headline in ipairs(headlines_filtered) do
       if self.filters:matches(headline) then
         table.insert(self.items, headline)

tests/plenary/colors/colors_spec.lua

@@ -15,19 +15,19 @@ describe('Colors', function()
   it('should get appropriate fg color from hl group', function()
     vim.cmd([[hi OrgTestParse guifg=#FF0000]])
     local parsed_color = colors.parse_hl_fg_color('OrgTestParse')
-    assert.are.same('#FF0000', parsed_color)
+    assert.are.same('#FF0000', parsed_color:upper())
 
     vim.cmd([[hi OrgTestParse guibg=#FF8888]])
     parsed_color = colors.parse_hl_fg_color('OrgTestParse')
-    assert.are.same('#FF8888', parsed_color)
+    assert.are.same('#FF8888', parsed_color:upper())
 
     vim.cmd([[hi OrgTestParse guifg=#FFFFFF guibg=#00FF00]])
     parsed_color = colors.parse_hl_fg_color('OrgTestParse')
-    assert.are.same('#00FF00', parsed_color)
+    assert.are.same('#00FF00', parsed_color:upper())
 
     vim.cmd([[hi OrgTestParse guifg=#FFFFFF guibg=#00FF00 gui=reverse]])
     parsed_color = colors.parse_hl_fg_color('OrgTestParse')
-    assert.are.same('#FFFFFF', parsed_color)
+    assert.are.same('#FFFFFF', parsed_color:upper())
 
     vim.cmd([[hi clear OrgTestParse]])
   end)
@@ -52,7 +52,7 @@ describe('Colors', function()
 
   it('should parse todo keyword faces', function()
     local get_color_opt = function(hlgroup, name, type)
-      return vim.fn.synIDattr(vim.fn.synIDtrans(vim.fn.hlID(hlgroup)), name, type)
+      return vim.fn.synIDattr(vim.fn.synIDtrans(vim.fn.hlID(hlgroup)), name, type):lower()
     end
     config:extend({
       org_todo_keyword_faces = {