Folding enabled after picking file

[chrs8]

Description

Whenever a file is opened via telescope, folding is enabled. This occurs after #3595

Neovim version

NVIM v0.11.5
Build type: RelWithDebInfo
LuaJIT 2.1.1765228720

Operating system and version

Arch Linux 6.18.2-arch2-1

Telescope version / branch / rev

v0.2.0-3-g4d0f5e0

checkhealth telescope

telescope:                                                                1 ⚠️

Checking for required plugins ~
- ✅ OK plenary installed.

Checking external dependencies ~
- ✅ OK rg: found ripgrep 15.1.0
- ⚠️ WARNING fd: not found. Install [sharkdp/fd](https://github.com/sharkdp/fd) for extended capabilities

===== Installed extensions ===== ~

Telescope Extension: `fzf` ~
- ✅ OK lib working as expected
- ✅ OK file_sorter correctly configured
- ✅ OK generic_sorter correctly configured

Steps to reproduce

nvim -nu minimal.lua
:Telescope find_files
select file

Expected behavior

no folding in the file

Actual behavior

the file is folded

Minimal config

local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs { "config", "data", "state", "cache" } do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.uv.fs_stat(lazypath) then
  vim.fn.system {
    "git",
    "clone",
    "--filter=blob:none",
    "https://github.com/folke/lazy.nvim.git",
    lazypath,
  }
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  {
    "nvim-telescope/telescope.nvim",
    dependencies = {
      "nvim-lua/plenary.nvim",
    },
    config = function()
      -- ADD INIT.LUA SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
vim.opt.foldmethod = "expr"
vim.opt.foldexpr = "v:lua.vim.treesitter.foldexpr()"
vim.opt.foldenable = false

      require("telescope").setup {}
    end,
  },
}

require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

[clason]

Can you explain why you are setting these globally (which you shouldn't!)?

(And the standard guidance is to set foldlevel=999 instead of foldenable=0 if you want to have folds but open by default.)

[clason]

@alexmozaidze

I want this to be fixed properly, so I'd like you both to test possible fixes to make sure we get something that (finally) works for everyone.

First step is to see if the hack is even still necessary by removing it (locally).

Second step (if it is) is to go back to the old workaround but re-set the window (local) option instead of the global one (which was indeed a mistake).

Third step would be to gate the current workaround behind vim.wo[0][0].foldenable.

EDIT: Testing briefly, it seems that option 2 works. Please test.

[chrs8]

Can you explain why you are setting these globally (which you shouldn't!)?

(And the standard guidance is to set foldlevel=999 instead of foldenable=0 if you want to have folds but open by default.)

I didn't know this was wrong. I usually don't use folding and only occasionally trigger it with zi. Setting foldlevel=999 doesn't work, because when I enable folding I'd like everything to be folded.
What’s a better way to achieve this?

[clason]

zM to close all folds.

[alexmozaidze]

After some playing around, I realized that zX, like other fold operations, toggles foldenable on. My first instinct was to add additional check to determine if the folds are enabled, but I'll check #3602 first. It seems to be a pretty good fix, but I'll play around with it a bit to see if it has any edge cases.

[chrs8]

zM to close all folds.

At first glance this seems to work. However, it's convenient to use zi to toggle between the folded state (with only necessary folds open) and the fully expanded state. I'll take a closer look.