Revert "fix: timer is shared with multiple buffers ..."

This reverts commit 5548a0a.

Author: glepnir

lua/guard/events.lua

@@ -1,5 +1,4 @@
 local api, uv = vim.api, vim.uv
-local async = require('guard._async')
 local util = require('guard.util')
 local getopt = util.getopt
 local report_error = util.report_error
@@ -11,31 +10,22 @@ M.group = api.nvim_create_augroup('Guard', { clear = true })
 M.user_fmt_autocmds = {}
 M.user_lint_autocmds = {}
 
--- Fix: per-buffer debounce timers
-local debounce_timers = {}
-
+local debounce_timer = nil
 local function debounced_lint(opt)
-  local buf = opt.buf
-
-  if debounce_timers[buf] then
-    debounce_timers[buf]:stop()
-    debounce_timers[buf]:close()
-    debounce_timers[buf] = nil
+  if debounce_timer then
+    debounce_timer:stop()
+    debounce_timer = nil
   end
-
-  debounce_timers[buf] = assert(uv.new_timer())
+  ---@diagnostic disable-next-line: undefined-field
+  debounce_timer = assert(uv.new_timer()) --[[uv_timer_t]]
+  ---@type integer
   local interval = assert(tonumber(util.getopt('lint_interval')))
-
-  debounce_timers[buf]:start(interval, 0, function()
-    if debounce_timers[buf] then
-      debounce_timers[buf]:stop()
-      debounce_timers[buf]:close()
-      debounce_timers[buf] = nil
-    end
+  debounce_timer:start(interval, 0, function()
+    debounce_timer:stop()
+    debounce_timer:close()
+    debounce_timer = nil
     vim.schedule(function()
-      if api.nvim_buf_is_valid(buf) then
-        require('guard.lint').do_lint(buf)
-      end
+      require('guard.lint').do_lint(opt.buf)
     end)
   end)
 end
@@ -84,16 +74,11 @@ function M.get_lint_autocmds(bufnr)
   if not api.nvim_buf_is_valid(bufnr) then
     return {}
   end
-
-  -- Get buffer-specific autocmds
   local aus = api.nvim_get_autocmds({
     group = M.group,
     event = { 'BufWritePost', 'BufEnter', 'TextChanged', 'InsertLeave' },
     buffer = bufnr,
   })
-
-  -- Note: User GuardFmt autocmds are global, we include them for compatibility
-  -- but they should be filtered by buffer in their callbacks
   return vim.list_extend(
     aus,
     api.nvim_get_autocmds({
@@ -106,8 +91,14 @@ end
 
 ---@param buf number
 ---@return boolean
+--- We don't check ignore patterns here because users might expect
+--- other formatters in the same group to run even if another
+--- might ignore this file
 function M.check_fmt_should_attach(buf)
-  return #M.get_format_autocmds(buf) == 0 and vim.bo[buf].buftype ~= 'nofile'
+  -- check if it's not attached already
+  return #M.get_format_autocmds(buf) == 0
+    --  and has an underlying file
+    and vim.bo[buf].buftype ~= 'nofile'
 end
 
 ---@param buf number
@@ -120,13 +111,13 @@ function M.check_lint_should_attach(buf, ft)
 
   local aus = M.get_lint_autocmds(buf)
 
-  -- For '*' filetype, check if there's already a '*' pattern autocmd
-  -- For specific filetype, check if there's already a non-'*' pattern autocmd
-  local has_conflicting = iter(aus):any(function(au)
-    return ft == '*' and au.pattern == '*' or au.pattern ~= '*'
-  end)
-
-  return not has_conflicting
+  return #iter(aus)
+    :filter(ft == '*' and function(it)
+      return it.pattern == '*'
+    end or function(it)
+      return it.pattern ~= '*' and it.pattern ~= 'GuardFmt'
+    end)
+    :totable() == 0
 end
 
 ---@param buf number
@@ -141,10 +132,6 @@ function M.try_attach_fmt_to_buf(buf)
   })
 end
 
--- Track which buffers want User GuardFmt autocmd for lint
-local lint_on_fmt_buffers = {}
-local user_guardfmt_autocmd_id = nil
-
 ---@param buf number
 ---@param events string[]
 ---@param ft string
@@ -155,21 +142,15 @@ function M.try_attach_lint_to_buf(buf, events, ft)
 
   for _, ev in ipairs(events) do
     if ev == 'User GuardFmt' then
-      -- Register this buffer for lint-on-format
-      lint_on_fmt_buffers[buf] = true
-
-      -- Create global User GuardFmt autocmd only once
-      if not user_guardfmt_autocmd_id then
-        user_guardfmt_autocmd_id = au('User', {
-          group = M.group,
-          pattern = 'GuardFmt',
-          callback = function(opt)
-            if lint_on_fmt_buffers[opt.buf] and opt.data.status == 'done' then
-              lazy_debounced_lint(opt)
-            end
-          end,
-        })
-      end
+      au('User', {
+        group = M.group,
+        pattern = 'GuardFmt',
+        callback = function(opt)
+          if opt.buf == buf and opt.data.status == 'done' then
+            lazy_debounced_lint(opt)
+          end
+        end,
+      })
     else
       au(ev, {
         group = M.group,
@@ -201,11 +182,13 @@ end
 ---@param ft string
 ---@param formatters FmtConfig[]
 function M.fmt_on_filetype(ft, formatters)
-  -- Check executability and report errors
-  iter(formatters):each(function(config)
+  -- check if all cmds executable before registering formatter
+  iter(formatters):any(function(config)
     if type(config) == 'table' and config.cmd and vim.fn.executable(config.cmd) ~= 1 then
       report_error(config.cmd .. ' not executable')
+      return false
     end
+    return true
   end)
 
   au('FileType', {
@@ -261,11 +244,11 @@ end
 ---@param ft string
 ---@param events string[]
 function M.lint_on_filetype(ft, events)
-  -- Check executability and report errors
-  iter(require('guard.filetype')[ft].linter):each(function(config)
+  iter(require('guard.filetype')[ft].linter):any(function(config)
     if config.cmd and vim.fn.executable(config.cmd) ~= 1 then
       report_error(config.cmd .. ' not executable')
     end
+    return true
   end)
 
   au('FileType', {
@@ -281,6 +264,7 @@ end
 ---@param ft string
 function M.fmt_attach_custom(ft, events)
   M.user_fmt_autocmds[ft] = {}
+  -- we don't know what autocmds are passed in, so these are attached asap
   iter(events):each(function(event)
     table.insert(
       M.user_fmt_autocmds[ft],
@@ -298,15 +282,16 @@ end
 ---@param ft string
 function M.lint_attach_custom(ft, config)
   M.user_lint_autocmds[ft] = {}
+  -- we don't know what autocmds are passed in, so these are attached asap
   iter(config.events):each(function(event)
     table.insert(
       M.user_lint_autocmds[ft],
       api.nvim_create_autocmd(
         event.name,
         maybe_fill_auoption(event.opt or {}, function(opt)
-          async.run(function()
+          coroutine.resume(coroutine.create(function()
             require('guard.lint').do_lint_single(opt.buf, config)
-          end)
+          end))
         end)
       )
     )