Skip to content

Commit 6bcadb6

Browse files
committed
ioctl: introduce SHIFT MASK enum for nvme_zns_append
Replace hardcoded MASK and SHIFT values with enum entries for nvme_zns_append. Signed-off-by: Dennis Maisenbacher <[email protected]>
1 parent 1b6eaec commit 6bcadb6

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

src/nvme/ioctl.h

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5433,10 +5433,12 @@ static inline int nvme_zns_append(nvme_link_t l, __u32 nsid, __u64 zslba, __u16
54335433
void *metadata, __u32 metadata_len,
54345434
void *data, __u32 data_len, __u64 *result)
54355435
{
5436-
__u32 cdw10 = zslba & 0xffffffff;
5437-
__u32 cdw11 = zslba >> 32;
5438-
__u32 cdw12 = nlb | (control << 16);
5439-
__u32 cdw15 = lbat | (lbatm << 16);
5436+
__u32 cdw10 = NVME_SET(zslba, IOCS_COMMON_CDW10_SLBAL);
5437+
__u32 cdw11 = NVME_SET(zslba >> 32, IOCS_COMMON_CDW11_SLBAU);
5438+
__u32 cdw12 = NVME_SET(nlb, IOCS_COMMON_CDW12_NLB) |
5439+
NVME_SET(control, IOCS_COMMON_CDW12_CONTROL);
5440+
__u32 cdw15 = NVME_SET(lbat, IOCS_COMMON_CDW15_ELBAT) |
5441+
NVME_SET(lbatm, IOCS_COMMON_CDW15_ELBATM);
54405442

54415443
struct nvme_passthru_cmd64 cmd = {
54425444
.opcode = nvme_zns_cmd_append,

0 commit comments

Comments
 (0)