-
Notifications
You must be signed in to change notification settings - Fork 50
Description
First, thanks so much for this library. Incredibly helpful aid in integrating Vulkan Video.
I was getting some validation errors in my app when integrating this into it. I initially though I was doing something wrong, but then I noticed that even if I force a validation error in the vk-video-dec-test example, I don't see any validation errors printed (such as making the image width 10000000).
I then noticed that this project is using the deprecated VK_EXT_debug_report extension.
I changed the code to use VK_EXT_debug_utils instead, and now I get the same validation errors. For example the very first one that occurs is:
vkCreateImageView(): pCreateInfo->image was created with VK_IMAGE_USAGE_SAMPLED_BIT, but create_info.format VK_FORMAT_G8_B8R8_2PLANE_420_UNORM requires a VkSamplerYcbcrConversion but one was not passed in the pNext chain.
VkImageViewCreateInfo::pNext is NULL.
The Vulkan spec states: If the image view requires a sampler Y'CBCR conversion and usage contains VK_IMAGE_USAGE_SAMPLED_BIT, then the pNext chain must include a VkSamplerYcbcrConversionInfo structure with a conversion value other than VK_NULL_HANDLE (https://vulkan.lunarg.com/doc/view/1.4.321.1/windows/antora/spec/latest/chapters/resources.html#VUID-VkImageViewCreateInfo-format-06415)
I can make a pull request that upgrades the validation to use the newer extension. However there is a lot of validation errors that start to get printed then, so it seems like those would have to get fixed at the same time. Any thoughts?