Skip to content

Commit 54f148c

Browse files
committed
Remove logging that was causing export errors
1 parent a0c0de1 commit 54f148c

File tree

4 files changed

+9
-12
lines changed

4 files changed

+9
-12
lines changed

command_line.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
import subprocess
3636
import plistlib
3737
import codecs
38+
import logging
3839
from datetime import datetime, timedelta
3940

4041
from io import StringIO
@@ -72,7 +73,7 @@ def __init__(self, quiet=False):
7273
self.file_tree = FileTree()
7374

7475
def init(self):
75-
self.logger = config.logger
76+
self.logger = logging.getLogger(__name__)
7677
self.update_nw_versions(None)
7778
self.setup_nw_versions()
7879

config.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ def is_installed():
9090

9191
## Logger setup ----------------------------------------------
9292

93-
logger = logging.getLogger('W2E logger')
9493
LOG_FILENAME = utils.get_data_file_path(ERROR_LOG_FILE)
9594
if __name__ != '__main__':
9695
logging.basicConfig(
@@ -99,10 +98,6 @@ def is_installed():
9998
"%(lineno)s %(funcName)s - %(message)s"),
10099
level=logging.DEBUG
101100
)
102-
logger = logging.getLogger('W2E logger')
103-
104-
handler = lh.RotatingFileHandler(LOG_FILENAME, maxBytes=100000, backupCount=2)
105-
logger.addHandler(handler)
106101

107102
## Custom except hook to log all errors ----------------------
108103

main.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,14 @@
2424
import os
2525
import glob
2626
import sys
27-
import codecs
27+
import logging
2828
import platform
2929

3030
import utils
3131
from utils import log, open_folder_in_explorer
3232

3333
import config
34-
from config import logger, get_file
34+
from config import get_file
3535
from config import __version__ as __gui_version__
3636

3737
from util_classes import ExistingProjectDialog
@@ -144,7 +144,7 @@ def __init__(self, width, height, app, parent=None):
144144

145145
self.setup_project_menu()
146146

147-
self.logger = logger
147+
self.logger = logging.getLogger(__name__)
148148

149149
self.gui_app = app
150150
self.desktop_width = app.desktop().screenGeometry().width()

utils.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,12 @@
1616
from appdirs import AppDirs
1717
import validators
1818
import traceback
19+
import logging
1920

2021
from PySide import QtCore
2122

23+
logger = logging.getLogger(__name__)
24+
2225
def url_exists(path):
2326
if validators.url(path):
2427
return True
@@ -194,9 +197,7 @@ def log(*args):
194197
"""Print logging information or log it to a file."""
195198
if config.DEBUG:
196199
print(*args)
197-
with open(get_data_file_path(config.ERROR_LOG_FILE), 'a+') as f:
198-
f.write(', '.join(args))
199-
f.write('\n')
200+
logger.info(', '.join(args))
200201

201202
def open_folder_in_explorer(path):
202203
"""Cross platform open folder window."""

0 commit comments

Comments
 (0)