Skip to content

Commit 5bfd192

Browse files
committed
Fix #129: node-remote setting is replaced with node_remote
1 parent 47b19b8 commit 5bfd192

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

command_line.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -458,11 +458,17 @@ def generate_json(self, global_json=False):
458458
major_ver = versions[0]
459459
minor_ver = versions[1]
460460

461+
nwjs_13_renames = ['always-on-top',
462+
'visible-on-all-workspaces',
463+
'new-instance',
464+
'inject-js-start',
465+
'inject-js-end']
466+
461467
if not global_json:
462468
dic.update({'webkit': {}, 'window': {}})
463469
dic.update(self.original_packagejson)
464470
for setting_name, setting in self.settings['app_settings'].items():
465-
if major_ver > 0 or minor_ver >= 13:
471+
if (major_ver > 0 or minor_ver >= 13) and setting_name in nwjs_13_renames:
466472
dic.pop(setting_name, '')
467473
setting_name = setting_name.replace('-', '_')
468474

@@ -474,7 +480,7 @@ def generate_json(self, global_json=False):
474480
dic.pop(setting_name, '')
475481

476482
for setting_name, setting in self.settings['window_settings'].items():
477-
if major_ver > 0 or minor_ver >= 13:
483+
if major_ver > 0 or minor_ver >= 13 and setting_name in nwjs_13_renames:
478484
dic['window'].pop(setting_name, '')
479485
setting_name = setting_name.replace('-', '_')
480486
if setting.value is not None and setting.value != '':
@@ -489,9 +495,6 @@ def generate_json(self, global_json=False):
489495
dic['window'].pop(setting_name, '')
490496

491497
for setting_name, setting in self.settings['webkit_settings'].items():
492-
if major_ver > 0 or minor_ver >= 13:
493-
dic['webkit'].pop(setting_name, '')
494-
setting_name = setting_name.replace('-', '_')
495498
if setting.value is not None and setting.value != '':
496499
dic['webkit'][setting_name] = setting.value
497500
else:

0 commit comments

Comments
 (0)