Skip to content

Commit 6282f27

Browse files
fix(utils): do not append Version before CFBundleShortVersionString (#576)
* fix(utils): do not append `Version` before `CFBundleShortVersionString` * fix(tests): remove `Version` from tests * chore(docs): update changelog
1 parent f8696ae commit 6282f27

File tree

4 files changed

+7
-3
lines changed

4 files changed

+7
-3
lines changed

.github/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
77

88
## [Unreleased]
99

10+
## Removed
11+
12+
- Remove `Version` from `CFBundleShortVersionString` [#576](https://github.com/nwjs-community/nw-builder/pull/576)
13+
1014
## [3.7.2] - 2022-06-02
1115

1216
## Added

lib/utils.cjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ module.exports = {
202202
}
203203
if (parsedParams.version) {
204204
obj.CFBundleVersion = parsedParams.version;
205-
obj.CFBundleShortVersionString = "Version " + parsedParams.version;
205+
obj.CFBundleShortVersionString = parsedParams.version;
206206
}
207207
if (parsedParams.copyright) {
208208
obj.NSHumanReadableCopyright = parsedParams.copyright;

test/expected/osx-plist/1.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<key>CFBundlePackageType</key>
2222
<string>APPL</string>
2323
<key>CFBundleShortVersionString</key>
24-
<string>Version 1.3.3.7</string>
24+
<string>1.3.3.7</string>
2525
<key>CFBundleVersion</key>
2626
<string>1.3.3.7</string>
2727
<key>LSFileQuarantineEnabled</key>

test/expected/osx-plist/2.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<key>CFBundlePackageType</key>
2222
<string>APPL</string>
2323
<key>CFBundleShortVersionString</key>
24-
<string>Version 1.3.3.7</string>
24+
<string>1.3.3.7</string>
2525
<key>CFBundleVersion</key>
2626
<string>1.3.3.7</string>
2727
<key>LSFileQuarantineEnabled</key>

0 commit comments

Comments
 (0)