Skip to content

Commit b06f052

Browse files
chore(node:test): migrate to vitest (#1014)
### Description of Changes - Migrate to Vitest - Add Node 14 to testing matrix Notes: Tests fail since downloads take reallt long but setting timeout to infinity does not work. This is likely due to a race condition somewhere in the codebase where a promise is not resolving.
1 parent 0119cb8 commit b06f052

File tree

12 files changed

+1396
-128
lines changed

12 files changed

+1396
-128
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1-
Fixes: #
1+
### Description of Changes
22

3-
## Description
3+
- ...
4+
5+
<!-- Notes: additional context on why this PR is being merged when it doesn't seem like it should -->
6+
7+
<!-- Fixes: # -->
8+
<!-- Closes: # -->
9+
<!-- Refs: # -->

.github/workflows/e2e.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
strategy:
1414
matrix:
1515
os: [macos-13, ubuntu-22.04, windows-2022]
16-
node: [16, 18, 20, 21]
16+
node: [14, 16, 18, 20, 21]
1717
fail-fast: false
1818
runs-on: ${{ matrix.os }}
1919
steps:

README.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,6 @@ Options
202202
| logLevel | `"error" \| "warn" \| "info" \| "debug"` | `"info"`| Specify level of logging. |
203203
| zip | `boolean \| "zip" \| "tar" \| "tgz"` | `false`| If true, "zip", "tar" or "tgz" the `outDir` directory is compressed. |
204204

205-
206205
## Guides
207206

208207
### Get unofficial MacOS builds
@@ -274,8 +273,8 @@ nwbuild({
274273

275274
### Bugs
276275

277-
- https://github.com/nwutils/nw-builder/issues/1000
278-
- https://github.com/nwutils/nw-builder/issues/1002
276+
- <https://github.com/nwutils/nw-builder/issues/1000>
277+
- <https://github.com/nwutils/nw-builder/issues/1002>
279278
- Add back error, info and debug logs
280279

281280
### Features
@@ -294,7 +293,6 @@ nwbuild({
294293
- chore(cicd): use `google-github-actions/release-please-action` to automate publishing to npm, updating changelog and creating releases
295294
- chore(test): add test cases for current features
296295
- chore(yargs): migrate to `commander`
297-
- chore(node:test): migrate to `vitest`
298296
- chore(unzipper): migrate to `yauzl-promise`
299297
- chore(util): factor out nw file paths finder
300298
- chore(get): factor out https downloader

0 commit comments

Comments
 (0)