fix(compiler): remove buggy compileSimpleExpression, add test coverage check

Author: solkimicreb

.gitignore

@@ -35,3 +35,6 @@ jspm_packages
 
 # Optional REPL history
 .node_repl_history
+
+# reify cache for allowing import export in node
+.reify-cache

package.json

@@ -6,7 +6,7 @@
   "module": "src/index.js",
   "scripts": {
     "build": "rollup src/index.js -f cjs -o dist/compiler.js",
-    "test": "npm run build && mocha test",
+    "test": "nyc --reporter=lcov --reporter=text mocha test",
     "lint": "standard src/* test/*"
   },
   "author": {
@@ -34,7 +34,9 @@
   "devDependencies": {
     "chai": "3.5.0",
     "mocha": "2.5.3",
+    "nyc": "^10.3.2",
     "pre-push": "0.1.1",
+    "reify": "^0.11.0",
     "rollup": "^0.41.6",
     "standard": "7.1.2"
   },
@@ -48,6 +50,7 @@
   },
   "pre-push": [
     "lint",
-    "test"
+    "test",
+    "build"
   ]
 }

src/context.js

@@ -9,6 +9,7 @@ else if (typeof global !== 'undefined') globalObj = global // eslint-disable-lin
 else if (typeof self !== 'undefined') globalObj = self // eslint-disable-line
 globalObj.$nxCompileToSandbox = toSandbox
 globalObj.$nxClearSandbox = clearSandbox
+globalObj.$nxGlobals = globals
 
 export function expose (...globalNames) {
   for (let globalName of globalNames) {

src/rawCompiler.js

@@ -1,22 +1,4 @@
-const isSimple = /^(\w|\.)+$/
-
 export function compileRawExpression (src) {
-  return isSimple.test(src) ? compileSimpleExpression(src) : compileComplexExpression(src)
-}
-
-function compileSimpleExpression (src) {
-  return new Function('context', 'tempVars', // eslint-disable-line
-    `if (tempVars) {
-      try { return tempVars.${src} } catch (err) {
-        if (!(err instanceof TypeError)) throw err
-      }
-    }
-    try { return context.${src} } catch (err) {
-      if (!(err instanceof TypeError)) throw err
-    }`)
-}
-
-function compileComplexExpression (src) {
   return new Function('context', 'tempVars', // eslint-disable-line
     `const sandbox = $nxCompileToSandbox(context, tempVars)
     try { with (sandbox) { return ${src} } } catch (err) {

test/compiler.js

@@ -1,7 +1,9 @@
 'use strict'
 
+require('reify')
+
 const expect = require('chai').expect
-const compiler = require('../dist/compiler')
+const compiler = require('../src/index')
 
 const localProp = 'localProp'
 global.globalProp = 'globalProp'

test/context.js

@@ -1,7 +1,9 @@
 'use strict'
 
+require('reify')
+
 const expect = require('chai').expect
-const compiler = require('../dist/compiler')
+const compiler = require('../src/index')
 
 describe('context', () => {
   afterEach(() => compiler.hideAll())

test/modifiers.js

@@ -1,7 +1,9 @@
 'use strict'
 
+require('reify')
+
 const expect = require('chai').expect
-const compiler = require('../dist/compiler')
+const compiler = require('../src/index')
 
 describe('context', () => {
   afterEach(() => compiler.hideAll())