Feature/header fields #168
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/header fields
| @@ -61,7 +61,7 @@ - (NSString *)nxoauth2_URLEncodedString; | |||
| return (__bridge_transfer NSString *) CFURLCreateStringByAddingPercentEscapes(kCFAllocatorDefault, //Allocator | |||
| (__bridge CFStringRef)self, //Original String | |||
| NULL, //Characters to leave unescaped | |||
| CFSTR("!*'();:@&=+$,/?%#[]"), //Legal Characters to be escaped | |||
| NULL, | |||
There was a problem hiding this comment.
Can you explain this change? These characters need to be escaped here for URL encoding to be RFC compliant.
There was a problem hiding this comment.
I was making this request based on the previous one, re-added Code!
|
I think you merged an old develop into this, still cannot be cleanly applied. |
…nto feature/header_fields # Conflicts: # Sources/OAuth2Client/NXOAuth2Connection.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made some edits based on comments left below