Skip to content

Commit 4233ec4

Browse files
User filed and query
1 parent f823d8b commit 4233ec4

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

nxtbn/users/admin_mutation.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,9 @@ def mutate(self, info, user_id, permission_codename):
132132

133133
if user.is_superuser or user.is_store_admin:
134134
raise GraphQLError("Superusers and store administrators have all permissions by default and their permissions cannot be modified.")
135+
136+
if not user.is_active or not user.is_staff:
137+
raise GraphQLError("User is not an active staff member.")
135138

136139
try:
137140
permission = Permission.objects.get(codename=permission_codename)

nxtbn/users/api/dashboard/serializers.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -119,12 +119,7 @@ class Meta:
119119
'password',
120120
'role'
121121
]
122-
extra_kwargs = {
123-
'is_staff': {'read_only': True},
124-
'is_superuser': {'read_only': True},
125-
'username': {'read_only': True}
126-
127-
}
122+
read_only_fields = ['id', 'is_superuser', 'is_staff', 'is_active', 'role', 'username']
128123

129124
def create(self, validated_data):
130125
password = validated_data.pop('password', None)

nxtbn/users/api/dashboard/views.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,9 @@ def get_serializer_class(self):
258258
return UserMututionalSerializer
259259

260260
def get_queryset(self):
261-
return User.objects.exclude(role=UserRole.CUSTOMER)
261+
return User.objects.filter(
262+
is_staff=True,
263+
)
262264

263265
@action(detail=True, methods=['put'])
264266
def deactivate(self, request, pk=None):

0 commit comments

Comments
 (0)