Skip to content

Commit cb3acda

Browse files
Not Required added in reservation
1 parent 93c0c31 commit cb3acda

File tree

4 files changed

+36
-7
lines changed

4 files changed

+36
-7
lines changed

nxtbn/order/__init__.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -147,13 +147,14 @@ class OrderStockReservationStatus(models.TextChoices):
147147
OrderReservationStatus is an enumeration of possible statuses for an order reservation.
148148
149149
Attributes:
150-
RESERVED: The stock has been reserved for the order.
151-
RELEASED: The stock reservation has been released.
152-
INSUFFICIENT_STOCK: The stock is insufficient to fulfill the order.
153-
NOT_RESERVED: The stock has not been reserved for the order.
150+
RESERVED: Stock has been reserved for the order.
151+
RELEASED: Stock reservation has been released.
152+
FAILED: Stock reservation has failed due to insufficient stock.
153+
NOT_REQUIRED: Stock reservation is not required.
154+
DISPATCHED: Stock has been dispatched for the order.
154155
"""
155156
RESERVED = 'RESERVED', _('Reserved')
156157
RELEASED = 'RELEASED', _('Released') # Re-adjust stock after order is cancelled
157158
FAILED = 'FAILED', _('Failed') # If failed, that is mean stock is insufficient to fulfill the order, have to fixed it before proceed
158-
NOT_RESERVED = 'NOT_RESERVED', _('Not Reserved') # DO NOTHING IF NOT RESERVED, NO NEED VALIDATION
159+
NOT_REQUIRED = 'NOT_REQUIRED', _('Not Required') # DO NOTHING IF NOT REQUIRED, NO NEED VALIDATION
159160
DISPATCHED = 'DISPATCHED', _('Dispatched')
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
# Generated by Django 4.2.11 on 2025-02-21 09:22
2+
3+
from django.db import migrations, models
4+
5+
6+
class Migration(migrations.Migration):
7+
8+
dependencies = [
9+
("order", "0039_alter_order_options"),
10+
]
11+
12+
operations = [
13+
migrations.AlterField(
14+
model_name="order",
15+
name="reservation_status",
16+
field=models.CharField(
17+
choices=[
18+
("RESERVED", "Reserved"),
19+
("RELEASED", "Released"),
20+
("FAILED", "Failed"),
21+
("NOT_REQUIRED", "Not Required"),
22+
("DISPATCHED", "Dispatched"),
23+
],
24+
default="NOT_REQUIRED",
25+
max_length=20,
26+
),
27+
),
28+
]

nxtbn/order/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ class Order(MonetaryMixin, AbstractBaseUUIDModel):
241241
help_text="Preferred payment method for this order. The actual payment method may differ when the order is initiated or paid."
242242
)
243243
reservation_status = models.CharField(
244-
default=OrderStockReservationStatus.NOT_RESERVED,
244+
default=OrderStockReservationStatus.NOT_REQUIRED,
245245
max_length=20,
246246
choices=OrderStockReservationStatus.choices
247247
)

nxtbn/warehouse/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ def release_stock(order):
106106
return order
107107

108108
def deduct_reservation_on_packed_for_dispatch(order):
109-
if order.reservation_status == OrderStockReservationStatus.NOT_RESERVED: # As not reservable, nothing to do
109+
if order.reservation_status == OrderStockReservationStatus.NOT_REQUIRED: # As not reservable, nothing to do
110110
return None
111111

112112
if order.reservation_status == OrderStockReservationStatus.FAILED:

0 commit comments

Comments
 (0)