fix: added note for upgrade proxyRes error handling

ronag · ronag · commit 3982bb67bfdf · 2017-09-12T11:48:38.000+02:00
diff --git a/index.js b/index.js
@@ -238,6 +238,8 @@ function proxy (req, resOrSocket, options, onRes, onError) {
             .join('\r\n') + '\r\n\r\n'
         )
 
+        // XXX Do we need to handle `proxyRes.on('error', ...)`?
+
         proxySocket
           .on('error', callback)
           .pipe(resOrSocket)

Original file line number	Diff line number	Diff line change
`@@ -238,6 +238,8 @@ function proxy (req, resOrSocket, options, onRes, onError) {`
`238`	`238`	`.join('\r\n') + '\r\n\r\n'`
`239`	`239`	`)`
`240`	`240`
	`241`	+ // XXX Do we need to handle `proxyRes.on('error', ...)`?
	`242`	`+`
`241`	`243`	`proxySocket`
`242`	`244`	`.on('error', callback)`
`243`	`245`	`.pipe(resOrSocket)`