Skip to content

Commit 7be1c2a

Browse files
committed
style: added XXX notes & links
1 parent fd08e00 commit 7be1c2a

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

index.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ function impl (req, resOrSocket, headOrNil, {
4545
onReq,
4646
onRes
4747
}, onProxyError) {
48-
// NOTE http2.Http2ServerRequest doesn't forward stream errors.
48+
// XXX http2.Http2ServerRequest doesn't forward stream errors.
49+
// (https://github.com/nodejs/node/issues/15359)
4950
(req.stream || req).on('error', onError)
5051
resOrSocket.on('error', onError)
5152

@@ -168,9 +169,10 @@ function proxy (req, resOrSocket, options, onRes, onError) {
168169
callback(err)
169170
}
170171
})
171-
// NOTE http.ClientRequest doesn't emit 'aborted'. Instead it emits
172+
// XXX http.ClientRequest doesn't emit 'aborted'. Instead it emits
172173
// a "socket hang up" error.
173174
// .on('aborted', () => callback(new createError.BadGateway('socket hang up')))
175+
// (https://github.com/nodejs/node/pull/15270)
174176
.on('timeout', () => callback(createError('gateway timeout', null, 504)))
175177
.on('response', proxyRes => {
176178
try {
@@ -239,6 +241,7 @@ function proxy (req, resOrSocket, options, onRes, onError) {
239241
)
240242

241243
// XXX Do we need to handle `proxyRes.on('error', ...)`?
244+
// (https://github.com/nodejs/node/issues/15360)
242245

243246
proxySocket
244247
.on('error', callback)

0 commit comments

Comments
 (0)