Bug when using S3 compatible (not amazon) services

[awensaunders]

I use Minio in my local development environment to support developing on attachments. It doesn't work properly right now, because all the URLs that courier passes to rapidpro are wrong, pointing to Amazon S3 rather than my local minio environment.

gocommon/storage/s3.go

Line 15 in e8b962c

var s3BucketURL = "https://%s.s3.amazonaws.com%s"

is hardcoded to amazon's URL. If it pulled from the config instead, it would be portable to various S3 compatible services.

I could make a PR if you want.

[rowanseymour]

Sure, so passed in via S3Options but defaults to that existing AWS URL?

[awensaunders]

That would be the behaviour I’d expect.