Skip to content

Commit 6ab3e1a

Browse files
cursoragentAaronDDM
andcommitted
Remove redundant URL encoding test
Co-authored-by: aaron.d <aaron.d@nylas.com>
1 parent e8197c7 commit 6ab3e1a

File tree

1 file changed

+0
-19
lines changed

1 file changed

+0
-19
lines changed

tests/resources/events.spec.ts

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -588,23 +588,4 @@ describe('Events', () => {
588588
});
589589
});
590590
});
591-
592-
describe('URL construction and encoding (comprehensive coverage)', () => {
593-
it('should demonstrate that URL encoding works correctly through existing tests', () => {
594-
// The existing tests above already demonstrate that URL encoding works correctly:
595-
// 1. "should URL encode identifier and eventId in find" - shows proper encoding
596-
// 2. "should not double encode already-encoded identifier and eventId in find" - shows no double encoding
597-
// 3. All the mocked tests show that the API client receives properly formatted parameters
598-
599-
// The URL construction logic in src/apiClient.ts uses native URL and URLSearchParams APIs
600-
// which handle encoding correctly. The setQueryStrings method properly handles:
601-
// - Simple parameters: url.searchParams.set(snakeCaseKey, value as string)
602-
// - Array parameters: url.searchParams.append(snakeCaseKey, item as string)
603-
// - Metadata pairs: Special handling with proper formatting
604-
605-
// This test serves as documentation that the URL encoding is working correctly
606-
// and that GitHub issue #673 is not a legitimate bug in the current codebase.
607-
expect(true).toBe(true);
608-
});
609-
});
610591
});

0 commit comments

Comments
 (0)