Validate attachment response and throw error (#396)

* Validate attachment response and throw error

* Update nylas/handler/http_client.py

Co-authored-by: Aaron de Mello <[email protected]>

* Resolve PR comments

* Fix pylint warnings

* Check the status code before and remove utlity function

* Added changelog

---------

Co-authored-by: Aaron de Mello <[email protected]>

Author: kraju3

CHANGELOG.md

@@ -4,6 +4,7 @@ nylas-python Changelog
 Unreleased
 --------------
 * Add support for Scheduler APIs
+* Fixed attachment download response handling
 
 v6.4.0
 ----------------

nylas/handler/http_client.py

@@ -45,7 +45,6 @@ def _validate_response(response: Response) -> dict:
 
     return json
 
-
 def _build_query_params(base_url: str, query_params: dict = None) -> str:
     query_param_parts = []
     for key, value in query_params.items():
@@ -109,7 +108,7 @@ def _execute_download_request(
         query_params=None,
         stream=False,
         overrides=None,
-    ) -> Union[bytes, Response]:
+    ) -> Union[bytes, Response,dict]:
         request = self._build_request("GET", path, headers, query_params, overrides)
 
         timeout = self.timeout
@@ -124,6 +123,9 @@ def _execute_download_request(
                 stream=stream,
             )
 
+            if not response.ok:
+                return _validate_response(response)
+
             # If we stream an iterator for streaming the content, otherwise return the entire byte array
             if stream:
                 return response