Skip to content

Commit c77518e

Browse files
committed
PR feedback
1 parent 1d8678b commit c77518e

File tree

1 file changed

+7
-35
lines changed

1 file changed

+7
-35
lines changed

lib/nylas/resources/notetakers.rb

Lines changed: 7 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,7 @@ class Notetakers < Resource
1818
# @param query_params [Hash, nil] Query params to pass to the request.
1919
# @return [Array(Array(Hash), String, String)] The list of notetakers, API Request ID, and next cursor.
2020
def list(identifier: nil, query_params: nil)
21-
path = if identifier
22-
"#{api_uri}/v3/grants/#{identifier}/notetakers"
23-
else
24-
"#{api_uri}/v3/notetakers"
25-
end
21+
path = identifier ? "#{api_uri}/v3/grants/#{identifier}/notetakers" : "#{api_uri}/v3/notetakers"
2622

2723
get_list(
2824
path: path,
@@ -37,11 +33,7 @@ def list(identifier: nil, query_params: nil)
3733
# @param query_params [Hash, nil] Query params to pass to the request.
3834
# @return [Array(Hash, String)] The notetaker and API request ID.
3935
def find(notetaker_id:, identifier: nil, query_params: nil)
40-
path = if identifier
41-
"#{api_uri}/v3/grants/#{identifier}/notetakers/#{notetaker_id}"
42-
else
43-
"#{api_uri}/v3/notetakers/#{notetaker_id}"
44-
end
36+
path = identifier ? "#{api_uri}/v3/grants/#{identifier}/notetakers/#{notetaker_id}" : "#{api_uri}/v3/notetakers/#{notetaker_id}"
4537

4638
get(
4739
path: path,
@@ -55,11 +47,7 @@ def find(notetaker_id:, identifier: nil, query_params: nil)
5547
# @param identifier [String, nil] Grant ID or email account in which to create the object.
5648
# @return [Array(Hash, String)] The created notetaker and API Request ID.
5749
def create(request_body:, identifier: nil)
58-
path = if identifier
59-
"#{api_uri}/v3/grants/#{identifier}/notetakers"
60-
else
61-
"#{api_uri}/v3/notetakers"
62-
end
50+
path = identifier ? "#{api_uri}/v3/grants/#{identifier}/notetakers" : "#{api_uri}/v3/notetakers"
6351

6452
post(
6553
path: path,
@@ -74,11 +62,7 @@ def create(request_body:, identifier: nil)
7462
# @param identifier [String, nil] Grant ID or email account in which to update an object.
7563
# @return [Array(Hash, String)] The updated notetaker and API Request ID.
7664
def update(notetaker_id:, request_body:, identifier: nil)
77-
path = if identifier
78-
"#{api_uri}/v3/grants/#{identifier}/notetakers/#{notetaker_id}"
79-
else
80-
"#{api_uri}/v3/notetakers/#{notetaker_id}"
81-
end
65+
path = identifier ? "#{api_uri}/v3/grants/#{identifier}/notetakers/#{notetaker_id}" : "#{api_uri}/v3/notetakers/#{notetaker_id}"
8266

8367
patch(
8468
path: path,
@@ -93,11 +77,7 @@ def update(notetaker_id:, request_body:, identifier: nil)
9377
# @param query_params [Hash, nil] Query params to pass to the request.
9478
# @return [Array(Hash, String)] The media data and API request ID.
9579
def download_media(notetaker_id:, identifier: nil, query_params: nil)
96-
path = if identifier
97-
"#{api_uri}/v3/grants/#{identifier}/notetakers/#{notetaker_id}/media"
98-
else
99-
"#{api_uri}/v3/notetakers/#{notetaker_id}/media"
100-
end
80+
path = identifier ? "#{api_uri}/v3/grants/#{identifier}/notetakers/#{notetaker_id}/media" : "#{api_uri}/v3/notetakers/#{notetaker_id}/media"
10181

10282
get(
10383
path: path,
@@ -111,11 +91,7 @@ def download_media(notetaker_id:, identifier: nil, query_params: nil)
11191
# @param identifier [String, nil] Grant ID or email account to query.
11292
# @return [Array(Hash, String)] The response data and API request ID.
11393
def leave(notetaker_id:, identifier: nil)
114-
path = if identifier
115-
"#{api_uri}/v3/grants/#{identifier}/notetakers/#{notetaker_id}/leave"
116-
else
117-
"#{api_uri}/v3/notetakers/#{notetaker_id}/leave"
118-
end
94+
path = identifier ? "#{api_uri}/v3/grants/#{identifier}/notetakers/#{notetaker_id}/leave" : "#{api_uri}/v3/notetakers/#{notetaker_id}/leave"
11995

12096
post(
12197
path: path,
@@ -129,11 +105,7 @@ def leave(notetaker_id:, identifier: nil)
129105
# @param identifier [String, nil] Grant ID or email account from which to delete an object.
130106
# @return [Array(TrueClass, String)] True and the API Request ID for the cancel operation.
131107
def cancel(notetaker_id:, identifier: nil)
132-
path = if identifier
133-
"#{api_uri}/v3/grants/#{identifier}/notetakers/#{notetaker_id}/cancel"
134-
else
135-
"#{api_uri}/v3/notetakers/#{notetaker_id}/cancel"
136-
end
108+
path = identifier ? "#{api_uri}/v3/grants/#{identifier}/notetakers/#{notetaker_id}/cancel" : "#{api_uri}/v3/notetakers/#{notetaker_id}/cancel"
137109

138110
_, request_id = delete(
139111
path: path

0 commit comments

Comments
 (0)