Feature/completing nymd client api (#732)

* Calculating gas fees

* Ability to set custom fees

* Added extra test

* Removed commented code

* Moved all msg types to common contract crate

* Temporarily disabling get_tx method

* Finishing up nymd client API

* Comment fix

* Remaining fee values

* Some cleanup

* Removed needless borrow

* Fixed imports in contract tests

* Made contract address optional to allow for contract upload and initialisation

Author: jstuczyn

clients/validator/src/index.ts

@@ -505,7 +505,7 @@ export default class ValidatorClient {
     }
 
     /**
-     * Gets list of all delegations towards particular mixnode.
+     * Gets list of all delegations towards particular gateway.
      *
      * @param gatewayIdentity identity of the gateway to which the delegation was sent
      */

common/client-libs/validator-client/src/error.rs

@@ -32,6 +32,10 @@ pub enum ValidatorClientError {
     #[error("There was an issue with the validator client - {0}")]
     ValidatorError(String),
 
+    #[cfg(feature = "nymd-client")]
+    #[error("No contract address is available to perform the call")]
+    NoContractAddressAvailable,
+
     #[cfg(feature = "nymd-client")]
     #[error("There was an issue with bip32 - {0}")]
     Bip32Error(bip32::Error),

common/client-libs/validator-client/src/nymd/cosmwasm_client/client.rs

@@ -22,7 +22,7 @@ use cosmos_sdk::rpc::query::Query;
 use cosmos_sdk::rpc::{self, HttpClient, Order};
 use cosmos_sdk::tendermint::abci::Transaction;
 use cosmos_sdk::tendermint::{abci, block, chain};
-use cosmos_sdk::{tx, AccountId, Coin, Denom};
+use cosmos_sdk::{AccountId, Coin, Denom};
 use prost::Message;
 use serde::{Deserialize, Serialize};
 use std::convert::{TryFrom, TryInto};
@@ -162,9 +162,12 @@ pub trait CosmWasmClient: rpc::Client {
             .map_err(|_| ValidatorClientError::SerializationError("Coins".to_owned()))
     }
 
-    async fn get_tx(&self, id: tx::Hash) -> Result<TxResponse, ValidatorClientError> {
-        Ok(self.tx(id, false).await?)
-    }
+    // disabled until https://github.com/tendermint/tendermint/issues/6802
+    // and consequently https://github.com/informalsystems/tendermint-rs/issues/942 is resolved
+    //
+    // async fn get_tx(&self, id: tx::Hash) -> Result<TxResponse, ValidatorClientError> {
+    //     Ok(self.tx(id, false).await?)
+    // }
 
     async fn search_tx(&self, query: Query) -> Result<Vec<TxResponse>, ValidatorClientError> {
         // according to https://docs.tendermint.com/master/rpc/#/Info/tx_search

common/client-libs/validator-client/src/nymd/cosmwasm_client/signing_client.rs

@@ -233,7 +233,7 @@ pub trait SigningCosmWasmClient: CosmWasmClient {
         msg: &M,
         fee: Fee,
         memo: impl Into<String> + Send + 'static,
-        funds: Option<Vec<Coin>>,
+        funds: Vec<Coin>,
     ) -> Result<ExecuteResult, ValidatorClientError>
     where
         M: ?Sized + Serialize + Sync,
@@ -242,7 +242,7 @@ pub trait SigningCosmWasmClient: CosmWasmClient {
             sender: sender_address.clone(),
             contract: contract_address.clone(),
             msg: serde_json::to_vec(msg)?,
-            funds: funds.unwrap_or_default(),
+            funds,
         }
         .to_msg()
         .map_err(|_| ValidatorClientError::SerializationError("MsgExecuteContract".to_owned()))?;

common/client-libs/validator-client/src/nymd/fee_helpers.rs

@@ -15,6 +15,16 @@ pub enum Operation {
     Send,
 
     BondMixnode,
+    UnbondMixnode,
+    DelegateToMixnode,
+    UndelegateFromMixnode,
+
+    BondGateway,
+    UnbondGateway,
+    DelegateToGateway,
+    UndelegateFromGateway,
+
+    UpdateStateParams,
 }
 
 pub(crate) fn calculate_fee(gas_price: &GasPrice, gas_limit: Gas) -> Coin {
@@ -28,6 +38,7 @@ pub(crate) fn calculate_fee(gas_price: &GasPrice, gas_limit: Gas) -> Coin {
 }
 
 impl Operation {
+    // TODO: some value tweaking
     pub(crate) fn default_gas_limit(&self) -> Gas {
         match self {
             Operation::Upload => 2_500_000u64.into(),
@@ -37,6 +48,16 @@ impl Operation {
             Operation::Send => 80_000u64.into(),
 
             Operation::BondMixnode => 175_000u64.into(),
+            Operation::UnbondMixnode => 175_000u64.into(),
+            Operation::DelegateToMixnode => 175_000u64.into(),
+            Operation::UndelegateFromMixnode => 175_000u64.into(),
+
+            Operation::BondGateway => 175_000u64.into(),
+            Operation::UnbondGateway => 175_000u64.into(),
+            Operation::DelegateToGateway => 175_000u64.into(),
+            Operation::UndelegateFromGateway => 175_000u64.into(),
+
+            Operation::UpdateStateParams => 175_000u64.into(),
         }
     }
 

common/client-libs/validator-client/src/nymd/gas_price.rs

@@ -51,6 +51,11 @@ impl Default for GasPrice {
 mod tests {
     use super::*;
 
+    #[test]
+    fn default_gas_price_is_valid() {
+        let _ = GasPrice::default();
+    }
+
     #[test]
     fn gas_price_parsing() {
         assert_eq!(