Unable to get cookies with . in the name

[KevinBodi]

Describe the bug

It's not possible to get cookies with a . in their name, like ab-test.variant-1. For now, a workaround is to not use . in the name like ab-test_variant-1.

It's still possible in the plugin to write cookies with . in their name and the cookie shows up both in the HTTP request headers and in the request tab in the debugger toolbar.

While this issue has a simple workaround, it can cause some time spent on debugging and that I see that some third-party tools set cookie names with . in them and they won't be possible to get with this plugin.

To reproduce

Steps to reproduce the behaviour:

1. Use getCookie() on any cookie with . in it's name
2. Get nothing

Expected behaviour

Get the value from the cookie or a error that I can't use this symbol for retrieving cookies.

Versions

• Plugin version: 5.0.0
• Craft version: 5.7.4

[khalwat]

So this is all the get() method does:

    /**
     * Get a cookie
     */
    public function get(string $name = ''): string
    {
        return $_COOKIE[$name] ?? '';
    }

unclear to me how this could be an issue with the plugin?

[KevinBodi]

Interesting!

It seems that PHP will make cookies with . in their name available as if they had a _ in their name instead, so if this plugin replaced the character in the get function, a developer should be able to use strings with a . in both get and set functions.

[khalwat]

According to this:

https://www.php.net/manual/en/reserved.variables.cookies.php

PHP replaces dots (.) with underscores (_). To find all original cookie names (and value) you can use $_SERVER['HTTP_COOKIE'].

So perhaps the code it should use should be:

    /**
     * Get a cookie
     */
    public function get(string $name = ''): string
    {
        $cookies = explode('; ', $_SERVER['HTTP_COOKIE']);
        return $cookies[$name] ?? '';
    }