Skip to content

Commit e96c7c7

Browse files
removing ordered fields code to keep PRs separate
1 parent bd370d7 commit e96c7c7

File tree

1 file changed

+1
-40
lines changed

1 file changed

+1
-40
lines changed

executor.go

Lines changed: 1 addition & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import (
55
"errors"
66
"fmt"
77
"reflect"
8-
"sort"
98
"strings"
109

1110
"github.com/graphql-go/graphql/gqlerrors"
@@ -255,9 +254,7 @@ func executeFieldsSerially(p executeFieldsParams) *Result {
255254
}
256255

257256
finalResults := make(map[string]interface{}, len(p.Fields))
258-
for _, orderedField := range orderedFields(p.Fields) {
259-
responseName := orderedField.responseName
260-
fieldASTs := orderedField.fieldASTs
257+
for responseName, fieldASTs := range p.Fields {
261258
fieldPath := p.Path.WithKey(responseName)
262259
resolved, state := resolveField(p.ExecutionContext, p.ParentType, p.Source, fieldASTs, fieldPath)
263260
if state.hasNoFieldDefs {
@@ -1041,39 +1038,3 @@ func getFieldDef(schema Schema, parentType *Object, fieldName string) *FieldDefi
10411038
}
10421039
return parentType.Fields()[fieldName]
10431040
}
1044-
1045-
// contains field information that will be placed in an ordered slice
1046-
type orderedField struct {
1047-
responseName string
1048-
fieldASTs []*ast.Field
1049-
}
1050-
1051-
// orders fields from a fields map by location in the source
1052-
func orderedFields(fields map[string][]*ast.Field) []*orderedField {
1053-
orderedFields := []*orderedField{}
1054-
fieldMap := map[int]*orderedField{}
1055-
startLocs := []int{}
1056-
1057-
for responseName, fieldASTs := range fields {
1058-
// find the lowest location in the current fieldASTs
1059-
lowest := -1
1060-
for _, fieldAST := range fieldASTs {
1061-
loc := fieldAST.GetLoc().Start
1062-
if lowest == -1 || loc < lowest {
1063-
lowest = loc
1064-
}
1065-
}
1066-
startLocs = append(startLocs, lowest)
1067-
fieldMap[lowest] = &orderedField{
1068-
responseName: responseName,
1069-
fieldASTs: fieldASTs,
1070-
}
1071-
}
1072-
1073-
sort.Ints(startLocs)
1074-
for _, startLoc := range startLocs {
1075-
orderedFields = append(orderedFields, fieldMap[startLoc])
1076-
}
1077-
1078-
return orderedFields
1079-
}

0 commit comments

Comments
 (0)