Skip to content
This repository was archived by the owner on Mar 17, 2021. It is now read-only.

Commit 7f96414

Browse files
committed
use pointer
1 parent ed35027 commit 7f96414

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

folder_permissions.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ type FolderPermission struct {
2929
}
3030

3131
type PermissionItems struct {
32-
Items []PermissionItem `json:"items"`
32+
Items []*PermissionItem `json:"items"`
3333
}
3434

3535
type PermissionItem struct {
@@ -41,8 +41,8 @@ type PermissionItem struct {
4141
Permission int64 `json:"permission"`
4242
}
4343

44-
func (c *Client) FolderPermissions(fid string) ([]FolderPermission, error) {
45-
permissions := make([]FolderPermission, 0)
44+
func (c *Client) FolderPermissions(fid string) ([]*FolderPermission, error) {
45+
permissions := make([]*FolderPermission, 0)
4646

4747
req, err := c.newRequest("GET", fmt.Sprintf("/api/folders/%s/permissions", fid), nil, nil)
4848
if err != nil {

folder_permissions_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ func TestFolderPermissions(t *testing.T) {
6767

6868
t.Log(pretty.PrettyFormat(resp))
6969

70-
expects := []FolderPermission{
70+
expects := []*FolderPermission{
7171
{
7272
Id: 1,
7373
FolderUid: "nErXDvCkzz",
@@ -96,7 +96,7 @@ func TestFolderPermissions(t *testing.T) {
9696

9797
for i, expect := range expects {
9898
t.Run("check data", func(t *testing.T) {
99-
if resp[i] != expect {
99+
if resp[i].Id != expect.Id || resp[i].Role != expect.Role {
100100
t.Error("Not correctly data")
101101
}
102102
})
@@ -108,7 +108,7 @@ func TestUpdateFolderPermissions(t *testing.T) {
108108
defer server.Close()
109109

110110
items := &PermissionItems{
111-
Items: []PermissionItem{
111+
Items: []*PermissionItem{
112112
{
113113
Role: "viewer",
114114
Permission: 1,

0 commit comments

Comments
 (0)