More rework of CI and justfiles

Author: nyurik

.github/workflows/ci.yml

@@ -46,7 +46,6 @@ jobs:
         uses: dtolnay/rust-toolchain@stable
         with:
           toolchain: ${{ steps.msrv.outputs.value }}
-          components: rustfmt
       - run: just ci_mode=0 ci-test-msrv  # Ignore warnings in MSRV
 
   coverage:
@@ -196,7 +195,7 @@ jobs:
   # This approach also allows some jobs to be skipped if they are not needed.
   ci-passed:
     if: always()
-    needs: [ test, test-msrv, coverage, build, cross-build ]
+    needs: [ test, test-msrv, build, cross-build ]
     runs-on: ubuntu-latest
     steps:
       - if: ${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') }}

justfile

@@ -1,19 +1,20 @@
 #!/usr/bin/env just --justfile
 
 main_crate := 'sqlite-hashes'
-bin_name := 'sqlite_hashes'
+features_flag := '--all-features'
+bin_name := snakecase(main_crate)
 sqlite3 := 'sqlite3'
 
 # if running in CI, treat warnings as errors by setting RUSTFLAGS and RUSTDOCFLAGS to '-D warnings' unless they are already set
 # Use `CI=true just ci-test` to run the same tests as in GitHub CI.
 # Use `just env-info` to see the current values of RUSTFLAGS and RUSTDOCFLAGS
-ci_mode := if env('CI', '') != '' { '1' } else { '' }
+ci_mode := if env('CI', '') != '' {'1'} else {''}
 export RUSTFLAGS := env('RUSTFLAGS', if ci_mode == '1' {'-D warnings'} else {''})
 export RUSTDOCFLAGS := env('RUSTDOCFLAGS', if ci_mode == '1' {'-D warnings'} else {''})
 export RUST_BACKTRACE := env('RUST_BACKTRACE', if ci_mode == '1' {'1'} else {''})
 
 @_default:
-    just --list
+    {{just_executable()}} --list
 
 # Run benchmarks
 bench:
@@ -26,21 +27,22 @@ bless *args:  (cargo-install 'cargo-insta')
 
 # Build the project
 build: build-lib build-ext
+    cargo check --workspace --all-targets {{features_flag}}
 
 # Build extension binary
 build-ext *args:
     cargo build --example {{bin_name}} --no-default-features --features default_loadable_extension {{args}}
 
 # Build the lib
 build-lib:
-    cargo build --workspace --all-targets
+    cargo build --workspace
 
 # Quick compile without building a binary
 check:
-    cargo check --workspace --all-targets
+    cargo check --workspace --all-targets {{features_flag}}
 
 # Verify that the current version of the crate is not the same as the one published on crates.io
-check-if-published:  (assert 'jq')
+check-if-published:  (assert-cmd 'jq')
     #!/usr/bin/env bash
     set -euo pipefail
     LOCAL_VERSION="$({{just_executable()}} get-crate-field version)"
@@ -61,21 +63,13 @@ check-lib:
     cargo check --workspace
 
 # Generate code coverage report to upload to codecov.io
-ci-coverage: && \
+ci-coverage: env-info && \
             (coverage '--codecov --output-path target/llvm-cov/codecov.info')
     # ATTENTION: the full file path above is used in the CI workflow
     mkdir -p target/llvm-cov
 
 # Run all tests as expected by CI
-ci-test: env-info test-fmt check clippy test test-ext test-doc
-    #!/usr/bin/env bash
-    set -euo pipefail
-    if [ -n "$(git status --untracked-files --porcelain)" ]; then
-      >&2 echo 'ERROR: git repo is no longer clean. Make sure compilation and tests artifacts are in the .gitignore, and no repo files are modified.'
-      >&2 echo '######### git status ##########'
-      git status
-      exit 1
-    fi
+ci-test: env-info test-fmt check clippy test test-ext test-doc && assert-git-is-clean
 
 # Run minimal subset of tests to ensure compatibility with MSRV
 ci-test-msrv: env-info check-lib test
@@ -86,7 +80,7 @@ clean:
 
 # Run cargo clippy to lint the code
 clippy *args:
-    cargo clippy --workspace --all-targets {{args}}
+    cargo clippy --workspace --all-targets {{features_flag}} {{args}}
     cargo clippy --no-default-features --features default_loadable_extension {{args}}
 
 # Generate code coverage report. Will install `cargo llvm-cov` if missing.
@@ -150,10 +144,10 @@ msrv:  (cargo-install 'cargo-msrv')
 
 # Check semver compatibility with prior published version. Install it with `cargo install cargo-semver-checks`
 semver *args:  (cargo-install 'cargo-semver-checks')
-    cargo semver-checks {{args}}
+    cargo semver-checks {{features_flag}} {{args}}
 
 # Switch to the minimum rusqlite version
-set-min-rusqlite-version:  (assert "jq")
+set-min-rusqlite-version:  (assert-cmd 'jq')
     #!/usr/bin/env bash
     set -euo pipefail
     MIN_RUSQL_VER="$(grep '^rusqlite =.*version = ">=' Cargo.toml | sed -E 's/.*version = "[^"0-9]*([0-9.-]+).*/\1/')"
@@ -162,27 +156,27 @@ set-min-rusqlite-version:  (assert "jq")
 
 # Run all unit and integration tests
 test: \
-    ( test-one-lib "--no-default-features" "--features" "trace,hex,md5"      ) \
-    ( test-one-lib "--no-default-features" "--features" "trace,hex,sha1"     ) \
-    ( test-one-lib "--no-default-features" "--features" "trace,hex,sha224"   ) \
-    ( test-one-lib "--no-default-features" "--features" "trace,hex,sha256"   ) \
-    ( test-one-lib "--no-default-features" "--features" "trace,hex,sha384"   ) \
-    ( test-one-lib "--no-default-features" "--features" "trace,hex,sha512"   ) \
-    ( test-one-lib "--no-default-features" "--features" "trace,hex,blake3"   ) \
-    ( test-one-lib "--no-default-features" "--features" "trace,hex,fnv"      ) \
-    ( test-one-lib "--no-default-features" "--features" "trace,hex,xxhash"   ) \
+    ( test-one-lib '--no-default-features' '--features' 'trace,hex,md5'      ) \
+    ( test-one-lib '--no-default-features' '--features' 'trace,hex,sha1'     ) \
+    ( test-one-lib '--no-default-features' '--features' 'trace,hex,sha224'   ) \
+    ( test-one-lib '--no-default-features' '--features' 'trace,hex,sha256'   ) \
+    ( test-one-lib '--no-default-features' '--features' 'trace,hex,sha384'   ) \
+    ( test-one-lib '--no-default-features' '--features' 'trace,hex,sha512'   ) \
+    ( test-one-lib '--no-default-features' '--features' 'trace,hex,blake3'   ) \
+    ( test-one-lib '--no-default-features' '--features' 'trace,hex,fnv'      ) \
+    ( test-one-lib '--no-default-features' '--features' 'trace,hex,xxhash'   ) \
     \
-    ( test-one-lib "--no-default-features" "--features" "md5,sha1,sha224,sha256,sha384,sha512,blake3,fnv,xxhash"                      ) \
-    ( test-one-lib "--no-default-features" "--features" "md5,sha1,sha224,sha256,sha384,sha512,blake3,fnv,xxhash,aggregate"            ) \
+    ( test-one-lib '--no-default-features' '--features' 'md5,sha1,sha224,sha256,sha384,sha512,blake3,fnv,xxhash'                      ) \
+    ( test-one-lib '--no-default-features' '--features' 'md5,sha1,sha224,sha256,sha384,sha512,blake3,fnv,xxhash,aggregate'            ) \
     \
-    ( test-one-lib "--no-default-features" "--features" "md5,sha1,sha224,sha256,sha384,sha512,blake3,fnv,xxhash,hex"                  ) \
-    ( test-one-lib "--no-default-features" "--features" "md5,sha1,sha224,sha256,sha384,sha512,blake3,fnv,xxhash,hex,aggregate"        ) \
+    ( test-one-lib '--no-default-features' '--features' 'md5,sha1,sha224,sha256,sha384,sha512,blake3,fnv,xxhash,hex'                  ) \
+    ( test-one-lib '--no-default-features' '--features' 'md5,sha1,sha224,sha256,sha384,sha512,blake3,fnv,xxhash,hex,aggregate'        ) \
     \
-    ( test-one-lib "--no-default-features" "--features" "md5,sha1,sha224,sha256,sha384,sha512,blake3,fnv,xxhash,trace"                ) \
-    ( test-one-lib "--no-default-features" "--features" "md5,sha1,sha224,sha256,sha384,sha512,blake3,fnv,xxhash,trace,aggregate"      ) \
+    ( test-one-lib '--no-default-features' '--features' 'md5,sha1,sha224,sha256,sha384,sha512,blake3,fnv,xxhash,trace'                ) \
+    ( test-one-lib '--no-default-features' '--features' 'md5,sha1,sha224,sha256,sha384,sha512,blake3,fnv,xxhash,trace,aggregate'      ) \
     \
-    ( test-one-lib "--no-default-features" "--features" "md5,sha1,sha224,sha256,sha384,sha512,blake3,fnv,xxhash,hex,trace"            ) \
-    ( test-one-lib "--no-default-features" "--features" "md5,sha1,sha224,sha256,sha384,sha512,blake3,fnv,xxhash,hex,trace,aggregate"  )
+    ( test-one-lib '--no-default-features' '--features' 'md5,sha1,sha224,sha256,sha384,sha512,blake3,fnv,xxhash,hex,trace'            ) \
+    ( test-one-lib '--no-default-features' '--features' 'md5,sha1,sha224,sha256,sha384,sha512,blake3,fnv,xxhash,hex,trace,aggregate'  )
 
 # Test documentation
 test-doc:
@@ -199,7 +193,7 @@ test-fmt:
 
 # Find unused dependencies. Install it with `cargo install cargo-udeps`
 udeps:  (cargo-install 'cargo-udeps')
-    cargo +nightly udeps --all-targets --workspace --all-features
+    cargo +nightly udeps --workspace --all-targets {{features_flag}}
 
 # Update all dependencies, including breaking changes. Requires nightly toolchain (install with `rustup install nightly`)
 update:
@@ -208,12 +202,22 @@ update:
 
 # Ensure that a certain command is available
 [private]
-assert command:
+assert-cmd command:
     @if ! type {{command}} > /dev/null; then \
         echo "Command '{{command}}' could not be found. Please make sure it has been installed on your computer." ;\
         exit 1 ;\
     fi
 
+# Make sure the git repo has no uncommitted changes
+[private]
+assert-git-is-clean:
+    @if [ -n "$(git status --untracked-files --porcelain)" ]; then \
+      >&2 echo "ERROR: git repo is no longer clean. Make sure compilation and tests artifacts are in the .gitignore, and no repo files are modified." ;\
+      >&2 echo "######### git status ##########" ;\
+      git status ;\
+      exit 1 ;\
+    fi
+
 # Check if a certain Cargo command is installed, and install it if needed
 [private]
 cargo-install $COMMAND $INSTALL_CMD='' *args='':
@@ -231,11 +235,9 @@ cargo-install $COMMAND $INSTALL_CMD='' *args='':
 
 [private]
 is-sqlite3-available:
-    #!/usr/bin/env bash
-    set -euo pipefail
-    if ! command -v {{sqlite3}} > /dev/null; then
-        echo "{{sqlite3}} executable could not be found"
-        exit 1
+    if ! command -v {{sqlite3}} > /dev/null; then \
+        echo "{{sqlite3}} executable could not be found" ;\
+        exit 1 ;\
     fi
     echo "Found {{sqlite3}} executable:"
     {{sqlite3}} --version

src/cdylib/cdylib.rs

@@ -4,7 +4,10 @@ use rusqlite::ffi::SQLITE_NOTICE;
 use rusqlite::trace::log;
 use rusqlite::{ffi, Connection, Result};
 
-#[allow(clippy::not_unsafe_ptr_arg_deref)]
+/// This is the entry point for the `SQLite` extension.
+///
+/// # Safety
+/// This function is unsafe because it interacts with raw pointers and the `SQLite` C API.
 #[no_mangle]
 pub unsafe extern "C" fn sqlite3_extension_init(
     db: *mut ffi::sqlite3,
@@ -14,6 +17,7 @@ pub unsafe extern "C" fn sqlite3_extension_init(
     Connection::extension_init2(db, pz_err_msg, p_api, extension_init)
 }
 
+#[expect(clippy::needless_pass_by_value)]
 fn extension_init(db: Connection) -> Result<bool> {
     sqlite_hashes::register_hash_functions(&db)?;
     log(SQLITE_NOTICE, "Loaded sqlite_hashes extension");