Skip to content

Commit 2b37dfb

Browse files
committed
fix: if application.*db_uri is null then don't create a env var *DB_URI for it in Pod
Signed-off-by: Siddharth Tiwari <[email protected]>
1 parent b05a559 commit 2b37dfb

File tree

5 files changed

+41
-1
lines changed

5 files changed

+41
-1
lines changed

auto-deploy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ function auto_database_uri() {
168168
# but DB_URI will still contain the value set by user
169169

170170
db=${1}
171-
case ${db} in
171+
case "${db}" in
172172

173173
mariadb)
174174
uri="jdbc:mysql://${MARIADB_RELEASE_NAME}:3306/${MARIADB_DB}?username=${MARIADB_USER}&password=${MARIADB_PASSWORD}"

chart/lambda/templates/db-initialize-job.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,16 +34,26 @@ spec:
3434
name: {{ .Values.application.secretName }}
3535
{{- end }}
3636
env:
37+
{{- if .Values.application.postgresql_uri }}
3738
- name: POSTGRESQL_URI
3839
value: {{ .Values.application.postgresql_uri | quote }}
40+
{{- end }}
41+
{{- if .Values.application.redis_uri }}
3942
- name: REDIS_URI
4043
value: {{ .Values.application.redis_uri | quote }}
44+
{{- end }}
45+
{{- if .Values.application.mysql_uri }}
4146
- name: MYSQL_URI
4247
value: {{ .Values.application.mysql_uri | quote }}
48+
{{- end }}
49+
{{- if .Values.application.mariadb_uri }}
4350
- name: MARIADB_URI
4451
value: {{ .Values.application.mariadb_uri | quote }}
52+
{{- end }}
53+
{{- if .Values.application.mongodb_uri }}
4554
- name: MONGODB_URI
4655
value: {{ .Values.application.mongodb_uri | quote }}
56+
{{- end }}
4757
- name: ENVIRONMENT_NAME
4858
value: {{ .Values.project.env | quote }}
4959
- name: ENVIRONMENT_URL

chart/lambda/templates/db-migrate-hook.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,16 +34,26 @@ spec:
3434
name: {{ .Values.application.secretName }}
3535
{{- end }}
3636
env:
37+
{{- if .Values.application.postgresql_uri }}
3738
- name: POSTGRESQL_URI
3839
value: {{ .Values.application.postgresql_uri | quote }}
40+
{{- end }}
41+
{{- if .Values.application.redis_uri }}
3942
- name: REDIS_URI
4043
value: {{ .Values.application.redis_uri | quote }}
44+
{{- end }}
45+
{{- if .Values.application.mysql_uri }}
4146
- name: MYSQL_URI
4247
value: {{ .Values.application.mysql_uri | quote }}
48+
{{- end }}
49+
{{- if .Values.application.mariadb_uri }}
4350
- name: MARIADB_URI
4451
value: {{ .Values.application.mariadb_uri | quote }}
52+
{{- end }}
53+
{{- if .Values.application.mongodb_uri }}
4554
- name: MONGODB_URI
4655
value: {{ .Values.application.mongodb_uri | quote }}
56+
{{- end }}
4757
- name: ENVIRONMENT_NAME
4858
value: {{ .Values.project.env | quote }}
4959
- name: ENVIRONMENT_URL

chart/lambda/templates/deployment.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,16 +57,26 @@ spec:
5757
name: {{ .Values.application.secretName }}
5858
{{- end }}
5959
env:
60+
{{- if .Values.application.postgresql_uri }}
6061
- name: POSTGRESQL_URI
6162
value: {{ .Values.application.postgresql_uri | quote }}
63+
{{- end }}
64+
{{- if .Values.application.redis_uri }}
6265
- name: REDIS_URI
6366
value: {{ .Values.application.redis_uri | quote }}
67+
{{- end }}
68+
{{- if .Values.application.mysql_uri }}
6469
- name: MYSQL_URI
6570
value: {{ .Values.application.mysql_uri | quote }}
71+
{{- end }}
72+
{{- if .Values.application.mariadb_uri }}
6673
- name: MARIADB_URI
6774
value: {{ .Values.application.mariadb_uri | quote }}
75+
{{- end }}
76+
{{- if .Values.application.mongodb_uri }}
6877
- name: MONGODB_URI
6978
value: {{ .Values.application.mongodb_uri | quote }}
79+
{{- end }}
7080
- name: ENVIRONMENT_NAME
7181
value: {{ .Values.project.env | quote }}
7282
- name: ENVIRONMENT_URL

chart/lambda/templates/worker-deployment.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,16 +62,26 @@ items:
6262
name: {{ $.Values.application.secretName }}
6363
{{- end }}
6464
env:
65+
{{- if $.Values.application.postgresql_uri }}
6566
- name: POSTGRESQL_URI
6667
value: {{ $.Values.application.postgresql_uri | quote }}
68+
{{- end}}
69+
{{- if $.Values.application.redis_uri }}
6770
- name: REDIS_URI
6871
value: {{ $.Values.application.redis_uri | quote }}
72+
{{- end }}
73+
{{- if $.Values.application.mysql_uri }}
6974
- name: MYSQL_URI
7075
value: {{ $.Values.application.mysql_uri | quote }}
76+
{{- end }}
77+
{{- if $.Values.application.mariadb_uri }}
7178
- name: MARIADB_URI
7279
value: {{ $.Values.application.mariadb_uri | quote }}
80+
{{- end }}
81+
{{- if $.Values.application.mongodb_uri }}
7382
- name: MONGODB_URI
7483
value: {{ $.Values.application.mongodb_uri | quote }}
84+
{{- end }}
7585
- name: ENVIRONMENT_NAME
7686
value: {{ $.Values.project.env | quote }}
7787
{{- with $livenessProbeConfig := default $.Values.livenessProbe $workerConfig.livenessProbe -}}

0 commit comments

Comments
 (0)