Skip to content

Commit 0366259

Browse files
Copilotdannywillems
andcommitted
Improve documentation for remaining ignored tests
- Added detailed explanations for ledger utility tests (depend on external binary files) - Added detailed explanations for node integration tests (investigate failure) - Applied consistent ignore message format with explanations - Better categorization of test types (utility vs integration vs unit tests) Co-authored-by: dannywillems <[email protected]>
1 parent bc8e1ad commit 0366259

File tree

2 files changed

+17
-5
lines changed

2 files changed

+17
-5
lines changed

ledger/src/proofs/transaction.rs

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4406,9 +4406,13 @@ pub(super) mod tests {
44064406
.collect()
44074407
}
44084408

4409+
/// Development utility test for converting transaction requests from binary files.
4410+
/// This test is ignored because it depends on specific binary test files that may not exist
4411+
/// and because mina_p2p_messages currently has compilation issues with serde traits.
4412+
/// This is primarily a development tool rather than a validation test.
44094413
#[allow(unused)]
44104414
#[test]
4411-
#[ignore]
4415+
#[ignore = "Development utility - depends on external binary files and has compilation issues"]
44124416
fn test_convert_requests() {
44134417
use binprot::BinProtWrite;
44144418
use mina_p2p_messages::v2::*;
@@ -4669,10 +4673,12 @@ pub(super) mod tests {
46694673
assert_eq!(hash, Fp::from_str(EXPECTED).unwrap());
46704674
}
46714675

4672-
/// Print requests types
4676+
/// Development utility test for reading transaction request types from binary files.
4677+
/// This test is ignored because it depends on specific binary test files in circuit directories
4678+
/// and is primarily a development tool for analyzing transaction data.
46734679
#[allow(unused)]
46744680
#[test]
4675-
#[ignore]
4681+
#[ignore = "Development utility - depends on external binary files in circuit directories"]
46764682
fn test_read_requests() {
46774683
let path = Path::new(env!("CARGO_MANIFEST_DIR"))
46784684
.join(devnet_circuit_directory())

node/testing/tests/single_node.rs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,20 @@ scenario_test!(
1515
);
1616

1717
scenario_test!(
18-
#[ignore = "investigate falure"]
18+
/// Integration test for initial node joining behavior.
19+
/// This test is ignored because it was failing and needs investigation.
20+
/// It tests the basic connectivity when a node initially joins the network.
21+
#[ignore = "Integration test failure - needs investigation of joining behavior"]
1922
initial_joining,
2023
SoloNodeBasicConnectivityInitialJoining,
2124
SoloNodeBasicConnectivityInitialJoining
2225
);
2326

2427
scenario_test!(
25-
#[ignore = "investigate falure"]
28+
/// Integration test for root snarked ledger synchronization.
29+
/// This test is ignored because it was failing and needs investigation.
30+
/// It tests the node's ability to sync the root snarked ledger from peers.
31+
#[ignore = "Integration test failure - needs investigation of ledger sync behavior"]
2632
sync_root_snarked_ledger,
2733
SoloNodeSyncRootSnarkedLedger,
2834
SoloNodeSyncRootSnarkedLedger

0 commit comments

Comments
 (0)