Merge pull request #910 from openmina/fix/asset-name-derandomization

fix(web): Don't use random hashes for names, use file contents checksums

Author: tizoc

frontend/docker/startup.sh

@@ -113,40 +113,76 @@ download_wasm_files() {
     rm "/tmp/openmina-$OPENMINA_WASM_VERSION-webnode-wasm.tar.gz"
 }
 
+get_short_sha1() {
+    local file="$1"
+    if [ -z "$file" ]; then
+        echo "Usage: get_short_sha1 filename" >&2
+        return 1
+    fi
+    if [ ! -f "$file" ]; then
+        echo "Error: File not found: $file" >&2
+        return 1
+    fi
+
+    if command -v sha1sum >/dev/null 2>&1; then
+        sha1sum "$file" | awk '{ print substr($1,1,8) }'
+    elif command -v openssl >/dev/null 2>&1; then
+        openssl sha1 "$file" | awk '{ print substr($2,1,8) }'
+    else
+        echo "Error: Neither sha1sum nor openssl is available for hashing." >&2
+        return 1
+    fi
+}
+
 inject_caching_logic() {
-  local js_file="$1"
-  local index_html="$2"
-  if [ -f "$js_file" ]; then
-    echo "Injecting caching logic into $js_file"
+    local js_file="$1"
+    local index_html="$2"
 
-    # Generate a unique hash
-    local hash=$(openssl rand -hex 8)
+    # Check if JavaScript file exists
+    if [ ! -f "$js_file" ]; then
+        echo "Warning: $js_file not found. Caching logic not injected."
+        return 0
+    fi
 
-    # replace openmina_node_web_bg.wasm with openmina_node_web_bg.$hash.wasm
-    sed -i "s/openmina_node_web_bg.wasm/openmina_node_web_bg.$hash.wasm/g" "$js_file"
+    echo "Injecting caching logic into $js_file"
 
-    # add cache headers to fetch calls
-    sed -i 's/module_or_path = fetch(module_or_path);/module_or_path = fetch(module_or_path, { cache: "force-cache", headers: { "Cache-Control": "max-age=31536000, immutable" } });/' "$js_file"
+    # Define target files
+    local js_target_file="${TARGET_DIR}/openmina_node_web.js"
+    local wasm_target_file="${TARGET_DIR}/openmina_node_web_bg.wasm"
 
-    # rename openmina_node_web_bg.wasm to openmina_node_web_bg.$hash.wasm
-    mv "$TARGET_DIR/openmina_node_web_bg.wasm" "$TARGET_DIR/openmina_node_web_bg.$hash.wasm"
+    # Generate checksum hashes
+    local js_file_hash
+    js_file_hash=$(get_short_sha1 "$js_target_file") || { echo "Failed to get hash for $js_target_file"; return 1; }
 
-    # rename openmina_node_web.js to openmina_node_web.$hash.js
-    mv "$TARGET_DIR/openmina_node_web.js" "$TARGET_DIR/openmina_node_web.$hash.js"
+    local wasm_file_hash
+    wasm_file_hash=$(get_short_sha1 "$wasm_target_file") || { echo "Failed to get hash for $wasm_target_file"; return 1; }
 
-    # replace openmina_node_web.js with openmina_node_web.$hash.js in index.html
-    sed -i "s/openmina_node_web.js/openmina_node_web.$hash.js/g" "$index_html"
+    # Check if hashed files already exist to prevent multiple injections
+    local js_new_file="${TARGET_DIR}/openmina_node_web.${js_file_hash}.js"
+    local wasm_new_file="${TARGET_DIR}/openmina_node_web_bg.${wasm_file_hash}.wasm"
 
-    if [[ $? -ne 0 ]]; then
-      echo "Failed to inject caching logic into $js_file"
-    else
-      echo "Successfully injected caching logic into $js_file"
+    if [[ -f "$js_new_file" ]] && [[ -f "$wasm_new_file" ]]; then
+        echo "Hashed files already exist. Skipping caching logic injection."
+        return 0
     fi
-  else
-    echo "Warning: $js_file not found. Caching logic not injected."
-  fi
-}
 
+    # Replace openmina_node_web_bg.wasm with openmina_node_web_bg.<hash>.wasm in JS file
+    sed -i "s/openmina_node_web_bg\.wasm/openmina_node_web_bg.${wasm_file_hash}.wasm/g" "$js_file" || { echo "Failed to update wasm filename in $js_file"; return 1; }
+
+    # Add cache headers to fetch calls in JS file
+    sed -i 's/module_or_path = fetch(module_or_path);/module_or_path = fetch(module_or_path, { cache: "force-cache", headers: { "Cache-Control": "max-age=31536000, immutable" } });/' "$js_file" || { echo "Failed to inject cache headers into $js_file"; return 1; }
+
+    # Rename wasm file with hash
+    mv "$wasm_target_file" "$wasm_new_file" || { echo "Failed to rename $wasm_target_file to $wasm_new_file"; return 1; }
+
+    # Rename JS file with hash
+    mv "$js_target_file" "$js_new_file" || { echo "Failed to rename $js_target_file to $js_new_file"; return 1; }
+
+    # Replace JS filename in index.html
+    sed -i "s/openmina_node_web\.js/openmina_node_web.${js_file_hash}.js/g" "$index_html" || { echo "Failed to update JS filename in $index_html"; return 1; }
+
+    echo "Successfully injected caching logic into $js_file"
+}
 
 if [ -n "$OPENMINA_FRONTEND_ENVIRONMENT" ]; then
   echo "Using environment: $OPENMINA_FRONTEND_ENVIRONMENT"