mina-tx-type: integrate currency types with ledger crate

Move currency types (Amount, Balance, Fee, Nonce, Slot, etc.) to
mina-tx-type and have ledger crate re-export them. This includes:

- Add mina-p2p-messages as dependency for type conversions
- Add ark-ff dependency for field operations in Magnitude trait
- Move From implementations for p2p message types to mina-tx-type
- Move rand Distribution implementations to mina-tx-type
- Update ledger/scan_state/currency.rs to re-export from mina-tx-type
- Add extension traits (AmountToChecked, etc.) for checked conversions
- Clean up unused imports across ledger crate
- Add mina-tx-type to frontend Dockerfile for WASM builds

Author: dannywillems

Cargo.lock

@@ -69,6 +69,7 @@ COPY genesis_ledgers ./genesis_ledgers
 COPY ledger ./ledger
 COPY macros ./macros
 COPY mina-p2p-messages ./mina-p2p-messages
+COPY mina-tx-type ./mina-tx-type
 COPY node ./node
 COPY p2p ./p2p
 COPY poseidon ./poseidon

frontend/Dockerfile

@@ -43,6 +43,7 @@ mina-macros = { workspace = true }
 mina-p2p-messages = { workspace = true }
 mina-poseidon = { workspace = true }
 mina-signer = { workspace = true }
+mina-tx-type = { workspace = true }
 num-bigint = { workspace = true }
 o1-utils = { workspace = true }
 once_cell = { workspace = true }

ledger/Cargo.toml

@@ -4,6 +4,7 @@ use crate::{
         numbers::{
             currency::{CheckedAmount, CheckedBalance},
             nat::{CheckedSlot, CheckedSlotSpan},
+            AmountToChecked, BalanceToChecked, SlotSpanToChecked, SlotToChecked,
         },
         to_field_elements::ToFieldElements,
     },

ledger/src/account/common.rs

@@ -28,7 +28,7 @@ use crate::{
         wrap::{wrap, WrapParams},
     },
     scan_state::{
-        currency,
+        currency::{self, Magnitude},
         fee_excess::{self, FeeExcess},
         pending_coinbase::{PendingCoinbase, PendingCoinbaseWitness, Stack},
         protocol_state::MinaHash,
@@ -47,6 +47,7 @@ use super::{
     numbers::{
         currency::CheckedAmount,
         nat::{CheckedBlockTime, CheckedBlockTimeSpan, CheckedLength},
+        AmountToChecked, LengthToChecked, SignedAmountToChecked,
     },
     step::{step, InductiveRule, OptFlag, PreviousProofStatement, StepParams, StepProof},
     to_field_elements::ToFieldElements,

ledger/src/proofs/block.rs

@@ -23,6 +23,7 @@ use crate::{
 use super::{
     constants::WrapMergeProof,
     field::{Boolean, CircuitVar, FieldWitness},
+    numbers::{SignedAmountToChecked, SignedFeeToChecked},
     public_input::plonk_checks::PlonkMinimal,
     step::{
         extract_recursion_challenges, InductiveRule, OptFlag, PreviousProofStatement, StepProof,

ledger/src/proofs/merge.rs

@@ -510,22 +510,6 @@ macro_rules! impl_currency {
             }
         }
 
-        impl $unchecked {
-            pub fn to_checked<F: FieldWitness>(&self) -> $name<F> {
-                $name::from_inner(*self)
-            }
-        }
-
-        impl Signed<$unchecked> {
-            pub fn to_checked<F: FieldWitness>(&self) -> CheckedSigned<F, $name<F>> {
-                CheckedSigned {
-                    magnitude: self.magnitude.to_checked(),
-                    sgn: CircuitVar::Var(self.sgn),
-                    value: Cell::new(None),
-                }
-            }
-        }
-
         impl<F: FieldWitness> ForZkappCheck<F> for $unchecked {
             type CheckedType = $name<F>;
             fn checked_from_field(field: F) -> Self::CheckedType {
@@ -543,3 +527,76 @@ impl_currency!(
     {CheckedFee, Fee},
     {CheckedBalance, Balance}
 );
+
+// Extension traits for to_checked conversion
+pub trait AmountToChecked {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedAmount<F>;
+}
+
+impl AmountToChecked for Amount {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedAmount<F> {
+        CheckedAmount::from_inner(*self)
+    }
+}
+
+pub trait FeeToChecked {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedFee<F>;
+}
+
+impl FeeToChecked for Fee {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedFee<F> {
+        CheckedFee::from_inner(*self)
+    }
+}
+
+pub trait BalanceToChecked {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedBalance<F>;
+}
+
+impl BalanceToChecked for Balance {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedBalance<F> {
+        CheckedBalance::from_inner(*self)
+    }
+}
+
+pub trait SignedAmountToChecked {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedSigned<F, CheckedAmount<F>>;
+}
+
+impl SignedAmountToChecked for Signed<Amount> {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedSigned<F, CheckedAmount<F>> {
+        CheckedSigned {
+            magnitude: AmountToChecked::to_checked::<F>(&self.magnitude),
+            sgn: CircuitVar::Var(self.sgn),
+            value: Cell::new(None),
+        }
+    }
+}
+
+pub trait SignedFeeToChecked {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedSigned<F, CheckedFee<F>>;
+}
+
+impl SignedFeeToChecked for Signed<Fee> {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedSigned<F, CheckedFee<F>> {
+        CheckedSigned {
+            magnitude: FeeToChecked::to_checked::<F>(&self.magnitude),
+            sgn: CircuitVar::Var(self.sgn),
+            value: Cell::new(None),
+        }
+    }
+}
+
+pub trait SignedBalanceToChecked {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedSigned<F, CheckedBalance<F>>;
+}
+
+impl SignedBalanceToChecked for Signed<Balance> {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedSigned<F, CheckedBalance<F>> {
+        CheckedSigned {
+            magnitude: BalanceToChecked::to_checked::<F>(&self.magnitude),
+            sgn: CircuitVar::Var(self.sgn),
+            value: Cell::new(None),
+        }
+    }
+}

ledger/src/proofs/numbers/currency.rs

@@ -1,3 +1,13 @@
 pub mod common;
 pub mod currency;
 pub mod nat;
+
+// Re-export extension traits for to_checked conversion
+pub use currency::{
+    AmountToChecked, BalanceToChecked, FeeToChecked, SignedAmountToChecked, SignedBalanceToChecked,
+    SignedFeeToChecked,
+};
+pub use nat::{
+    BlockTimeSpanToChecked, BlockTimeToChecked, IndexToChecked, LengthToChecked, NonceToChecked,
+    SlotSpanToChecked, SlotToChecked, TxnVersionToChecked,
+};

ledger/src/proofs/numbers/mod.rs

@@ -204,7 +204,7 @@ impl CheckedSlot<Fp> {
         w: &mut Witness<Fp>,
     ) -> Boolean {
         // constant
-        let c = |n: u32| Length::from_u32(n).to_checked();
+        let c = |n: u32| LengthToChecked::to_checked::<Fp>(&Length::from_u32(n));
         let third_epoch = {
             let (q, _r) = constants.slots_per_epoch.div_mod(&c(3), w);
             q
@@ -260,12 +260,6 @@ macro_rules! impl_nat {
             }
         }
 
-        impl $unchecked {
-            pub fn to_checked<F: FieldWitness>(&self) -> $name<F> {
-                $name::from_inner(*self)
-            }
-        }
-
         impl<F: FieldWitness> ForZkappCheck<F> for $unchecked {
             type CheckedType = $name<F>;
             fn checked_from_field(field: F) -> Self::CheckedType {
@@ -349,3 +343,85 @@ impl<F: FieldWitness> CheckedN32<F> {
         Self::from_field(n.into())
     }
 }
+
+// Extension traits for to_checked conversion
+
+pub trait TxnVersionToChecked {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedTxnVersion<F>;
+}
+
+impl TxnVersionToChecked for TxnVersion {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedTxnVersion<F> {
+        CheckedTxnVersion::from_inner(*self)
+    }
+}
+
+pub trait SlotToChecked {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedSlot<F>;
+}
+
+impl SlotToChecked for Slot {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedSlot<F> {
+        CheckedSlot::from_inner(*self)
+    }
+}
+
+pub trait SlotSpanToChecked {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedSlotSpan<F>;
+}
+
+impl SlotSpanToChecked for SlotSpan {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedSlotSpan<F> {
+        CheckedSlotSpan::from_inner(*self)
+    }
+}
+
+pub trait LengthToChecked {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedLength<F>;
+}
+
+impl LengthToChecked for Length {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedLength<F> {
+        CheckedLength::from_inner(*self)
+    }
+}
+
+pub trait NonceToChecked {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedNonce<F>;
+}
+
+impl NonceToChecked for Nonce {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedNonce<F> {
+        CheckedNonce::from_inner(*self)
+    }
+}
+
+pub trait IndexToChecked {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedIndex<F>;
+}
+
+impl IndexToChecked for Index {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedIndex<F> {
+        CheckedIndex::from_inner(*self)
+    }
+}
+
+pub trait BlockTimeToChecked {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedBlockTime<F>;
+}
+
+impl BlockTimeToChecked for BlockTime {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedBlockTime<F> {
+        CheckedBlockTime::from_inner(*self)
+    }
+}
+
+pub trait BlockTimeSpanToChecked {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedBlockTimeSpan<F>;
+}
+
+impl BlockTimeSpanToChecked for BlockTimeSpan {
+    fn to_checked<F: FieldWitness>(&self) -> CheckedBlockTimeSpan<F> {
+        CheckedBlockTimeSpan::from_inner(*self)
+    }
+}

ledger/src/proofs/numbers/nat.rs

@@ -52,6 +52,10 @@ use crate::{
 use super::{
     constants::ProofConstants,
     field::{field, Boolean, CircuitVar, FieldWitness, GroupAffine, ToBoolean},
+    numbers::{
+        AmountToChecked, BalanceToChecked, FeeToChecked, NonceToChecked, SignedAmountToChecked,
+        SignedFeeToChecked, SlotToChecked,
+    },
     public_input::messages::{dummy_ipa_step_sg, MessagesForNextWrapProof},
     step,
     step::{InductiveRule, OptFlag, StepProof},