mina-p2p-messages: copy definition of InvalidBigInt

dannywillems · dannywillems · commit 4dd76d23f14f · 2025-09-08T14:46:38.000+02:00
This is a copy-paste from openmina/algebra@0ee1798#diff-26dabf22b47ebe1097e18d25b10c8252331b1255b142bf0f29cdc9f2ae28a27f to keep the same compatibility layer.
diff --git a/core/src/block/block_with_hash.rs b/core/src/block/block_with_hash.rs
@@ -1,5 +1,4 @@
-use ark_ff::fields::arithmetic::InvalidBigInt;
-use mina_p2p_messages::v2;
+use mina_p2p_messages::{bigint::InvalidBigInt, v2};
 use redux::Timestamp;
 use serde::{Deserialize, Serialize};
 
diff --git a/core/src/block/genesis.rs b/core/src/block/genesis.rs
@@ -1,5 +1,7 @@
-use ark_ff::fields::arithmetic::InvalidBigInt;
-use mina_p2p_messages::v2::{self, StateHash};
+use mina_p2p_messages::{
+    bigint::InvalidBigInt,
+    v2::{self, StateHash},
+};
 
 use crate::constants::{constraint_constants, slots_per_window};
 
diff --git a/ledger/src/account/conv.rs b/ledger/src/account/conv.rs
@@ -1,10 +1,10 @@
 #![allow(clippy::type_complexity)]
 
 use ark_ec::short_weierstrass::Affine;
-use ark_ff::{fields::arithmetic::InvalidBigInt, Field, PrimeField};
+use ark_ff::{Field, PrimeField};
 use mina_curves::pasta::Fp;
 use mina_p2p_messages::{
-    bigint::BigInt,
+    bigint::{BigInt, InvalidBigInt},
     binprot,
     pseq::PaddedSeq,
     v2::{
diff --git a/ledger/src/proofs/accumulator_check.rs b/ledger/src/proofs/accumulator_check.rs
@@ -1,6 +1,8 @@
-use ark_ff::fields::arithmetic::InvalidBigInt;
 use mina_curves::pasta::{Fp, Vesta};
-use mina_p2p_messages::{bigint::BigInt, v2::PicklesProofProofsVerified2ReprStableV2};
+use mina_p2p_messages::{
+    bigint::{BigInt, InvalidBigInt},
+    v2::PicklesProofProofsVerified2ReprStableV2,
+};
 use poly_commitment::{commitment::CommitmentCurve, ipa::SRS};
 
 use super::{public_input::scalar_challenge::ScalarChallenge, urs_utils};
diff --git a/ledger/src/proofs/block.rs b/ledger/src/proofs/block.rs
@@ -1,11 +1,10 @@
 use std::{rc::Rc, sync::Arc};
 
 use anyhow::Context;
-use ark_ff::fields::arithmetic::InvalidBigInt;
 use consensus::ConsensusState;
 use mina_core::constants::{constraint_constants, ForkConstants};
 use mina_curves::pasta::{Fp, Fq};
-use mina_p2p_messages::v2;
+use mina_p2p_messages::{bigint::InvalidBigInt, v2};
 use poseidon::hash::{
     params::{MINA_PROTO_STATE, MINA_PROTO_STATE_BODY},
     Inputs,
diff --git a/ledger/src/proofs/caching.rs b/ledger/src/proofs/caching.rs
@@ -5,7 +5,6 @@ use std::{
 };
 
 use ark_ec::{short_weierstrass::Affine, AffineRepr, CurveConfig};
-use ark_ff::fields::arithmetic::InvalidBigInt;
 use ark_poly::{univariate::DensePolynomial, Radix2EvaluationDomain};
 use kimchi::{
     alphas::Alphas,
@@ -21,7 +20,7 @@ use kimchi::{
     verifier_index::LookupVerifierIndex,
 };
 use mina_curves::pasta::Fq;
-use mina_p2p_messages::bigint::BigInt;
+use mina_p2p_messages::bigint::{BigInt, InvalidBigInt};
 use once_cell::sync::OnceCell;
 use poly_commitment::{
     commitment::CommitmentCurve, hash_map_cache::HashMapCache, ipa::SRS, PolyComm,
diff --git a/ledger/src/proofs/conv.rs b/ledger/src/proofs/conv.rs
@@ -1,6 +1,5 @@
-use ark_ff::fields::arithmetic::InvalidBigInt;
 use mina_curves::pasta::Fp;
-use mina_p2p_messages::v2;
+use mina_p2p_messages::{bigint::InvalidBigInt, v2};
 
 use crate::scan_state::{
     currency::{self, Length, Slot},
diff --git a/ledger/src/proofs/merge.rs b/ledger/src/proofs/merge.rs
@@ -6,9 +6,8 @@ use crate::proofs::{
     util::sha256_sum,
     wrap::{wrap, WrapParams},
 };
-use ark_ff::fields::arithmetic::InvalidBigInt;
 use mina_curves::pasta::{Fp, Fq};
-use mina_p2p_messages::v2;
+use mina_p2p_messages::{bigint::InvalidBigInt, v2};
 
 use crate::{
     proofs::transaction::transaction_snark::assert_equal_local_state,
diff --git a/ledger/src/proofs/step.rs b/ledger/src/proofs/step.rs
@@ -18,13 +18,13 @@ use crate::{
     verifier::{get_srs, get_srs_mut},
 };
 use anyhow::Context;
-use ark_ff::{fields::arithmetic::InvalidBigInt, BigInteger256, One, Zero};
+use ark_ff::{BigInteger256, One, Zero};
 use ark_poly::{
     univariate::DensePolynomial, DenseUVPolynomial, EvaluationDomain, Radix2EvaluationDomain,
 };
 use kimchi::proof::{PointEvaluations, ProverCommitments, RecursionChallenge};
 use mina_curves::pasta::{Fp, Fq, Pallas};
-use mina_p2p_messages::v2;
+use mina_p2p_messages::{bigint::InvalidBigInt, v2};
 use poly_commitment::{commitment::b_poly_coefficients, ipa::OpeningProof};
 
 use crate::proofs::{
diff --git a/ledger/src/proofs/transaction.rs b/ledger/src/proofs/transaction.rs
@@ -2,25 +2,28 @@ use std::{collections::HashMap, rc::Rc, str::FromStr, sync::Arc};
 
 use anyhow::Context;
 use ark_ec::{short_weierstrass::Projective, AffineRepr, CurveGroup, PrimeGroup};
-use ark_ff::{fields::arithmetic::InvalidBigInt, AdditiveGroup, BigInteger256, Field, PrimeField};
+use ark_ff::{AdditiveGroup, BigInteger256, Field, PrimeField};
 use kimchi::{
     circuits::{gate::CircuitGate, wires::COLUMNS},
     groupmap::{BWParameters, GroupMap},
     proof::RecursionChallenge,
 };
 use mina_curves::pasta::{Fp, Fq};
-use mina_p2p_messages::v2::{
-    self, ConsensusProofOfStakeDataEpochDataNextValueVersionedValueStableV1,
-    ConsensusProofOfStakeDataEpochDataStakingValueVersionedValueStableV1, CurrencyAmountStableV1,
-    MinaBaseEpochLedgerValueStableV1, MinaBaseFeeExcessStableV1,
-    MinaBaseProtocolConstantsCheckedValueStableV1, MinaNumbersGlobalSlotSinceGenesisMStableV1,
-    MinaNumbersGlobalSlotSinceHardForkMStableV1,
-    MinaStateBlockchainStateValueStableV2LedgerProofStatement,
-    MinaStateBlockchainStateValueStableV2LedgerProofStatementSource,
-    MinaStateBlockchainStateValueStableV2SignedAmount,
-    MinaTransactionLogicZkappCommandLogicLocalStateValueStableV1, SgnStableV1, SignedAmount,
-    TokenFeeExcess, UnsignedExtendedUInt32StableV1,
-    UnsignedExtendedUInt64Int64ForVersionTagsStableV1,
+use mina_p2p_messages::{
+    bigint::InvalidBigInt,
+    v2::{
+        self, ConsensusProofOfStakeDataEpochDataNextValueVersionedValueStableV1,
+        ConsensusProofOfStakeDataEpochDataStakingValueVersionedValueStableV1,
+        CurrencyAmountStableV1, MinaBaseEpochLedgerValueStableV1, MinaBaseFeeExcessStableV1,
+        MinaBaseProtocolConstantsCheckedValueStableV1, MinaNumbersGlobalSlotSinceGenesisMStableV1,
+        MinaNumbersGlobalSlotSinceHardForkMStableV1,
+        MinaStateBlockchainStateValueStableV2LedgerProofStatement,
+        MinaStateBlockchainStateValueStableV2LedgerProofStatementSource,
+        MinaStateBlockchainStateValueStableV2SignedAmount,
+        MinaTransactionLogicZkappCommandLogicLocalStateValueStableV1, SgnStableV1, SignedAmount,
+        TokenFeeExcess, UnsignedExtendedUInt32StableV1,
+        UnsignedExtendedUInt64Int64ForVersionTagsStableV1,
+    },
 };
 use mina_poseidon::constants::PlonkSpongeConstantsKimchi;
 use mina_signer::{CompressedPubKey, PubKey};
diff --git a/ledger/src/proofs/unfinalized.rs b/ledger/src/proofs/unfinalized.rs
@@ -1,7 +1,6 @@
-use ark_ff::fields::arithmetic::InvalidBigInt;
 use kimchi::proof::{PointEvaluations, ProofEvaluations};
 use mina_curves::pasta::{Fp, Fq};
-use mina_p2p_messages::v2;
+use mina_p2p_messages::{bigint::InvalidBigInt, v2};
 
 use crate::proofs::{
     field::FieldWitness, public_input::plonk_checks::derive_plonk, step::FeatureFlags,
diff --git a/ledger/src/proofs/util.rs b/ledger/src/proofs/util.rs
@@ -1,9 +1,10 @@
 use std::fmt::Debug;
 
-use ark_ff::{fields::arithmetic::InvalidBigInt, BigInteger256, Field};
+use ark_ff::{BigInteger256, Field};
 use kimchi::proof::{PointEvaluations, ProofEvaluations};
 use mina_p2p_messages::{
-    bigint::BigInt, pseq::PaddedSeq,
+    bigint::{BigInt, InvalidBigInt},
+    pseq::PaddedSeq,
     v2::PicklesReducedMessagesForNextProofOverSameFieldWrapChallengesVectorStableV2A,
 };
 
diff --git a/ledger/src/proofs/verification.rs b/ledger/src/proofs/verification.rs
@@ -1,9 +1,9 @@
 use std::rc::Rc;
 
-use ark_ff::fields::arithmetic::InvalidBigInt;
 use ark_poly::{EvaluationDomain, Radix2EvaluationDomain};
 use ark_serialize::Write;
 use itertools::Itertools;
+use mina_p2p_messages::bigint::InvalidBigInt;
 use poly_commitment::ipa::SRS;
 
 use crate::{
diff --git a/ledger/src/proofs/wrap.rs b/ledger/src/proofs/wrap.rs
@@ -1,16 +1,19 @@
 use std::{borrow::Cow, ops::Neg, rc::Rc};
 
-use ark_ff::{fields::arithmetic::InvalidBigInt, BigInteger256, One, Zero};
+use ark_ff::{BigInteger256, One, Zero};
 use ark_poly::{univariate::DensePolynomial, DenseUVPolynomial, EvaluationDomain};
 use kimchi::{
     circuits::{expr::RowOffset, scalars::RandomOracles, wires::COLUMNS},
     oracles::OraclesResult,
     proof::{PointEvaluations, ProofEvaluations, RecursionChallenge},
 };
 use mina_curves::pasta::{Fp, Fq, Pallas, Vesta};
-use mina_p2p_messages::v2::{
-    CompositionTypesBranchDataDomainLog2StableV1, CompositionTypesBranchDataStableV1,
-    PicklesBaseProofsVerifiedStableV1,
+use mina_p2p_messages::{
+    bigint::InvalidBigInt,
+    v2::{
+        CompositionTypesBranchDataDomainLog2StableV1, CompositionTypesBranchDataStableV1,
+        PicklesBaseProofsVerifiedStableV1,
+    },
 };
 use mina_poseidon::{sponge::ScalarChallenge, FqSponge};
 use poly_commitment::{commitment::b_poly_coefficients, ipa::OpeningProof, PolyComm, SRS};
diff --git a/ledger/src/proofs/zkapp.rs b/ledger/src/proofs/zkapp.rs
@@ -1,9 +1,9 @@
 use std::{cell::RefCell, rc::Rc};
 
-use ark_ff::{fields::arithmetic::InvalidBigInt, BigInteger256, Zero};
+use ark_ff::{BigInteger256, Zero};
 use kimchi::proof::PointEvaluations;
 use mina_curves::pasta::{Fp, Fq};
-use mina_p2p_messages::v2;
+use mina_p2p_messages::{bigint::InvalidBigInt, v2};
 use poly_commitment::ipa::OpeningProof;
 use poseidon::hash::{
     hash_with_kimchi,
diff --git a/ledger/src/scan_state/conv.rs b/ledger/src/scan_state/conv.rs
@@ -2,9 +2,9 @@
 
 use std::sync::Arc;
 
-use ark_ff::fields::arithmetic::InvalidBigInt;
 use mina_curves::pasta::Fp;
 use mina_p2p_messages::{
+    bigint::InvalidBigInt,
     binprot,
     list::List,
     pseq::PaddedSeq,
diff --git a/ledger/src/scan_state/pending_coinbase.rs b/ledger/src/scan_state/pending_coinbase.rs
@@ -20,9 +20,10 @@
 /// Stack operations are done for transaction snarks and tree operations are done for the blockchain snark*)
 use std::{collections::HashMap, fmt::Write, marker::PhantomData};
 
-use ark_ff::{fields::arithmetic::InvalidBigInt, Zero};
+use ark_ff::Zero;
 use mina_core::constants::constraint_constants;
 use mina_curves::pasta::Fp;
+use mina_p2p_messages::bigint::InvalidBigInt;
 use mina_signer::CompressedPubKey;
 use poseidon::hash::{
     hash_noinputs, hash_with_kimchi,
diff --git a/ledger/src/scan_state/scan_state.rs b/ledger/src/scan_state/scan_state.rs
@@ -531,7 +531,7 @@ pub mod transaction_snark {
     }
 
     pub mod work {
-        use ark_ff::fields::arithmetic::InvalidBigInt;
+        use mina_p2p_messages::bigint::InvalidBigInt;
 
         use super::*;
 
diff --git a/ledger/src/scan_state/transaction_logic.rs b/ledger/src/scan_state/transaction_logic.rs
@@ -3,12 +3,13 @@ use std::{
     fmt::Display,
 };
 
-use ark_ff::{fields::arithmetic::InvalidBigInt, Zero};
+use ark_ff::Zero;
 use itertools::{FoldWhile, Itertools};
 use mina_core::constants::ConstraintConstants;
 use mina_hasher::{Fp, Hashable, ROInput};
 use mina_macros::SerdeYojsonEnum;
 use mina_p2p_messages::{
+    bigint::InvalidBigInt,
     binprot,
     v2::{MinaBaseUserCommandStableV2, MinaTransactionTransactionStableV2},
 };
diff --git a/ledger/src/sparse_ledger/sparse_ledger.rs b/ledger/src/sparse_ledger/sparse_ledger.rs
@@ -3,9 +3,10 @@ use std::{
     sync::{Arc, Mutex},
 };
 
-use ark_ff::{fields::arithmetic::InvalidBigInt, Zero};
+use ark_ff::Zero;
 use mina_core::constants::constraint_constants;
 use mina_curves::pasta::Fp;
+use mina_p2p_messages::bigint::InvalidBigInt;
 
 use crate::{
     scan_state::{
diff --git a/mina-p2p-messages/src/bigint.rs b/mina-p2p-messages/src/bigint.rs
@@ -1,8 +1,29 @@
-use ark_ff::{fields::arithmetic::InvalidBigInt, BigInteger256};
+use ark_ff::BigInteger256;
 use malloc_size_of::MallocSizeOf;
 use rsexp::{OfSexp, SexpOf};
 use serde::{Deserialize, Serialize};
 
+// ---
+// This has been imported from a fork of arkworks/ff
+// We should probably revisit this structure in the future
+#[derive(Clone, Debug)]
+pub struct InvalidBigInt;
+
+impl core::fmt::Display for InvalidBigInt {
+    fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
+        write!(f, "InvalidBigInt")
+    }
+}
+
+impl From<InvalidBigInt> for String {
+    fn from(_: InvalidBigInt) -> Self {
+        "InvalidBigInt".to_string()
+    }
+}
+
+impl std::error::Error for InvalidBigInt {}
+// ---
+
 #[derive(Clone, Default, PartialEq, Eq, PartialOrd, Ord, derive_more::From, derive_more::Into)]
 pub struct BigInt(BigInteger256);
 
diff --git a/mina-p2p-messages/src/hash.rs b/mina-p2p-messages/src/hash.rs
@@ -1,6 +1,7 @@
-use ark_ff::fields::arithmetic::InvalidBigInt;
 use mina_curves::pasta::Fp;
 
+use crate::bigint::InvalidBigInt;
+
 pub trait MinaHash {
     fn try_hash(&self) -> Result<Fp, InvalidBigInt>;
 }
diff --git a/mina-p2p-messages/src/hash_input.rs b/mina-p2p-messages/src/hash_input.rs
@@ -1,10 +1,9 @@
 use std::ops::Deref;
 
-use ark_ff::fields::arithmetic::InvalidBigInt;
 use poseidon::hash::Inputs;
 
 use crate::{
-    bigint::BigInt,
+    bigint::{BigInt, InvalidBigInt},
     list::List,
     number::{Int32, Int64, UInt32, UInt64},
     string::{ByteString, ZkAppUri},
diff --git a/mina-p2p-messages/src/keys.rs b/mina-p2p-messages/src/keys.rs
@@ -1,4 +1,4 @@
-use ark_ff::fields::arithmetic::InvalidBigInt;
+use crate::bigint::InvalidBigInt;
 
 impl TryFrom<crate::v2::NonZeroCurvePointUncompressedStableV1> for mina_signer::CompressedPubKey {
     type Error = InvalidBigInt;
diff --git a/mina-p2p-messages/src/v2/hashing.rs b/mina-p2p-messages/src/v2/hashing.rs
@@ -1,6 +1,5 @@
 use std::{fmt, io, sync::Arc};
 
-use ark_ff::fields::arithmetic::InvalidBigInt;
 use binprot::{BinProtRead, BinProtWrite};
 use generated::MinaStateBlockchainStateValueStableV2;
 use mina_curves::pasta::Fp;
@@ -15,7 +14,11 @@ use sha2::{
     Digest, Sha256,
 };
 
-use crate::{bigint::BigInt, hash::MinaHash, hash_input::FailableToInputs};
+use crate::{
+    bigint::{BigInt, InvalidBigInt},
+    hash::MinaHash,
+    hash_input::FailableToInputs,
+};
 
 use super::{
     generated, ConsensusBodyReferenceStableV1, ConsensusGlobalSlotStableV1,
diff --git a/node/common/src/service/snarks.rs b/node/common/src/service/snarks.rs
@@ -1,14 +1,13 @@
 use std::sync::Arc;
 
-use ark_ff::fields::arithmetic::InvalidBigInt;
 use ledger::{
     scan_state::{
         scan_state::transaction_snark::{SokDigest, Statement},
         transaction_logic::WithStatus,
     },
     transaction_pool::{TransactionError, TransactionPoolErrors},
 };
-use mina_p2p_messages::v2;
+use mina_p2p_messages::{bigint::InvalidBigInt, v2};
 use node::{
     core::{
         channels::mpsc,
diff --git a/node/src/ledger/ledger_service.rs b/node/src/ledger/ledger_service.rs
@@ -24,7 +24,6 @@ use crate::{
         },
     },
 };
-use ark_ff::fields::arithmetic::InvalidBigInt;
 use ledger::{
     scan_state::{
         currency::Slot,
@@ -56,6 +55,7 @@ use mina_core::{
 };
 use mina_curves::pasta::Fp;
 use mina_p2p_messages::{
+    bigint::InvalidBigInt,
     binprot::BinProtRead,
     list::List,
     v2::{
diff --git a/node/src/ledger/mod.rs b/node/src/ledger/mod.rs
@@ -2,8 +2,8 @@ pub mod read;
 pub mod write;
 
 mod ledger_config;
-use ark_ff::fields::arithmetic::InvalidBigInt;
 pub use ledger_config::*;
+use mina_p2p_messages::bigint::InvalidBigInt;
 
 mod ledger_event;
 pub use ledger_event::*;
diff --git a/node/src/p2p/callbacks/p2p_callbacks_reducer.rs b/node/src/p2p/callbacks/p2p_callbacks_reducer.rs
diff --git a/node/src/rpc/mod.rs b/node/src/rpc/mod.rs
diff --git a/node/src/transition_frontier/genesis/transition_frontier_genesis_config.rs b/node/src/transition_frontier/genesis/transition_frontier_genesis_config.rs
diff --git a/node/src/transition_frontier/sync/ledger/staged/mod.rs b/node/src/transition_frontier/sync/ledger/staged/mod.rs
diff --git a/node/src/watched_accounts/mod.rs b/node/src/watched_accounts/mod.rs
diff --git a/snark/src/merkle_path/mod.rs b/snark/src/merkle_path/mod.rs
