fix(p2p): improve code style

Author: vlad9486

p2p/src/network/noise/p2p_network_noise_state.rs

@@ -127,7 +127,8 @@ impl NoiseState {
         let hkdf = Hkdf::<Sha256, Hmac<Sha256>>::new(Some(&self.chaining_key.0), &secret);
         secret.zeroize();
         let mut okm = [0; 64];
-        hkdf.expand(&[], &mut okm).unwrap();
+        hkdf.expand(&[], &mut okm)
+            .expect("the length is constant and small");
         self.chaining_key.0.clone_from_slice(&okm[..32]);
         self.aead_key.0.clone_from_slice(&okm[32..]);
     }
@@ -154,7 +155,7 @@ impl NoiseState {
 
         let tag = ChaCha20Poly1305::new(GenericArray::from_slice(&self.aead_key.0))
             .encrypt_in_place_detached(&nonce, &self.hash.0, data)
-            .unwrap();
+            .expect("data length must be sufficiently small");
         let hash = Sha256::default()
             .chain(self.hash.0)
             .chain(&*data)
@@ -171,7 +172,8 @@ impl NoiseState {
 
         let hkdf = Hkdf::<Sha256, Hmac<Sha256>>::new(Some(&self.chaining_key.0), b"");
         let mut okm = [0; 64];
-        hkdf.expand(&[], &mut okm).unwrap();
+        hkdf.expand(&[], &mut okm)
+            .expect("the length is constant and small");
         fst.clone_from_slice(&okm[..32]);
         scd.clone_from_slice(&okm[32..]);
         (DataSized(fst), DataSized(scd))

p2p/src/network/pubsub/p2p_network_pubsub_effects.rs

@@ -114,9 +114,13 @@ impl P2pNetworkPubsubAction {
             P2pNetworkPubsubAction::Sign { .. } => {
                 if let Some(to_sign) = state.to_sign.front() {
                     let mut publication = vec![];
-                    prost::Message::encode(to_sign, &mut publication).unwrap();
-                    let signature = store.service().sign_publication(&publication).into();
-                    store.dispatch(P2pNetworkPubsubAction::BroadcastSigned { signature });
+                    if let Err(err) = prost::Message::encode(to_sign, &mut publication) {
+                        // TODO: dispatch action for logging
+                        let _ = err;
+                    } else {
+                        let signature = store.service().sign_publication(&publication).into();
+                        store.dispatch(P2pNetworkPubsubAction::BroadcastSigned { signature });
+                    }
                 }
             }
             P2pNetworkPubsubAction::BroadcastSigned { .. } => broadcast(store),
@@ -179,7 +183,10 @@ impl P2pNetworkPubsubAction {
                     //     println!("{}", std::str::from_utf8(&id).unwrap());
                     // }
                     let mut data = vec![];
-                    if prost::Message::encode_length_delimited(&msg, &mut data).is_ok() {
+                    if let Err(err) = prost::Message::encode_length_delimited(&msg, &mut data) {
+                        // TODO: dispatch action for logging
+                        let _ = err;
+                    } else {
                         store.dispatch(P2pNetworkPubsubAction::OutgoingData {
                             data: data.clone().into(),
                             peer_id,