tmp(node): reject all incoming zkapps till we can verify their proof outside state machine

Author: binier

node/src/state.rs

@@ -3,7 +3,7 @@ use std::time::Duration;
 
 use mina_p2p_messages::v2;
 use openmina_core::constants::PROTOCOL_VERSION;
-use openmina_core::transaction::{TransactionInfo, TransactionWithHash};
+use openmina_core::transaction::{Transaction, TransactionInfo, TransactionWithHash};
 use rand::prelude::*;
 
 use openmina_core::block::BlockWithHash;
@@ -534,7 +534,10 @@ impl P2p {
             on_p2p_channels_transaction_libp2p_received: Some(redux::callback!(
                 on_p2p_channels_transaction_libp2p_received(transaction: Box<TransactionWithHash>) -> crate::Action {
                     TransactionPoolAction::StartVerify {
-                        commands: std::iter::once(*transaction).collect(),
+                        commands: std::iter::once(*transaction)
+                            // TODO(SEC): remove once proof verification is done outside state machine.
+                            .filter(|v| !matches!(v.body(), Transaction::ZkappCommand(_)))
+                            .collect(),
                         from_rpc: None
                     }
                 }

node/src/transaction_pool/transaction_pool_actions.rs

@@ -78,9 +78,12 @@ impl redux::EnablingCondition<crate::State> for TransactionPoolAction {
     fn is_enabled(&self, state: &crate::State, time: redux::Timestamp) -> bool {
         match self {
             TransactionPoolAction::Candidate(a) => a.is_enabled(state, time),
-            TransactionPoolAction::StartVerify { commands, .. } => commands
-                .iter()
-                .any(|cmd| !state.transaction_pool.contains(cmd.hash())),
+            TransactionPoolAction::StartVerify { commands, .. } => {
+                !commands.is_empty()
+                    && commands
+                        .iter()
+                        .any(|cmd| !state.transaction_pool.contains(cmd.hash()))
+            }
             TransactionPoolAction::P2pSendAll => true,
             TransactionPoolAction::P2pSend { peer_id } => state
                 .p2p