Add test verifying zkapps

Author: sebastiencs

ledger/src/proofs/transaction.rs

@@ -4181,7 +4181,7 @@ mod tests_with_wasm {
 }
 
 #[cfg(test)]
-mod tests {
+pub(super) mod tests {
     use std::path::Path;
 
     use mina_p2p_messages::binprot::{
@@ -4215,7 +4215,7 @@ mod tests {
         PerformJob(mina_p2p_messages::v2::SnarkWorkerWorkerRpcsVersionedGetWorkV2TResponse),
     }
 
-    fn panic_in_ci() {
+    pub fn panic_in_ci() {
         fn is_ci() -> bool {
             std::env::var("CI").is_ok()
         }

ledger/src/proofs/util.rs

@@ -287,6 +287,7 @@ pub fn proof_evaluation_to_absorption_sequence<F: FieldWitness>(
         .filter_map(|v| v.as_ref()),
     );
 
+    #[allow(clippy::iter_cloned_collect)]
     list.iter().cloned().collect()
 }
 

ledger/src/proofs/verification.rs

@@ -760,6 +760,7 @@ pub fn verify_zkapp(
 
     eprintln!("verify_zkapp OK={:?}", ok);
 
+    #[cfg(not(test))]
     if !ok {
         if let Err(e) = dump_zkapp_verification(verification_key, zkapp_statement, sideloaded_proof)
         {
@@ -868,9 +869,13 @@ fn generate_new_filename(name: &str, extension: &str, data: &[u8]) -> std::io::R
 
 #[cfg(test)]
 mod tests {
+    use std::path::Path;
+
     use mina_hasher::Fp;
     use mina_p2p_messages::{binprot::BinProtRead, v2};
 
+    use crate::proofs::{provers::devnet_circuit_directory, transaction::tests::panic_in_ci};
+
     use super::*;
 
     #[cfg(target_family = "wasm")]
@@ -888,22 +893,36 @@ mod tests {
             proof: v2::PicklesProofProofsVerified2ReprStableV2,
         }
 
-        let Ok(file) = std::fs::read("/tmp/verify_zapp_4af39d1e141859c964fe32b4e80537d3bd8c32d75e2754c0b869738006d25251_0.binprot") else {
-            eprintln!("not found");
-            return;
-        };
+        let base_dir = Path::new(env!("CARGO_MANIFEST_DIR"))
+            .join(devnet_circuit_directory())
+            .join("tests");
+
+        let cases = [
+            "verify_zapp_4af39d1e141859c964fe32b4e80537d3bd8c32d75e2754c0b869738006d25251_0.binprot",
+            "verify_zapp_dc518dc7e0859ea6ffa0cd42637cdcc9c79ab369dfb7ff44c8a89b1219f98728_0.binprot",
+            "verify_zapp_9db7255327f342f75d27b5c0f646988ee68c6338f6e26c4dc549675f811b4152_0.binprot",
+            "verify_zapp_f2bbc8088654c09314a58c96428f6828d3ee8096b6f34e3a027ad9b028ae22e0_0.binprot",
+        ];
+
+        for filename in cases {
+            let Ok(file) = std::fs::read(base_dir.join(filename)) else {
+                panic_in_ci();
+                return;
+            };
 
-        let VerifyZkapp {
-            vk,
-            zkapp_statement,
-            proof,
-        } = VerifyZkapp::binprot_read(&mut file.as_slice()).unwrap();
+            let VerifyZkapp {
+                vk,
+                zkapp_statement,
+                proof,
+            } = VerifyZkapp::binprot_read(&mut file.as_slice()).unwrap();
 
-        let vk = (&vk).try_into().unwrap();
-        let zkapp_statement = (&zkapp_statement).try_into().unwrap();
-        let srs = crate::verifier::get_srs::<Fp>();
+            let vk = (&vk).try_into().unwrap();
+            let zkapp_statement = (&zkapp_statement).try_into().unwrap();
+            let srs = crate::verifier::get_srs::<Fp>();
 
-        verify_zkapp(&vk, &zkapp_statement, &proof, &*srs);
+            let ok = verify_zkapp(&vk, &zkapp_statement, &proof, &srs);
+            assert!(ok);
+        }
     }
 
     // #[test]