tweak(p2p): Abstract temporary state clearing into methods

Author: tizoc

p2p/src/network/pubsub/p2p_network_pubsub_reducer.rs

@@ -214,22 +214,16 @@ impl P2pNetworkPubsubState {
                 Ok(())
             }
             P2pNetworkPubsubAction::IncomingMessageCleanup { peer_id } => {
-                pubsub_state.incoming_transactions.clear();
-                pubsub_state.incoming_snarks.clear();
-
-                pubsub_state.incoming_transactions.shrink_to(0x20);
-                pubsub_state.incoming_snarks.shrink_to(0x20);
-
-                pubsub_state.incoming_block = None;
+                pubsub_state.clear_incoming();
 
                 let Some(client_state) = pubsub_state.clients.get_mut(&peer_id) else {
                     bug_condition!(
                         "State not found for action P2pNetworkPubsubAction::IncomingMessageCleanup"
                     );
                     return Ok(());
                 };
-                client_state.incoming_messages.clear();
-                client_state.incoming_messages.shrink_to(0x20);
+
+                client_state.clear_incoming();
 
                 Ok(())
             }

p2p/src/network/pubsub/p2p_network_pubsub_state.rs

@@ -116,6 +116,16 @@ impl P2pNetworkPubsubState {
             }
         }
     }
+
+    pub fn clear_incoming(&mut self) {
+        self.incoming_transactions.clear();
+        self.incoming_snarks.clear();
+
+        self.incoming_transactions.shrink_to(0x20);
+        self.incoming_snarks.shrink_to(0x20);
+
+        self.incoming_block = None;
+    }
 }
 
 /// State of a pubsub client connected to a peer.
@@ -181,6 +191,11 @@ impl P2pNetworkPubsubClientState {
         self.buffer.clear();
         self.buffer.shrink_to(0x2000);
     }
+
+    pub fn clear_incoming(&mut self) {
+        self.incoming_messages.clear();
+        self.incoming_messages.shrink_to(0x20)
+    }
 }
 
 #[derive(Default, Serialize, Deserialize, Debug, Clone)]