CI: fix shellcheck issues in bash scripts

Replace exit code checking pattern from '\! cmd' to using variables for
better code clarity. Wrap long command lines at 80 characters and ensure
proper variable quoting to comply with shellcheck recommendations.

- Use curl_exit_code, sed_exit_code, tar_exit_code variables
- Fix SC2181 violations by avoiding $? checks
- Fix SC2086 violations by adding quotes around variables
- Improve readability with proper line wrapping

Author: dannywillems

frontend/docker/startup.sh

@@ -10,12 +10,13 @@ replace_signaling_url() {
         echo "Replacing signaling URL in $HTTPD_CONF..."
 
         sed -i "s|$SIGNALING_URL|$OPENMINA_SIGNALING_URL|g" "$HTTPD_CONF"
-
-        if [[ $? -ne 0 ]]; then
+        sed_exit_code=$?
+        if [[ $sed_exit_code -ne 0 ]]; then
             echo "Failed to replace the signaling URL, exiting."
             exit 1
         else
-            echo "Successfully replaced signaling URL with '$OPENMINA_SIGNALING_URL' in $HTTPD_CONF"
+            echo "Successfully replaced signaling URL with" \
+                "'$OPENMINA_SIGNALING_URL' in $HTTPD_CONF"
         fi
     else
         echo "OPENMINA_SIGNALING_URL is not set. No replacement performed."
@@ -63,8 +64,11 @@ download_circuit_files() {
             echo "$FILE already exists in $DOWNLOAD_DIR, skipping download."
         else
             echo "Downloading $FILE to $DOWNLOAD_DIR..."
-            curl -s -L --retry 3 --retry-delay 5 -o "$DOWNLOAD_DIR/$FILE" "$CIRCUITS_BASE_URL/$CIRCUITS_VERSION/$FILE"
-            if [[ $? -ne 0 ]]; then
+            curl -s -L --retry 3 --retry-delay 5 \
+                -o "$DOWNLOAD_DIR/$FILE" \
+                "$CIRCUITS_BASE_URL/$CIRCUITS_VERSION/$FILE"
+            curl_exit_code=$?
+            if [[ $curl_exit_code -ne 0 ]]; then
                 echo "Failed to download $FILE after 3 attempts, exiting."
                 exit 1
             else
@@ -80,24 +84,28 @@ download_wasm_files() {
         exit 1
     fi
 
-    WASM_URL="$OPENMINA_BASE_URL/openmina/releases/download/$OPENMINA_WASM_VERSION/openmina-$OPENMINA_WASM_VERSION-webnode-wasm.tar.gz"
+    WASM_URL="$OPENMINA_BASE_URL/openmina/releases/download/\
+$OPENMINA_WASM_VERSION/openmina-$OPENMINA_WASM_VERSION-webnode-wasm.tar.gz"
     TARGET_DIR="/usr/local/apache2/htdocs/assets/webnode/pkg"
 
     mkdir -p "$TARGET_DIR"
 
     echo "Downloading WASM files from $WASM_URL..."
-    curl -s -L --retry 3 --retry-delay 5 -o "/tmp/openmina-$OPENMINA_WASM_VERSION-webnode-wasm.tar.gz" "$WASM_URL"
-
-    if [[ $? -ne 0 ]]; then
+    curl -s -L --retry 3 --retry-delay 5 \
+        -o "/tmp/openmina-$OPENMINA_WASM_VERSION-webnode-wasm.tar.gz" \
+        "$WASM_URL"
+    curl_exit_code=$?
+    if [[ $curl_exit_code -ne 0 ]]; then
         echo "Failed to download the WASM file after 3 attempts, exiting."
         exit 1
     else
         echo "WASM file downloaded successfully. Extracting to $TARGET_DIR..."
 
-        tar -xzf "/tmp/openmina-$OPENMINA_WASM_VERSION-webnode-wasm.tar.gz" -C "$TARGET_DIR"
-
         # Check if the extraction was successful
-        if [[ $? -ne 0 ]]; then
+        tar -xzf "/tmp/openmina-$OPENMINA_WASM_VERSION-webnode-wasm.tar.gz" \
+            -C "$TARGET_DIR"
+        tar_exit_code=$?
+        if [[ $tar_exit_code -ne 0 ]]; then
             echo "Failed to extract the WASM file, exiting."
             exit 1
         else

frontend/scripts/download-webnode.sh

@@ -45,8 +45,11 @@ download_circuit_files() {
             echo "$FILE already exists in $DOWNLOAD_DIR, skipping download."
         else
             echo "Downloading $FILE to $DOWNLOAD_DIR..."
-            curl -s -L --retry 3 --retry-delay 5 -o "$DOWNLOAD_DIR/$FILE" "$CIRCUITS_BASE_URL/$CIRCUITS_VERSION/$FILE"
-            if [[ $? -ne 0 ]]; then
+            curl -s -L --retry 3 --retry-delay 5 \
+                -o "$DOWNLOAD_DIR/$FILE" \
+                "$CIRCUITS_BASE_URL/$CIRCUITS_VERSION/$FILE"
+            curl_exit_code=$?
+            if [[ $curl_exit_code -ne 0 ]]; then
                 echo "Failed to download $FILE after 3 attempts, exiting."
                 exit 1
             else

producer-dashboard/docker/init-db/init-db.sh

@@ -10,12 +10,12 @@ PASSWORD=${POSTGRES_PASSWORD}
 
 # Wait for PostgreSQL to become available
 echo "Waiting for postgres..."
-while ! pg_isready -h $HOST -p $PORT -U $USER; do
+while ! pg_isready -h "$HOST" -p "$PORT" -U "$USER"; do
   sleep 2;
 done
 
 # Check if the database exists, and create it if it doesn't
-if ! PGPASSWORD=$PASSWORD psql -h $HOST -U $USER -lqt | cut -d \| -f 1 | grep -qw $DB; then
+if ! PGPASSWORD=$PASSWORD psql -h "$HOST" -U "$USER" -lqt | cut -d \| -f 1 | grep -qw "$DB"; then
   echo "Database $DB does not exist. Creating..."
   PGPASSWORD="$PASSWORD" createdb -h "$HOST" -U "$USER" "$DB"
   # Load the schema into the database
@@ -24,7 +24,7 @@ if ! PGPASSWORD=$PASSWORD psql -h $HOST -U $USER -lqt | cut -d \| -f 1 | grep -q
   # PGPASSWORD=$PASSWORD psql -h $HOST -U $USER -d $DB < create_schema.sql
   # TODO
   cd /dumps
-  PGPASSWORD=$PASSWORD psql -h $HOST -U $USER -d $DB < dump.sql
+  PGPASSWORD=$PASSWORD psql -h "$HOST" -U "$USER" -d "$DB" < dump.sql
   exit 1
 else
   echo "Database $DB already exists."