Wallet e2e tests: use environment variable for endpoint

Author: dannywillems

.github/scripts/wallet/test-balance-from-key.sh

@@ -1,9 +1,17 @@
 #!/bin/bash
 
-set -euo pipefail
-
 # Test the wallet balance command with --from key file (text format)
 
+# Check for required environment variables before enabling strict mode
+if [ -z "${MINA_NODE_ENDPOINT:-}" ]; then
+    echo "Error: MINA_NODE_ENDPOINT environment variable is not set"
+    echo "Please set it to a GraphQL endpoint URL, e.g.:"
+    echo "  export MINA_NODE_ENDPOINT=http://mina-rust-plain-1.gcp.o1test.net/graphql"
+    exit 1
+fi
+
+set -euo pipefail
+
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_ROOT="$(cd "$SCRIPT_DIR/../../.." && pwd)"
 cd "$REPO_ROOT"
@@ -14,7 +22,7 @@ PASSWORD="test-password"
 
 echo "Test: Verify --from option works with key file (text format)"
 export MINA_PRIVKEY_PASS="$PASSWORD"
-BALANCE_OUTPUT=$(./target/release/mina wallet balance --from "$KEY_FILE" --endpoint "http://mina-rust-plain-1.gcp.o1test.net/graphql" --format text 2>&1 || true)
+BALANCE_OUTPUT=$(./target/release/mina wallet balance --from "$KEY_FILE" --endpoint "$MINA_NODE_ENDPOINT" --format text 2>&1 || true)
 
 echo "Balance command output:"
 echo "$BALANCE_OUTPUT"

.github/scripts/wallet/test-balance-json-format.sh

@@ -1,9 +1,17 @@
 #!/bin/bash
 
-set -euo pipefail
-
 # Test the wallet balance command JSON format output structure
 
+# Check for required environment variables before enabling strict mode
+if [ -z "${MINA_NODE_ENDPOINT:-}" ]; then
+    echo "Error: MINA_NODE_ENDPOINT environment variable is not set"
+    echo "Please set it to a GraphQL endpoint URL, e.g.:"
+    echo "  export MINA_NODE_ENDPOINT=http://mina-rust-plain-1.gcp.o1test.net/graphql"
+    exit 1
+fi
+
+set -euo pipefail
+
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_ROOT="$(cd "$SCRIPT_DIR/../../.." && pwd)"
 cd "$REPO_ROOT"
@@ -18,7 +26,7 @@ fi
 echo "Test: Verify JSON format output structure"
 JSON_OUTPUT=$(./target/release/mina wallet balance \
     --address "B62qkiqPXFDayJV8JutYvjerERZ35EKrdmdcXh3j1rDUHRs1bJkFFcX" \
-    --endpoint "http://mina-rust-plain-1.gcp.o1test.net/graphql" \
+    --endpoint "$MINA_NODE_ENDPOINT" \
     --format json 2>&1 || true)
 
 echo "JSON format output:"

.github/scripts/wallet/test-balance-json.sh

@@ -1,9 +1,17 @@
 #!/bin/bash
 
-set -euo pipefail
-
 # Test the wallet balance command with --address (JSON format)
 
+# Check for required environment variables before enabling strict mode
+if [ -z "${MINA_NODE_ENDPOINT:-}" ]; then
+    echo "Error: MINA_NODE_ENDPOINT environment variable is not set"
+    echo "Please set it to a GraphQL endpoint URL, e.g.:"
+    echo "  export MINA_NODE_ENDPOINT=http://mina-rust-plain-1.gcp.o1test.net/graphql"
+    exit 1
+fi
+
+set -euo pipefail
+
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_ROOT="$(cd "$SCRIPT_DIR/../../.." && pwd)"
 cd "$REPO_ROOT"
@@ -19,7 +27,7 @@ fi
 PUBLIC_KEY=$(cat "tests/files/accounts/test-block-producer.pub")
 
 echo "Test: Verify --address option works with public key (JSON format)"
-BALANCE_JSON=$(./target/release/mina wallet balance --address "$PUBLIC_KEY" --endpoint "http://mina-rust-plain-1.gcp.o1test.net/graphql" --format json 2>&1 || true)
+BALANCE_JSON=$(./target/release/mina wallet balance --address "$PUBLIC_KEY" --endpoint "$MINA_NODE_ENDPOINT" --format json 2>&1 || true)
 
 echo "Balance command output:"
 echo "$BALANCE_JSON"

.github/scripts/wallet/test-balance-no-account.sh

@@ -1,15 +1,23 @@
 #!/bin/bash
 
-set -euo pipefail
-
 # Test the wallet balance command error when no account specified
 
+# Check for required environment variables before enabling strict mode
+if [ -z "${MINA_NODE_ENDPOINT:-}" ]; then
+    echo "Error: MINA_NODE_ENDPOINT environment variable is not set"
+    echo "Please set it to a GraphQL endpoint URL, e.g.:"
+    echo "  export MINA_NODE_ENDPOINT=http://mina-rust-plain-1.gcp.o1test.net/graphql"
+    exit 1
+fi
+
+set -euo pipefail
+
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_ROOT="$(cd "$SCRIPT_DIR/../../.." && pwd)"
 cd "$REPO_ROOT"
 
 echo "Test: Verify error when no account specified"
-ERROR_OUTPUT=$(./target/release/mina wallet balance --endpoint "http://mina-rust-plain-1.gcp.o1test.net/graphql" 2>&1 || true)
+ERROR_OUTPUT=$(./target/release/mina wallet balance --endpoint "$MINA_NODE_ENDPOINT" 2>&1 || true)
 
 echo "Command output:"
 echo "$ERROR_OUTPUT"

.github/scripts/wallet/test-balance-text-format.sh

@@ -1,17 +1,25 @@
 #!/bin/bash
 
-set -euo pipefail
-
 # Test the wallet balance command text format output structure
 
+# Check for required environment variables before enabling strict mode
+if [ -z "${MINA_NODE_ENDPOINT:-}" ]; then
+    echo "Error: MINA_NODE_ENDPOINT environment variable is not set"
+    echo "Please set it to a GraphQL endpoint URL, e.g.:"
+    echo "  export MINA_NODE_ENDPOINT=http://mina-rust-plain-1.gcp.o1test.net/graphql"
+    exit 1
+fi
+
+set -euo pipefail
+
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_ROOT="$(cd "$SCRIPT_DIR/../../.." && pwd)"
 cd "$REPO_ROOT"
 
 echo "Test: Verify text format output structure"
 TEXT_OUTPUT=$(./target/release/mina wallet balance \
     --address "B62qkiqPXFDayJV8JutYvjerERZ35EKrdmdcXh3j1rDUHRs1bJkFFcX" \
-    --endpoint "http://mina-rust-plain-1.gcp.o1test.net/graphql" \
+    --endpoint "$MINA_NODE_ENDPOINT" \
     --format text 2>&1 || true)
 
 echo "Text format output:"

.github/scripts/wallet/test-send.sh

@@ -1,18 +1,26 @@
 #!/bin/bash
 
-set -euo pipefail
-
 # Test the wallet send command by sending a transaction to the same account
 # Uses a very small fee to avoid draining the account on each PR
 
+# Check for required environment variables before enabling strict mode
+if [ -z "${MINA_NODE_ENDPOINT:-}" ]; then
+    echo "Error: MINA_NODE_ENDPOINT environment variable is not set"
+    echo "Please set it to a GraphQL endpoint URL, e.g.:"
+    echo "  export MINA_NODE_ENDPOINT=http://mina-rust-plain-1.gcp.o1test.net/graphql"
+    exit 1
+fi
+
+set -euo pipefail
+
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_ROOT="$(cd "$SCRIPT_DIR/../../.." && pwd)"
 cd "$REPO_ROOT"
 
 # Define test parameters
 KEY_FILE="tests/files/accounts/test-wallet"
 PUBKEY_FILE="tests/files/accounts/test-wallet.pub"
-NODE_ENDPOINT="${MINA_NODE_ENDPOINT:-http://mina-rust-plain-1.gcp.o1test.net/graphql}"
+NODE_ENDPOINT="$MINA_NODE_ENDPOINT"
 
 # Password from environment variable (set in GitHub secrets)
 # Default to "test" for local testing

.github/workflows/tests.yaml

@@ -264,6 +264,7 @@ jobs:
       - name: Run wallet tests
         env:
           MINA_PRIVKEY_PASS: ${{ secrets.MINA_PRIVKEY_PASS }}
+          MINA_NODE_ENDPOINT: http://mina-rust-plain-1.gcp.o1test.net/graphql
         run: make test-wallet
 
   build-tests: