CI updates

Author: 0xMimir

.github/actions/setup-build-deps/action.yml

@@ -27,7 +27,7 @@ runs:
       if: runner.os == 'macOS'
       shell: bash
       run: |
-        brew install protobuf
+        brew install protobuf ocaml opam
 
     - name: Install cargo-nextest
       if: inputs.install-nextest == 'true'

.github/workflows/ci.yaml

@@ -1,13 +1,13 @@
 name: Openmina CI
 on:
   push:
-    branches: [ main, develop ]
+    branches: [main, develop]
   pull_request:
-    paths-ignore: [ "frontend" ]
+    paths-ignore: ["frontend"]
   workflow_dispatch:
     inputs:
       refresh_cache:
-        description: 'Refresh cargo cache'
+        description: "Refresh cargo cache"
         required: false
         type: boolean
         default: false
@@ -18,6 +18,7 @@ env:
   OPENMINA_PANIC_ON_BUG: true
   CARGO_INCREMENTAL: 1
   RUSTFLAGS: "-C overflow-checks=off -C debug-assertions=off"
+  OCAML_VERSION: "4.14.2"
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
@@ -140,7 +141,7 @@ jobs:
     # NOTE: If you add or remove platforms from this matrix, make sure to update
     # the documentation at website/docs/developers/getting-started.mdx
     strategy:
-      fail-fast: false  # Allow other platforms to continue if one fails
+      fail-fast: false # Allow other platforms to continue if one fails
       matrix:
         os: [ubuntu-22.04, ubuntu-24.04, ubuntu-24.04-arm, macos-latest]
     runs-on: ${{ matrix.os }}
@@ -151,6 +152,11 @@ jobs:
       - name: Setup build dependencies
         uses: ./.github/actions/setup-build-deps
 
+      - name: Use shared OCaml setting up steps
+        uses: ./.github/actions/setup-ocaml
+        with:
+          ocaml_version: ${{ OCAML_VERSION }}
+
       - name: Setup Rust
         uses: ./.github/actions/setup-rust
         with:
@@ -173,7 +179,7 @@ jobs:
     # NOTE: If you add or remove platforms from this matrix, make sure to update
     # the documentation at website/docs/developers/getting-started.mdx
     strategy:
-      fail-fast: false  # Allow other platforms to continue if one fails
+      fail-fast: false # Allow other platforms to continue if one fails
       matrix:
         os: [ubuntu-22.04, ubuntu-24.04, ubuntu-24.04-arm, macos-latest]
     runs-on: ${{ matrix.os }}
@@ -184,6 +190,11 @@ jobs:
       - name: Setup build dependencies
         uses: ./.github/actions/setup-build-deps
 
+      - name: Use shared OCaml setting up steps
+        uses: ./.github/actions/setup-ocaml
+        with:
+          ocaml_version: ${{ OCAML_VERSION }}
+
       - name: Setup WebAssembly environment
         uses: ./.github/actions/setup-wasm
         with:
@@ -197,7 +208,7 @@ jobs:
     # NOTE: If you add or remove platforms from this matrix, make sure to update
     # the documentation at website/docs/developers/getting-started.mdx
     strategy:
-      fail-fast: false  # Allow other platforms to continue if one fails
+      fail-fast: false # Allow other platforms to continue if one fails
       matrix:
         os: [ubuntu-22.04, ubuntu-24.04, ubuntu-24.04-arm, macos-latest]
     runs-on: ${{ matrix.os }}
@@ -208,6 +219,11 @@ jobs:
       - name: Setup build dependencies
         uses: ./.github/actions/setup-build-deps
 
+      - name: Use shared OCaml setting up steps
+        uses: ./.github/actions/setup-ocaml
+        with:
+          ocaml_version: ${{ OCAML_VERSION }}
+
       - name: Setup Rust
         uses: ./.github/actions/setup-rust
         with:
@@ -230,7 +246,7 @@ jobs:
     # NOTE: If you add or remove platforms from this matrix, make sure to update
     # the documentation at website/docs/developers/getting-started.mdx
     strategy:
-      fail-fast: false  # Allow other platforms to continue if one fails
+      fail-fast: false # Allow other platforms to continue if one fails
       matrix:
         os: [ubuntu-22.04, ubuntu-24.04, ubuntu-24.04-arm, macos-latest]
     runs-on: ${{ matrix.os }}
@@ -241,6 +257,11 @@ jobs:
       - name: Setup build dependencies
         uses: ./.github/actions/setup-build-deps
 
+      - name: Use shared OCaml setting up steps
+        uses: ./.github/actions/ocaml-shared
+        with:
+          ocaml_version: ${{ OCAML_VERSION }}
+
       - name: Setup Rust
         uses: ./.github/actions/setup-rust
         with:
@@ -259,7 +280,7 @@ jobs:
           retention-days: 7
 
   p2p-scenario-tests:
-    needs: [ build-tests, build-tests-webrtc ]
+    needs: [build-tests, build-tests-webrtc]
     runs-on: ubuntu-24.04
     timeout-minutes: 20
     container:
@@ -269,8 +290,15 @@ jobs:
       BPF_ALIAS: /coda/0.0.1/29936104443aaf264a7f0192ac64b1c7173198c1ed404c1bcff5e562e05eb7f6-0.0.0.0
     strategy:
       matrix:
-        test: [p2p_basic_connections, p2p_basic_incoming, p2p_basic_outgoing, p2p_pubsub, p2p_kad,
-               webrtc_p2p_basic_connections]
+        test:
+          [
+            p2p_basic_connections,
+            p2p_basic_incoming,
+            p2p_basic_outgoing,
+            p2p_pubsub,
+            p2p_kad,
+            webrtc_p2p_basic_connections,
+          ]
       fail-fast: false
 
     services:
@@ -288,10 +316,10 @@ jobs:
     steps:
       - name: Install libssl3t64 # Our binaries are built on a newer ubuntu and require libssl3t64
         run: |
-           apt-get update && \
-              apt-get install -y --no-install-recommends libssl3t64 && \
-              apt-get clean && \
-              rm -rf /var/lib/apt/lists/*
+          apt-get update && \
+             apt-get install -y --no-install-recommends libssl3t64 && \
+             apt-get clean && \
+             rm -rf /var/lib/apt/lists/*
 
       - name: Download tests
         uses: actions/download-artifact@v4
@@ -369,10 +397,10 @@ jobs:
     steps:
       - name: Install libssl3t64 # Our binaries are built on a newer ubuntu and require libssl3t64
         run: |
-           apt-get update && \
-              apt-get install -y --no-install-recommends libssl3t64 && \
-              apt-get clean && \
-              rm -rf /var/lib/apt/lists/*
+          apt-get update && \
+             apt-get install -y --no-install-recommends libssl3t64 && \
+             apt-get clean && \
+             rm -rf /var/lib/apt/lists/*
 
       - name: Download tests
         uses: actions/download-artifact@v4
@@ -426,10 +454,10 @@ jobs:
     steps:
       - name: Install libssl3t64 # Our binaries are built on a newer ubuntu and require libssl3t64
         run: |
-           apt-get update && \
-              apt-get install -y --no-install-recommends libssl3t64 && \
-              apt-get clean && \
-              rm -rf /var/lib/apt/lists/*
+          apt-get update && \
+             apt-get install -y --no-install-recommends libssl3t64 && \
+             apt-get clean && \
+             rm -rf /var/lib/apt/lists/*
 
       - name: Download tests
         uses: actions/download-artifact@v4
@@ -447,7 +475,7 @@ jobs:
 
   bootstrap-test:
     timeout-minutes: 4
-    needs: [ build, build-tests ]
+    needs: [build, build-tests]
     runs-on: ubuntu-24.04
     env:
       OPENMINA_HOME: data

.github/workflows/docs.yaml

@@ -35,7 +35,7 @@ jobs:
       - name: Setup build dependencies
         run: |
           sudo apt update
-          sudo apt install -y protobuf-compiler
+          sudo apt install -y protobuf-compiler ocaml
 
       - name: Install documentation dependencies
         run: make docs-install

Dockerfile

@@ -1,7 +1,7 @@
 FROM rust:bullseye AS build
 # hadolint ignore=DL3008
 RUN apt-get update && \
-    apt-get install -y --no-install-recommends protobuf-compiler && \
+    apt-get install -y --no-install-recommends protobuf-compiler ocaml && \
     apt-get clean
 
 WORKDIR /openmina

tools/fuzzing/src/transaction_fuzzer/generator.rs

@@ -1,4 +1,4 @@
-use ark_ec::{AffineCurve, ProjectiveCurve};
+use ark_ec::{AffineRepr, CurveGroup};
 use ark_ff::{Field, UniformRand};
 use ledger::{
     generators::zkapp_command_builder::get_transaction_commitments,
@@ -69,7 +69,11 @@ use mina_signer::{
     CompressedPubKey, CurvePoint, Keypair, NetworkId, ScalarField, SecKey, Signature, Signer,
 };
 use rand::{seq::SliceRandom, Rng};
-use std::{array, iter, ops::RangeInclusive, sync::Arc};
+use std::{
+    array, iter,
+    ops::{Mul, RangeInclusive},
+    sync::Arc,
+};
 use tuple_map::TupleMap2;
 
 use super::context::{FuzzerCtx, PermissionModel};
@@ -155,9 +159,7 @@ impl Generator<Keypair> for FuzzerCtx {
     fn gen(&mut self) -> Keypair {
         let sec_key: SecKey = self.gen();
         let scalar = sec_key.into_scalar();
-        let public: CurvePoint = CurvePoint::prime_subgroup_generator()
-            .mul(scalar)
-            .into_affine();
+        let public: CurvePoint = CurvePoint::generator().mul(scalar).into_affine();
 
         let keypair = Keypair::from_parts_unsafe(scalar, public);
 
@@ -223,10 +225,14 @@ impl<F: Field + From<i32>> Generator<CurvePointGenerator<F>> for FuzzerCtx {
 impl Generator<(Fp, Fp)> for FuzzerCtx {
     #[coverage(off)]
     fn gen(&mut self) -> (Fp, Fp) {
+        use std::ops::Mul;
         if let Some((x, y)) = self.state.cache_curve_point_fp {
-            let p = GroupAffine::<Fp>::new(x, y, false);
-            let rand_scalar: u64 = self.gen.rng.gen();
-            let new_p: GroupAffine<Fp> = p.mul(rand_scalar).into();
+            let p = GroupAffine::<Fp>::new(x, y);
+            let rand_scalar: u64 = self.r#gen.rng.gen();
+            let scalar_field_elem =
+                <Fp as ledger::proofs::field::FieldWitness>::Scalar::from(rand_scalar);
+
+            let new_p: GroupAffine<Fp> = p.mul(scalar_field_elem).into();
             (new_p.x, new_p.y)
         } else {
             let p: CurvePointGenerator<Fp> = self.gen();
@@ -240,9 +246,11 @@ impl Generator<(Fq, Fq)> for FuzzerCtx {
     #[coverage(off)]
     fn gen(&mut self) -> (Fq, Fq) {
         if let Some((x, y)) = self.state.cache_curve_point_fq {
-            let p = GroupAffine::<Fq>::new(x, y, false);
+            let p = GroupAffine::<Fq>::new(x, y);
             let rand_scalar: u64 = self.gen.rng.gen();
-            let new_p: GroupAffine<Fq> = p.mul(rand_scalar).into();
+            let scalar_field_elem =
+                <Fq as ledger::proofs::field::FieldWitness>::Scalar::from(rand_scalar);
+            let new_p: GroupAffine<Fq> = p.mul(scalar_field_elem).into();
             (new_p.x, new_p.y)
         } else {
             let p: CurvePointGenerator<Fq> = self.gen();