fix(node): add validation for block time

Author: binier

mina-p2p-messages/src/v2/manual.rs

@@ -1532,6 +1532,12 @@ impl From<OffsetDateTime> for BlockTimeTimeStableV1 {
     }
 }
 
+impl MinaBlockHeaderStableV2 {
+    pub fn genesis_state_hash(&self) -> &StateHash {
+        &self.protocol_state.body.genesis_state_hash
+    }
+}
+
 impl StagedLedgerDiffBodyStableV1 {
     pub fn diff(&self) -> &StagedLedgerDiffDiffDiffStableV2 {
         &self.staged_ledger_diff.diff

node/src/consensus/consensus_actions.rs

@@ -69,7 +69,9 @@ impl redux::EnablingCondition<crate::State> for ConsensusAction {
                     hash: hash.clone(),
                     block: block.clone()
                 };
-                !block.is_genesis() && !state.consensus.blocks.contains_key(hash)
+                !block.is_genesis()
+                    && !state.consensus.blocks.contains_key(hash)
+                    && state.prevalidate_block(&block)
             },
             ConsensusAction::BlockChainProofUpdate { hash, .. } => {
                 (state.consensus.best_tip.as_ref() == Some(hash)

node/src/p2p/peer/p2p_peer_actions.rs

@@ -2,6 +2,11 @@ use super::*;
 
 impl redux::EnablingCondition<crate::State> for P2pPeerAction {
     fn is_enabled(&self, state: &crate::State, time: redux::Timestamp) -> bool {
+        if let P2pPeerAction::BestTipUpdate { best_tip, .. } = self {
+            if !state.prevalidate_block(best_tip) {
+                return false;
+            }
+        }
         state.p2p.is_enabled(self, time)
     }
 }

node/src/state.rs

@@ -356,6 +356,44 @@ impl State {
         })
     }
 
+    pub fn prevalidate_block(&self, block: &ArcBlockWithHash) -> bool {
+        let Some((genesis, cur_global_slot)) =
+            None.or_else(|| Some((self.genesis_block()?, self.cur_global_slot()?)))
+        else {
+            // we don't have genesis block. This should be impossible
+            // because we don't even know chain_id before we have genesis
+            // block, so we can't be connected to any peers from which
+            // we would receive a block.
+            return false;
+        };
+
+        // received_at_valid_time
+        // https://github.com/minaprotocol/mina/blob/6af211ad58e9356f00ea4a636cea70aa8267c072/src/lib/consensus/proof_of_stake.ml#L2746
+        {
+            let block_global_slot = block.global_slot();
+
+            let delta = genesis.constants().delta.as_u32();
+            if cur_global_slot < block_global_slot {
+                // Too_early
+                return false;
+            } else if cur_global_slot.saturating_sub(block_global_slot) > delta {
+                // Too_late
+                return false;
+            }
+        }
+
+        if block.constants() != genesis.constants() {
+            return false;
+        }
+
+        if block.header().genesis_state_hash() != genesis.hash() {
+            return false;
+        }
+
+        // TODO(binier): more checks.
+        true
+    }
+
     pub fn should_log_node_id(&self) -> bool {
         self.config.testing_run
     }