Merge pull request #1101 from openmina/feat/dont-verify-transactions-when-producing

feat(pool-candidate): Don't proceed to verify transactions snarks when producing or applying a block

Author: tizoc

node/src/ledger/write/ledger_write_state.rs

@@ -39,6 +39,10 @@ impl LedgerWriteState {
         })
         .flatten()
     }
+
+    pub fn is_busy(&self) -> bool {
+        self.pending_requests().peekable().peek().is_some()
+    }
 }
 
 impl Default for LedgerWriteState {

node/src/transaction_pool/candidate/transaction_pool_candidate_actions.rs

@@ -113,8 +113,14 @@ impl redux::EnablingCondition<crate::State> for TransactionPoolCandidateAction {
                 .is_some(),
             TransactionPoolCandidateAction::Libp2pTransactionsReceived { .. } => true,
             TransactionPoolCandidateAction::VerifyNext => {
-                // TODO: if a block is being applied or produced, skip this action too
-                state.transition_frontier.sync.is_synced()
+                // Don't continue if we are producing a block, or we never synced yet
+                // or if the ledger service is busy.
+                !state.block_producer.is_producing()
+                    && state
+                        .transition_frontier
+                        .best_tip()
+                        .is_some_and(|b| !b.is_genesis())
+                    && !state.ledger.write.is_busy()
             }
             TransactionPoolCandidateAction::VerifyPending {
                 peer_id,

node/testing/src/node/rust/config.rs

@@ -99,6 +99,11 @@ impl RustNodeTestingConfig {
         self
     }
 
+    pub fn initial_time(mut self, time: redux::Timestamp) -> Self {
+        self.initial_time = time;
+        self
+    }
+
     pub fn with_peer_id(mut self, bytes: [u8; 32]) -> Self {
         self.peer_id = TestPeerId::Bytes(bytes);
         self

node/testing/src/scenarios/p2p/pubsub.rs

@@ -18,7 +18,9 @@ pub struct P2pReceiveMessage;
 
 impl P2pReceiveMessage {
     pub async fn run(self, mut runner: ClusterRunner<'_>) {
-        let config = RustNodeTestingConfig::devnet_default().initial_peers(hosts::devnet());
+        let config = RustNodeTestingConfig::devnet_default()
+            .initial_peers(hosts::devnet())
+            .initial_time(redux::Timestamp::global_now());
 
         let retransmitter_openmina_node = runner.add_rust_node(config);