Review fixes

Author: 0xMimir

ledger/src/proofs/transaction.rs

@@ -1310,6 +1310,7 @@ impl<F: FieldWitness> InnerCurve<F> {
     }
 }
 
+use poly_commitment::SRS;
 use std::cell::RefCell;
 
 thread_local! {
@@ -3902,8 +3903,7 @@ pub fn make_prover_index<C: ProofConstants, F: FieldWitness>(
     let srs: poly_commitment::ipa::SRS<F::OtherCurve> = {
         let srs = get_srs_mut::<F>();
         let srs = srs.lock().unwrap().clone();
-        // srs.add_lagrange_basis(cs.domain.d1);
-        // srs.with_lagrange_basis(cs.domain.d1);
+        srs.get_lagrange_basis(cs.domain.d1);
         srs
     };
 

ledger/src/proofs/verifiers.rs

@@ -22,7 +22,7 @@ use kimchi::{
     mina_curves::pasta::Pallas,
 };
 use mina_curves::pasta::{Fp, Fq};
-use poly_commitment::{ipa::SRS, lagrange_basis::WithLagrangeBasis, SRS as _};
+use poly_commitment::{ipa::SRS, SRS as _};
 
 use crate::{proofs::BACKEND_TOCK_ROUNDS_N, VerificationKey};
 
@@ -338,7 +338,7 @@ fn make_verifier_index(index: VerifierIndex<Fq>) -> VerifierIndex<Fq> {
     // <https://github.com/o1-labs/proof-systems/blob/2702b09063c7a48131173d78b6cf9408674fd67e/kimchi/src/verifier_index.rs#L310-L314>
     let srs = {
         let srs = SRS::create(max_poly_size);
-        srs.with_lagrange_basis(domain);
+        srs.get_lagrange_basis(domain);
         Arc::new(srs)
     };
 
@@ -397,7 +397,7 @@ pub fn make_zkapp_verifier_index(vk: &VerificationKey) -> VerifierIndex<Fq> {
     let srs = {
         let degree = 1 << BACKEND_TOCK_ROUNDS_N;
         let srs = SRS::<Pallas>::create(degree);
-        srs.with_lagrange_basis(domain);
+        srs.get_lagrange_basis(domain);
         srs
     };
 

ledger/src/proofs/wrap.rs

@@ -266,7 +266,6 @@ fn make_lagrange<F: FieldWitness>(
 
     let x_domain = EvaluationDomain::<F>::new(domain_size).expect("invalid argument");
 
-    // srs.with_lagrange_basis(x_domain);
 
     let lagrange_bases = srs.get_lagrange_basis(x_domain)[..domain_size].to_vec();
     // lagrange_bases[..domain_size].to_vec()
@@ -1826,8 +1825,6 @@ pub mod wrap_verifier {
             EvaluationDomain::<<F as crate::proofs::field::FieldWitness>::Scalar>::new(d)
                 .expect("invalid argument");
 
-        // srs.with_lagrange_basis(x_domain);
-
         let lagrange_bases = &srs.get_lagrange_basis(x_domain);
         lagrange_bases[i].clone()
     }