Review fixes

Author: 0xMimir

.github/workflows/tests.yaml

@@ -470,7 +470,7 @@ jobs:
   p2p-scenario-tests:
     needs: [build-tests, build-tests-webrtc]
     runs-on: ubuntu-24.04
-    timeout-minutes: 20
+    timeout-minutes: 30
     container:
       image: gcr.io/o1labs-192920/mina-daemon:3.3.0-alpha1-6929a7e-noble-devnet
       options: --volume debugger_data:/tmp/db
@@ -537,7 +537,7 @@ jobs:
         if: ${{ always() }}
 
   scenario-tests:
-    timeout-minutes: 180
+    timeout-minutes: 60
     needs:
       - build-tests
       - build-tests-webrtc
@@ -626,7 +626,7 @@ jobs:
         if: ${{ always() }}
 
   record-replay-tests:
-    timeout-minutes: 180
+    timeout-minutes: 70
     needs:
       - build-tests
       - build-tests-webrtc
@@ -639,10 +639,8 @@ jobs:
     strategy:
       matrix:
         test:
-          [
-            record_replay_record_replay_block_production,
-            record_replay_record_replay_bootstrap,
-          ]
+          - record_replay_record_replay_block_production
+          - record_replay_record_replay_bootstrap
       fail-fast: false
 
     steps:
@@ -668,7 +666,7 @@ jobs:
           ./${{ matrix.test }} --test-threads=1
 
   bootstrap-test:
-    timeout-minutes: 10
+    timeout-minutes: 20
     needs: [build, build-tests]
     runs-on: ubuntu-24.04
     env:

node/testing/src/scenarios/solo_node/bootstrap.rs

@@ -41,7 +41,7 @@ impl SoloNodeBootstrap {
         std::env::set_var("MINA_DISCOVERY_FILTER_ADDR", "true");
         use self::TransitionFrontierSyncState::*;
 
-        const TIMEOUT: Duration = Duration::from_secs(60 * 40);
+        const TIMEOUT: Duration = Duration::from_secs(60 * 60);
 
         let replayer = hosts::replayer();
 

node/testing/tests/record_replay_record_replay_block_production.rs

@@ -2,6 +2,14 @@ use mina_node_testing::scenarios::record_replay::block_production::RecordReplayB
 
 mod common;
 
+// To run locally:
+// ```bash
+// export MINA_DISCOVERY_FILTER_ADDR=false
+// export KEEP_CONNECTION_WITH_UNKNOWN_STREAM=true
+// export REPLAYER_MULTIADDR=/dns4/mina-rust-ci-1-libp2p.gcp.o1test.net/tcp/8302/p2p/12D3KooWQi9rSWT2kmEavbEc5eP13nG1FRStMiERKZB3wPJSkNrE
+// export BPF_ALIAS=/coda/0.0.1/29936104443aaf264a7f0192ac64b1c7173198c1ed404c1bcff5e562e05eb7f6-0.0.0.0
+// cargo test -r --package mina-node-testing --test record_replay_record_replay_block_production -- record_replay_block_production --exact --nocapture
+// ```
 scenario_test!(
     record_replay_block_production,
     RecordReplayBlockProduction,

node/testing/tests/record_replay_record_replay_bootstrap.rs

@@ -2,6 +2,14 @@ use mina_node_testing::scenarios::record_replay::bootstrap::RecordReplayBootstra
 
 mod common;
 
+// To run locally:
+// ```bash
+// export MINA_DISCOVERY_FILTER_ADDR=false
+// export KEEP_CONNECTION_WITH_UNKNOWN_STREAM=true
+// export REPLAYER_MULTIADDR=/dns4/mina-rust-ci-1-libp2p.gcp.o1test.net/tcp/8302/p2p/12D3KooWQi9rSWT2kmEavbEc5eP13nG1FRStMiERKZB3wPJSkNrE
+// export BPF_ALIAS=/coda/0.0.1/29936104443aaf264a7f0192ac64b1c7173198c1ed404c1bcff5e562e05eb7f6-0.0.0.0
+// cargo test -r --package mina-node-testing --test record_replay_record_replay_bootstrap -- record_replay_bootstrap --exact --nocapture
+// ```
 scenario_test!(
     record_replay_bootstrap,
     RecordReplayBootstrap,

node/testing/tests/single_node_accept_incoming.rs

@@ -4,6 +4,14 @@ use mina_node_testing::scenarios::solo_node::basic_connectivity_accept_incoming:
 
 mod common;
 
+// To run locally:
+// ```bash
+// export MINA_DISCOVERY_FILTER_ADDR=false
+// export KEEP_CONNECTION_WITH_UNKNOWN_STREAM=true
+// export REPLAYER_MULTIADDR=/dns4/mina-rust-ci-1-libp2p.gcp.o1test.net/tcp/8302/p2p/12D3KooWQi9rSWT2kmEavbEc5eP13nG1FRStMiERKZB3wPJSkNrE
+// export BPF_ALIAS=/coda/0.0.1/29936104443aaf264a7f0192ac64b1c7173198c1ed404c1bcff5e562e05eb7f6-0.0.0.0
+// cargo test -r --package mina-node-testing --test single_node_accept_incoming -- accept_incoming --exact --nocapture
+// ```
 scenario_test!(
     accept_incoming,
     SoloNodeBasicConnectivityAcceptIncoming,

node/testing/tests/single_node_bootstrap_from_replayer.rs

@@ -8,11 +8,7 @@ mod common;
 // export KEEP_CONNECTION_WITH_UNKNOWN_STREAM=true
 // export REPLAYER_MULTIADDR=/dns4/mina-rust-ci-1-libp2p.gcp.o1test.net/tcp/8302/p2p/12D3KooWQi9rSWT2kmEavbEc5eP13nG1FRStMiERKZB3wPJSkNrE
 // export BPF_ALIAS=/coda/0.0.1/29936104443aaf264a7f0192ac64b1c7173198c1ed404c1bcff5e562e05eb7f6-0.0.0.0
-// cargo test --release \
-//   --package=mina-node-testing
-//   --package=cli -- \
-//     --exact bootstrap_from_replayer
-//     --nocapture
+// cargo test -r --package mina-node-testing --test single_node_bootstrap_from_replayer -- bootstrap_from_replayer --exact --nocapture
 // ```
 scenario_test!(
     bootstrap_from_replayer,

node/testing/tests/single_node_initial_joining.rs

@@ -2,6 +2,14 @@ use mina_node_testing::scenarios::solo_node::basic_connectivity_initial_joining:
 
 mod common;
 
+// To run locally:
+// ```bash
+// export MINA_DISCOVERY_FILTER_ADDR=false
+// export KEEP_CONNECTION_WITH_UNKNOWN_STREAM=true
+// export REPLAYER_MULTIADDR=/dns4/mina-rust-ci-1-libp2p.gcp.o1test.net/tcp/8302/p2p/12D3KooWQi9rSWT2kmEavbEc5eP13nG1FRStMiERKZB3wPJSkNrE
+// export BPF_ALIAS=/coda/0.0.1/29936104443aaf264a7f0192ac64b1c7173198c1ed404c1bcff5e562e05eb7f6-0.0.0.0
+// cargo test -r --package mina-node-testing --test single_node_initial_joining -- initial_joining --exact --nocapture
+// ```
 scenario_test!(
     initial_joining,
     SoloNodeBasicConnectivityInitialJoining,