rust: Adjust what lints we consider globally acceptable

Author: iostat

Makefile

@@ -246,11 +246,17 @@ format-md: ## Format all markdown and MDX files to wrap at 80 characters
 
 .PHONY: lint
 lint: ## Run linter (clippy)
-	cargo clippy --all-targets -- -D warnings --allow clippy::mutable_key_type
+	cargo clippy --all-targets -- -D warnings \
+	  --allow clippy::large_enum_variant \
+	  --allow clippy::result-large-err \
+	  --allow unused
 
 .PHONY: lint-beta
 lint-beta: ## Run linter (clippy) using beta Rust
-	cargo +beta clippy --all-targets -- -D warnings --allow clippy::mutable_key_type
+	cargo +beta clippy --all-targets -- -D warnings \
+	  --allow clippy::large_enum_variant \
+	  --allow clippy::result-large-err \
+	  --allow unused
 
 .PHONY: lint-bash
 lint-bash: ## Check all shell scripts using shellcheck

ledger/src/lib.rs

@@ -97,6 +97,10 @@
 #![allow(clippy::len_without_is_empty)]
 #![allow(clippy::result_unit_err)]
 // #![forbid(clippy::needless_pass_by_ref_mut)]
+#![allow(
+    clippy::mutable_key_type,
+    reason = "Deep within ValidCommandWithHash (used by TransactionPool) is a MutableFp that should probably be just Fp. Deserialize will not trigger UB. Remove this allow when fixed"
+)]
 
 // Unused, we don't want to print on stdout
 // /// Print logs on stdout with the prefix `[ledger]`

vendor/redux/src/callback.rs

@@ -11,7 +11,7 @@ pub struct AnyAction(pub Box<dyn std::any::Any>);
 #[distributed_slice]
 pub static CALLBACKS: [(&str, fn(&str, Box<dyn std::any::Any>) -> AnyAction)];
 
-#[derive(PartialEq, Eq, Clone, Debug, Serialize, Deserialize)]
+#[derive(Clone, Debug, Serialize, Deserialize)]
 pub struct Callback<T> {
     #[serde(skip, default = "default_fun_ptr")]
     fun_ptr: Option<fn(T) -> AnyAction>,