Merge pull request #940 from openmina/tx_fuzzer_updates

Tx fuzzer updates

Author: tizoc

.github/workflows/ci.yaml

@@ -43,6 +43,24 @@ jobs:
           cd ledger
           cargo test --release -- -Z unstable-options --report-time
 
+  tx-fuzzer-check:
+    runs-on: ubuntu-20.04
+    steps:
+      - name: Git checkout
+        uses: actions/checkout@v4
+      - name: Setup build dependencies
+        run: |
+          sudo apt update
+          sudo apt install -y protobuf-compiler
+      - name: Setup Rust
+        run: |
+          rustup install nightly
+          rustup override set nightly
+      - name: Check for compilation errors in transaction fuzzer
+        run: |
+          cd tools/fuzzing
+          cargo check
+
   p2p-tests:
     runs-on: ubuntu-20.04
     steps:

Cargo.lock

@@ -4,10 +4,11 @@ use std::fmt::Display;
 use ark_ff::fields::arithmetic::InvalidBigInt;
 use ark_ff::Zero;
 use itertools::{FoldWhile, Itertools};
-use mina_hasher::Fp;
+use mina_hasher::{Fp, Hashable, ROInput};
 use mina_p2p_messages::binprot;
 use mina_p2p_messages::v2::{MinaBaseUserCommandStableV2, MinaTransactionTransactionStableV2};
 use mina_signer::CompressedPubKey;
+use mina_signer::NetworkId;
 use openmina_core::constants::ConstraintConstants;
 use openmina_macros::SerdeYojsonEnum;
 use poseidon::hash::params::{CODA_RECEIPT_UC, MINA_ZKAPP_MEMO};
@@ -4215,6 +4216,25 @@ pub mod zkapp_statement {
         }
     }
 
+    impl Hashable for TransactionCommitment {
+        type D = NetworkId;
+
+        fn to_roinput(&self) -> ROInput {
+            let mut roi = ROInput::new();
+            roi = roi.append_field(self.0);
+            roi
+        }
+
+        fn domain_string(network_id: NetworkId) -> Option<String> {
+            match network_id {
+                NetworkId::MAINNET => openmina_core::network::mainnet::SIGNATURE_PREFIX,
+                NetworkId::TESTNET => openmina_core::network::devnet::SIGNATURE_PREFIX,
+            }
+            .to_string()
+            .into()
+        }
+    }
+
     #[derive(Clone, Debug)]
     pub struct ZkappStatement {
         pub account_update: TransactionCommitment,

ledger/src/scan_state/transaction_logic.rs

@@ -6,6 +6,7 @@ edition = "2021"
 
 [dependencies]
 ark-serialize = "0.4.2"
+poseidon = { workspace = true }
 mina-hasher = { workspace = true }
 mina-signer = { workspace = true }
 mina-curves = { workspace = true }

tools/fuzzing/Cargo.toml

@@ -9,7 +9,6 @@ use crate::transaction_fuzzer::generator::gen_curve_point;
 use ark_ff::Zero;
 use ledger::{
     generators::zkapp_command_builder::get_transaction_commitments,
-    hash_with_kimchi,
     scan_state::{
         currency::{Amount, Balance, Fee, MinMax, Nonce, Signed, Slot},
         transaction_logic::{
@@ -40,6 +39,7 @@ use mina_p2p_messages::{
     },
 };
 use mina_signer::{CompressedPubKey, NetworkId, Signature, Signer};
+use poseidon::hash::{hash_with_kimchi, params::MINA_ACCOUNT_UPDATE_CONS};
 use rand::{seq::SliceRandom, Rng};
 
 #[coverage(off)]
@@ -321,15 +321,13 @@ impl MutatorFromAccount<Timing> for FuzzerCtx {
                     _ => unimplemented!(),
                 }
             }
-        } else {
-            if self.gen.rng.gen_bool(0.5) {
-                *t = Timing::Timed {
-                    initial_minimum_balance: self.gen(),
-                    cliff_time: self.gen(),
-                    cliff_amount: self.gen(),
-                    vesting_period: self.gen(),
-                    vesting_increment: self.gen(),
-                }
+        } else if self.gen.rng.gen_bool(0.5) {
+            *t = Timing::Timed {
+                initial_minimum_balance: self.gen(),
+                cliff_time: self.gen(),
+                cliff_amount: self.gen(),
+                vesting_period: self.gen(),
+                vesting_increment: self.gen(),
             }
         }
     }
@@ -708,8 +706,10 @@ impl Mutator<zkapp_command::CallForest<AccountUpdate>> for FuzzerCtx {
                 Fp::zero()
             };
 
-            t.0[i].stack_hash =
-                MutableFp::new(hash_with_kimchi("MinaAcctUpdateCons", &[tree_digest, h_tl]));
+            t.0[i].stack_hash = MutableFp::new(hash_with_kimchi(
+                &MINA_ACCOUNT_UPDATE_CONS,
+                &[tree_digest, h_tl],
+            ));
         }
     }
 }