Skip to content

Commit ad84b13

Browse files
authored
Merge pull request #1573 from o1-labs/1572-add-missing-database-setup-step-to-the-release-verification-process
Add missing database setup step to the release verification process
2 parents 156d79e + d795172 commit ad84b13

File tree

5 files changed

+52
-6
lines changed

5 files changed

+52
-6
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,4 @@ website/static/api-docs/
1919
ledger/3.0.0mainnet
2020
ledger/berkeley-devnet
2121
mina-workdir
22+
.idea/

CHANGELOG.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1414

1515
### Added
1616

17+
- **Development Tools**: Add `setup-taplo` and `setup` Makefile targets to
18+
simplify development environment setup. Update `release-validate` script to
19+
test only packages that are tested in CI, avoiding untested packages with
20+
failing tests
21+
([#1573](https://github.com/o1-labs/mina-rust/pull/1573))
1722
- **CI**: Add validation workflows for block producer nodes infrastructure,
1823
including connectivity and API capability testing similar to plain nodes
1924
([#1571](https://github.com/o1-labs/mina-rust/pull/1571))
@@ -83,6 +88,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
8388

8489
### Changed
8590

91+
- **Development Tools**: Update taplo configuration to exclude `node_modules` and
92+
`target` directories from TOML formatting checks
93+
([#1573](https://github.com/o1-labs/mina-rust/pull/1573))
8694
- **CI**: Speed up CI by decoupling test runs from full build completion.
8795
Created dedicated single-platform build jobs that run only on ubuntu-22.04
8896
to produce artifacts needed for testing, allowing tests to start as soon as
@@ -132,6 +140,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
132140
- **tools**: remove producer-dashboard
133141
([#1578](https://github.com/o1-labs/mina-rust/pull/1578))
134142

143+
### Fixed
144+
145+
- **Development Tools**: Fix `fix-trailing-whitespace` Makefile target to work
146+
correctly on macOS by removing conflicting `-e` flag in sed command
147+
([#1573](https://github.com/o1-labs/mina-rust/pull/1573))
148+
135149
## v0.17.0
136150

137151
### OCaml node

Makefile

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ fix-trailing-whitespace: ## Remove trailing whitespaces from all files
177177
-not -path "./website/static/api-docs/*" \
178178
-not -path "./website/.docusaurus/*" \
179179
-not -path "./.git/*" \
180-
-exec sh -c 'echo "Processing: $$1"; sed -i"" -e "s/[[:space:]]*$$//" "$$1"' _ {} \; && \
180+
-exec sh -c 'echo "Processing: $$1"; sed -i"" "s/[[:space:]]*$$//" "$$1"' _ {} \; && \
181181
echo "Trailing whitespaces removed."
182182

183183
.PHONY: check-trailing-whitespace
@@ -287,6 +287,13 @@ setup-wasm: ## Setup the WebAssembly toolchain, using nightly
287287
rustup target add wasm32-unknown-unknown --toolchain ${NIGHTLY_RUST_VERSION}-$$TARGET; \
288288
cargo install wasm-bindgen-cli --version ${WASM_BINDGEN_CLI_VERSION}
289289

290+
.PHONY: setup-taplo
291+
setup-taplo: ## Install taplo TOML formatter
292+
cargo install taplo-cli
293+
294+
.PHONY: setup
295+
setup: setup-taplo setup-wasm ## Setup development environment
296+
290297
.PHONY: test
291298
test: ## Run tests
292299
cargo test

taplo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
include = ["**/*.toml"]
2+
exclude = ["**/node_modules/**", "**/target/**", "**/.git/**"]
23

34
[formatting]
45
reorder_keys = false

website/docs/developers/scripts/release/validate.sh

Lines changed: 28 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,34 @@ set -e
33

44
echo "Validating codebase for release..."
55

6-
echo "Running tests..."
7-
make test
6+
echo "Setting up required tools..."
7+
make setup-taplo
88

9-
echo "Running tests in release mode..."
10-
make test-release
9+
echo "Cleaning build artifacts to avoid version conflicts..."
10+
cargo clean
11+
12+
echo "=== Testing stable Rust packages ==="
13+
14+
echo "Testing mina-node-native..."
15+
make test-node-native
16+
17+
echo "Testing p2p..."
18+
make test-p2p
19+
20+
echo "Testing account..."
21+
make test-account
22+
23+
echo "=== Cleaning for nightly Rust packages ==="
24+
cargo clean
25+
26+
echo "Testing ledger..."
27+
make test-ledger
28+
29+
echo "Testing mina-p2p-messages..."
30+
make test-p2p-messages
31+
32+
echo "Testing vrf..."
33+
make test-vrf
1134

1235
echo "Checking code formatting..."
1336
make check-format
@@ -18,4 +41,4 @@ make fix-trailing-whitespace
1841
echo "Verifying no trailing whitespace remains..."
1942
make check-trailing-whitespace
2043

21-
echo "Release validation completed successfully!"
44+
echo "Release validation completed successfully!"

0 commit comments

Comments
 (0)