Added exit if initial peers are invalid

Author: 0xMimir

CHANGELOG.md

@@ -21,6 +21,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   Dashboard, documenting all endpoints and specific data fields used by the
   frontend ([#1566](https://github.com/o1-labs/mina-rust/issues/1566))
 
+- **FEATURE**: Add logic to exit the node if initial peers are invalid 
+  ([#1703](https://github.com/o1-labs/mina-rust/pull/1703))
+
 ### Fixed
 
 - **Docker Compose**: Fix frontend black screen issue by changing environment

node/src/action.rs

@@ -57,6 +57,7 @@ pub enum Action {
     RpcEffectful(RpcEffectfulAction),
 
     WatchedAccounts(WatchedAccountsAction),
+    Exit(ExitAction),
 }
 
 impl Action {
@@ -71,7 +72,11 @@ impl Action {
 #[derive(Serialize, Deserialize, Debug, Clone)]
 pub struct CheckTimeoutsAction {}
 
+#[derive(Serialize, Deserialize, Debug, Clone)]
+pub struct ExitAction {}
+
 impl redux::EnablingCondition<crate::State> for CheckTimeoutsAction {}
+impl redux::EnablingCondition<crate::State> for ExitAction {}
 
 impl redux::EnablingCondition<crate::State> for Action {
     fn is_enabled(&self, state: &crate::State, time: redux::Timestamp) -> bool {
@@ -105,6 +110,7 @@ impl redux::EnablingCondition<crate::State> for Action {
             Action::TransactionPoolEffect(a) => a.is_enabled(state, time),
             Action::P2pCallbacks(a) => a.is_enabled(state, time),
             Action::RpcEffectful(a) => a.is_enabled(state, time),
+            Action::Exit(a) => a.is_enabled(state, time),
         }
     }
 }

node/src/action_kind.rs

@@ -107,7 +107,7 @@ use crate::{
         TransitionFrontierAction,
     },
     watched_accounts::WatchedAccountsAction,
-    Action, ActionKindGet, CheckTimeoutsAction,
+    Action, ActionKindGet, CheckTimeoutsAction, ExitAction,
 };
 
 /// Unified kind enum for all action types
@@ -177,6 +177,7 @@ pub enum ActionKind {
     EventSourceProcessEvents,
     EventSourceWaitForEvents,
     EventSourceWaitTimeout,
+    Exit,
     ExternalSnarkWorkerCancelWork,
     ExternalSnarkWorkerError,
     ExternalSnarkWorkerKill,
@@ -757,7 +758,7 @@ pub enum ActionKind {
 }
 
 impl ActionKind {
-    pub const COUNT: u16 = 628;
+    pub const COUNT: u16 = 629;
 }
 
 impl std::fmt::Display for ActionKind {
@@ -789,6 +790,7 @@ impl ActionKindGet for Action {
             Self::Rpc(a) => a.kind(),
             Self::RpcEffectful(a) => a.kind(),
             Self::WatchedAccounts(a) => a.kind(),
+            Self::Exit(a) => a.kind(),
         }
     }
 }
@@ -1260,6 +1262,12 @@ impl ActionKindGet for WatchedAccountsAction {
     }
 }
 
+impl ActionKindGet for ExitAction {
+    fn kind(&self) -> ActionKind {
+        ActionKind::Exit
+    }
+}
+
 impl ActionKindGet for P2pInitializeAction {
     fn kind(&self) -> ActionKind {
         match self {

node/src/effects.rs

@@ -102,7 +102,8 @@ pub fn effects<S: Service>(store: &mut Store<S>, action: ActionWithMeta) {
         | Action::Rpc(_)
         | Action::WatchedAccounts(_)
         | Action::P2pCallbacks(_)
-        | Action::P2p(_) => {
+        | Action::P2p(_)
+        | Action::Exit(_) => {
             // Handled by reducer
         }
     }

node/src/reducer.rs

@@ -1,3 +1,5 @@
+use std::process;
+
 use mina_core::{bug_condition, error, Substate};
 use p2p::{P2pAction, P2pEffectfulAction, P2pInitializeAction, P2pState};
 
@@ -6,7 +8,7 @@ use crate::{
     rpc::RpcState,
     state::{BlockProducerState, LedgerState},
     transition_frontier::candidate::TransitionFrontierCandidateAction,
-    Action, ActionWithMeta, EventSourceAction, P2p, State,
+    Action, ActionWithMeta, EventSourceAction, ExitAction, P2p, State,
 };
 
 pub fn reducer(
@@ -17,7 +19,18 @@ pub fn reducer(
     let meta = action.meta().clone();
     match action.action() {
         Action::CheckTimeouts(_) => {
-            if state.p2p.ready().is_some() {
+            if let Some(p2p) = state.p2p.ready() {
+                if let Some(kad_state) = &p2p.network.scheduler.discovery_state {
+                    if p2p.ready_peers().is_empty() && kad_state.has_bootstraped {
+                        if let Some(tip) = &state.transition_frontier.best_tip_breadcrumb() {
+                            // TODO: this might need to change in future
+                            if tip.height() == 296372 {
+                                dispatcher.push(ExitAction {});
+                            }
+                        }
+                    }
+                }
+
                 if let Err(error) =
                     P2pState::p2p_timeout_dispatch(Substate::new(state, dispatcher), &meta)
                 {
@@ -108,6 +121,18 @@ pub fn reducer(
         Action::P2pCallbacks(action) => {
             State::p2p_callback_reducer(Substate::new(state, dispatcher), meta.with_action(action))
         }
+        Action::Exit(_) => {
+            // In some tests we want the node to fail because we are testing for handling
+            #[cfg(not(test))]
+            {
+                crate::core::error!(
+                    crate::core::log::system_time();
+                    summary = "Exiting",
+                    error = "Invalid initial peers"
+                );
+                process::exit(1);
+            }
+        }
     }
 
     // must be the last.

p2p/src/network/kad/p2p_network_kad_reducer.rs

@@ -133,6 +133,7 @@ impl super::P2pNetworkKadState {
                     time: meta.time(),
                     stats: bootstrap_state.stats.clone(),
                 };
+                state.has_bootstraped = true;
                 Ok(())
             }
             (_, P2pNetworkKademliaAction::UpdateRoutingTable { peer_id, addrs }) => {

p2p/src/network/kad/p2p_network_kad_state.rs

@@ -60,6 +60,7 @@ pub struct P2pNetworkKadState {
     pub streams: StreamState<P2pNetworkKadStreamState>,
     pub status: P2pNetworkKadStatus,
     pub filter_addrs: bool,
+    pub has_bootstraped: bool,
 }
 
 impl Default for P2pNetworkKadState {
@@ -74,6 +75,7 @@ impl Default for P2pNetworkKadState {
                 .ok()
                 .and_then(|s| s.parse().ok())
                 .unwrap_or(true),
+            has_bootstraped: false,
         }
     }
 }